Page MenuHomeSoftware Heritage
Create Task
Maniphest T3899

Clean nfs mountpoint on workers
Closed, MigratedEdits Locked
Actions

Description

The workers have useless r/w mountpoint on the storage server.

root@pergamon:/etc/clustershell# clush -b -w @workers -w @staging-workers -w moma "grep nfs /etc/fstab"
---------------
worker[01-16],worker[01-13].euwest.azure,worker[0-3].internal.staging.swh.network (33)
---------------
saam:/srv/storage/space	/srv/storage/space	nfs	rw,soft,intr,rsize=8192,wsize=8192,noauto,x-systemd.automount,x-systemd.device-timeout=10	0	0
saam:/srv/softwareheritage/objects	/srv/softwareheritage/objects	nfs	rw,soft,intr,rsize=8192,wsize=8192,noauto,x-systemd.automount,x-systemd.device-timeout=10	0	0
---------------
moma
---------------
saam:/srv/storage/space                    /srv/storage/space             nfs   rw,soft,intr,rsize=8192,wsize=8192,x-systemd.automount,x-systemd.device-timeout=10  0  0
saam ~ % grep -e "/objects " -e "space " /etc/exports
/srv/storage/space                            192.168.100.0/24(rw,no_subtree_check,async,fsid=1) 192.168.200.0/21(rw,no_subtree_check,async,fsid=1) 192.168.130.100/32(ro,no_subtree_check,async,fsid=1)
/srv/softwareheritage/objects     192.168.100.31(rw,no_subtree_check,crossmnt,async,fsid=2)
  • The 'objects' mount can't be completely removed as it's not allowed by saam
  • The 'space' mounts can be converted into r/o mount point

Revisions and Commits

rSPSITE puppet-swh-site
D7068rSPSITE37739f1543ea mountpoints: remove useless default mountpoints

Related Objects

Event Timeline

vsellier changed the task status from Open to Work in Progress.Jan 31 2022, 12:32 PM
vsellier triaged this task as Normal priority.
vsellier created this task.
vsellier added a project: System administration.
vsellier moved this task from Backlog to in-progress on the System administration board.
vsellier added a revision: D7068: mountpoints: remove useless default mountpoints.Feb 3 2022, 11:32 AM
vsellier added a commit: rSPSITE37739f1543ea: mountpoints: remove useless default mountpoints.Feb 3 2022, 11:43 AM
vsellier added a comment.Feb 3 2022, 12:01 PM
  • D7068 deployed and applied on the workers:
root@pergamon:/etc/clustershell# clush -b -w @workers -w worker17 -w worker18 "set -e; puppet agent --test"
clush:  0/31
clush: in progress(31): worker[01-18],worker[01-13].euwest.azure
---------------
worker01.euwest.azure
---------------
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Info: Caching catalog for worker01.euwest.azure.internal.softwareheritage.org
Info: Applying configuration version '1643885189'
Notice: Applied catalog in 11.65 seconds
...
------------
worker18
---------------
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Info: Caching catalog for worker18.softwareheritage.org
Info: Applying configuration version '1643885204'
Notice: /Stage[main]/Profile::Mountpoints/Mount[/srv/storage/space]/options: options changed 'rw,soft,intr,rsize=8192,wsize=8192,noauto,x-systemd.automount,x-systemd.device-timeout=10' to 'ro,soft,intr,rsize=8192,wsize=8192,noauto,x-systemd.automount,x-systemd.device-timeout=10'
Info: Computing checksum on file /etc/fstab
Info: /Stage[main]/Profile::Mountpoints/Mount[/srv/storage/space]: Scheduling refresh of Mount[/srv/storage/space]
Info: Mount[/srv/storage/space](provider=parsed): Remounting
Notice: /Stage[main]/Profile::Mountpoints/Mount[/srv/storage/space]: Triggered 'refresh' from 1 event
Info: /Stage[main]/Profile::Mountpoints/Mount[/srv/storage/space]: Scheduling refresh of Mount[/srv/storage/space]
Notice: Applied catalog in 19.67 seconds
clush: worker[01-18] (18): exited with exit code 2
  • Cleanup of the fstab files:
root@pergamon:/etc/clustershell# clush -b -w @workers -w worker17 -w worker18 "set -e; cp /etc/fstab /etc/fstab.orig; grep -v /srv/softwareheritage/objects /etc/fstab > /tmp/fstab.updated; cp /tmp/fstab.updated /etc/fstab; diff -U3 /etc/fstab.orig /etc/fstab"
---------------
worker01
---------------
--- /etc/fstab.orig	2022-02-03 10:59:49.151034118 +0000
+++ /etc/fstab	2022-02-03 10:59:49.155034122 +0000
@@ -14,4 +14,3 @@
 saam:/srv/storage/space	/srv/storage/space	nfs	ro,soft,intr,rsize=8192,wsize=8192,noauto,x-systemd.automount,x-systemd.device-timeout=10	0	0
 LABEL="swap"	swap	swap	sw	0	0
 tmpfs	/tmp	tmpfs	size=85899341824,nr_inodes=200m,noexec,nosuid,nodev,relatime,rw	0	0
-saam:/srv/softwareheritage/objects	/srv/softwareheritage/objects	nfs	rw,soft,intr,rsize=8192,wsize=8192,noauto,x-systemd.automount,x-systemd.device-timeout=10	0	0
...
---------------
worker18
---------------
--- /etc/fstab.orig	2022-02-03 10:59:49.552206491 +0000
+++ /etc/fstab	2022-02-03 10:59:49.564206952 +0000
@@ -17,4 +17,3 @@
 
 tmpfs	/tmp	tmpfs	size=,nr_inodes=200m,noexec,nosuid,nodev,relatime,rw	0	0
 LABEL="swap"	swap	swap	sw	0	0
-saam:/srv/softwareheritage/objects	/srv/softwareheritage/objects	nfs	rw,soft,intr,rsize=8192,wsize=8192,noauto,x-systemd.automount,x-systemd.device-timeout=10	0	0
vsellier closed this task as Resolved.Feb 3 2022, 12:02 PM
vsellier moved this task from in-progress to done on the System administration board.
olasd added a subscriber: olasd.Mar 4 2022, 7:41 PM

Turns out moma uses the rw /srv/storage/space/swh-deposit mountpoint for deposits. I'll update puppet accordingly.

olasd added a comment.Mar 4 2022, 8:02 PM

Done via e49f0136 and 1ef20592

gitlab-migration changed the task status from Resolved to Migrated.Oct 19 2022, 6:05 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal