Differential D7299

vault: Un-nest checks
ClosedPublic
Actions

Authored by vlorentz on Mar 4 2022, 4:05 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Maniphest Tasks

T3983: Add monitoring of vault bundle downloads

Commits

rDICPb84160621e62: vault: Un-nest checks

Summary

This will allow more checks later, while keeping the code flow linear.

Diff Detail

Repository

rDICP Icinga plugins

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 4 2022, 4:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 4 2022, 4:05 PM

Build is green

Patch application report for D7299 (id=26407)

Rebasing onto c698de2711...

Current branch diff-target is up to date.

Changes applied before test

commit b84160621e62ee2900e8b8ae19f14d6f5c3ff4e7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 16:04:51 2022 +0100

    vault: Un-nest checks
    
    This will allow more checks later, while keeping the code flow linear.

See https://jenkins.softwareheritage.org/job/DICP/job/tests-on-diff/58/ for more details.

Harbormaster completed remote builds in B27294: Diff 26407.Mar 4 2022, 4:06 PM

vlorentz requested review of this revision.Mar 4 2022, 4:06 PM

vlorentz added a task: T3983: Add monitoring of vault bundle downloads.Mar 4 2022, 4:31 PM

olasd accepted this revision.Mar 4 2022, 4:46 PM

This revision is now accepted and ready to land.Mar 4 2022, 4:46 PM

Closed by commit rDICPb84160621e62: vault: Un-nest checks (authored by vlorentz). · Explain WhyMar 4 2022, 5:21 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDICPb84160621e62: vault: Un-nest checks.

Revision Contents
Changeset List

Path

Size

swh/

icinga_plugins/

vault.py

90 lines

Diff 26417

View Options

swh/icinga_plugins/vault.py

vault: Un-nest checksClosedPublicActions