Rebase

Update: Fix for Python 3.7

Update: Add comment

Update: Use function add_commit to improve test readability

Update: Use function add_commit to improve test readability

Update: Add function add_commit to ease tests implementation and readability

The loading issue for the repository in T3694 description has been identified: a commit message has been modified
server side between two save code now requests leading to a discrepancy in computed hashes for revisions.

Looks good to me, thanks !

@posenato, I did some deeper analysis on why your svn repository could not be loaded anymore into the archive
and it turned out @ardumont is right, the commit log of your repository got altered between two save code now requests.

Looks good to me ! I added a couple of nitpick comments to handle before landing this.

Address @vlorentz comments

In D6576#170848, @vlorentz wrote:

What about "incremental", for consistency with the listers' terminology?

I'd rather name it origin_snapshot_get_all, what do you think?

I also hesitated to use that name, I used origin_snapshot_get to match naming of other methods in storage interface but I agree origin_snapshot_get_all is more explicit about what the method does, will rename then.

Fixed and deployed, origin https://git.code.sf.net/u/bsomervi/hamlib.git has been successfully submitted and is currently being loaded into the archive, closing this.

Update doctring

This is because I made the wrong assumption that URL paths to git repos for the git.code.sf.net netloc are necessarily prefixed by /p/.
So URLs starting with https://git.code.sf.net/u/ are currently rejected when submitting save requests through the Web UI , see related frontend code.

LGTM, thanks !

Fixed in swh-lister v2.2.0 and deployed to production, closing this.

drop the computation done in the archive coverage part for those origins.

In D6537#169707, @anlambert wrote:

This is the same diff as D6536 no ?

This is the same diff as D6536 no ?

The issue has been fixed upstream and will be part of next pip release.

Improve comment

Looks good to me, thanks ! I added a last batch of nitpick comments to handle before landing this.

Looks good to me, I can also reproduce the issues after click upgrade to 8.x.

This is moving forward, great ! I added a couple of inline comments to handle.

Jenkins CI job for building SWH docs when submitting diffs to swh-docs is now properly deployed and configured, time to abandon this.

Make the build passes again for last test.