Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Maniphest Tasks
- T3695: Investigate revision reconstruction discrepancy with subversion export
- Commits
- rDLDSVNed8c189b8258: loader: Rename start_from_scratch parameter to incremental
tox
Diff Detail
Diff Detail
- Repository
- rDLDSVN Subversion (SVN) loader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D6576 (id=23896)
Could not rebase; Attempt merge onto 6578b85dd0...
Updating 6578b85..991eeb1 Fast-forward swh/loader/svn/loader.py | 66 +++++++++++++++++++++---------------- swh/loader/svn/svn.py | 7 ++-- swh/loader/svn/tasks.py | 53 +++++++++++++++-------------- swh/loader/svn/tests/test_loader.py | 5 +-- 4 files changed, 70 insertions(+), 61 deletions(-)
Changes applied before test
commit 991eeb1240f0f0b06a8a8dec446f45b06d167703
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 28 13:04:51 2021 +0200
loader: Rename start_from_scratch parameter to ignore_history
This:
- unifies this parameter with the equivalent one in the git loader.
- also documents it
Related to T3695
commit 1573529ad487f4d08621a8ad0ab3461b9992c69b
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 28 12:54:33 2021 +0200
loader: Let logging instructions do the formattingSee https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/141/ for more details.
Comment Actions
What about "incremental", for consistency with the listers' terminology?
sounds fine as well, indeed.
Comment Actions
actually changing to incremental.
Note that this also inverts the default value for that param.
Comment Actions
Build is green
Patch application report for D6576 (id=23912)
Rebasing onto 1573529ad4...
Current branch diff-target is up to date.
Changes applied before test
commit ed8c189b8258adf5f88c471b93606f3fc2337b02
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Thu Oct 28 13:04:51 2021 +0200
loader: Rename start_from_scratch parameter to incremental
This:
- unifies this parameter name with names similar to what's used in lister
- also documents it better
Related to T3695See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/142/ for more details.