Page MenuHomeSoftware Heritage

loader: Fix SvnLoaderFromDumpArchive and add test
ClosedPublic

Authored by anlambert on Oct 22 2021, 4:55 PM.

Details

Summary

Previously SvnLoaderFromDumpArchive was trying to connect to the origin
URL provided as parameter while it should not happen.

For the dump archive case, the subversion repository is recreated locally
from a dump file so the subversion repository URL must correspond to
the local path of that repository.

Also add missing test for that specific loader.

Closes T3686

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont added a subscriber: ardumont.

That sounds about right to me!

Thanks!

This revision is now accepted and ready to land.Oct 22 2021, 4:56 PM

Build is green

Patch application report for D6542 (id=23781)

Rebasing onto 5454c2601a...

Current branch diff-target is up to date.
Changes applied before test
commit 6578b85dd0245dfa21c868edf5fbe2fdea6833bb
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Oct 22 16:39:41 2021 +0200

    loader: Fix SvnLoaderFromDumpArchive and add test
    
    Previously SvnLoaderFromDumpArchive was trying to connect to the origin
    URL provided as parameter while it should not happen.
    
    For the dump archive case, the subversion repository is recreated locally
    from a dump file so the subversion repository URL must correspond to
    the local path of that repository.
    
    Also add missing test for that specific loader.
    
    Closes T3686

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/139/ for more details.