Differential D6544

coverage: Drop the cran origins computation workaround
ClosedPublic
Actions

Authored by ardumont on Oct 22 2021, 5:29 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T3675: Investigate why cran origins are marked as non-visited in the scheduler metrics

Commits

rDWAPPS1edcf35c4849: coverage: Drop the cran origins computation workaround

Summary

The origin visit type were mistyped which rendered those actually not visited. This is
now properly fixed upstream.

Related to T3675

Test Plan

tox

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Oct 22 2021, 5:29 PM

ardumont mentioned this in T3675: Investigate why cran origins are marked as non-visited in the scheduler metrics.Oct 22 2021, 5:32 PM

Build is green

Patch application report for D6544 (id=23785)

Rebasing onto 0c04ede6c0...

Current branch diff-target is up to date.

Changes applied before test

commit 9dd66d99eecdea711689b20ec397d566802da022
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 22 17:22:58 2021 +0200

    coverage: Drop the cran origins computation workaround
    
    The origin visit type were mistyped which rendered those actually not visited. This is
    now properly fixed upstream.
    
    Related to T3675

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1208/ for more details.

Harbormaster completed remote builds in B24670: Diff 23785.Oct 22 2021, 5:44 PM

ardumont requested review of this revision.Oct 22 2021, 5:44 PM

anlambert requested changes to this revision.Oct 22 2021, 6:44 PM

anlambert added inline comments.

swh/web/misc/coverage.py
320–325	This code must stay as only visited origins are counted and displayed.
327	Simply remove that if condition.

This revision now requires changes to proceed.Oct 22 2021, 6:44 PM

ardumont added inline comments.Oct 25 2021, 10:01 AM

swh/web/misc/coverage.py
320–325	the linter mentioned it was unused... i'll double check.

ardumont added inline comments.Oct 25 2021, 10:04 AM

swh/web/misc/coverage.py
320–325	yes, that's it. my buffer linter mentioned as much, looking at the code, i did not see it used. And finally, pre-commit did not want me to commit: swh/web/misc/coverage.py:320:9: F841 local variable 'count_never_visited' is assigned to but never used

anlambert added inline comments.Oct 25 2021, 10:57 AM

swh/web/misc/coverage.py
320–325	It mentioned it was unused because you removed the whole if block, only the if line must be removed.

Adapt correctly according to review

LGTM, thanks !

This revision is now accepted and ready to land.Oct 25 2021, 11:38 AM

Build is green

Patch application report for D6544 (id=23794)

Rebasing onto 0c04ede6c0...

Current branch diff-target is up to date.

Changes applied before test

commit 1edcf35c484912c82b0557924a06eb8993a8d8d6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Oct 22 17:22:58 2021 +0200

    coverage: Drop the cran origins computation workaround
    
    The origin visit type were mistyped which rendered those actually not visited. This is
    now properly fixed upstream.
    
    Related to T3675

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1209/ for more details.

Harbormaster completed remote builds in B24678: Diff 23794.Oct 25 2021, 11:43 AM

Closed by commit rDWAPPS1edcf35c4849: coverage: Drop the cran origins computation workaround (authored by ardumont). · Explain WhyOct 25 2021, 12:07 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDWAPPS1edcf35c4849: coverage: Drop the cran origins computation workaround.