Page MenuHomeSoftware Heritage
Create Task
Maniphest T3690

Save code now ui rejects valid git sourceforge origin
Closed, MigratedEdits Locked
Actions

Description

Trying to submit a save code now request [1] with a valid git sourceforge origin [2] is rejected in the validation input ui [3].

This should be ok to submit such origin.

[1] https://archive.softwareheritage.org/save/#requests

[2] Ingestion for that origin is ok: P1209

[3]

Revisions and Commits

rDWAPPS Web applications
D6551rDWAPPS2f5d8cc1fbd3 assets/save: Fix sourceforge git repository URL validation

Related Objects

Mentioned Here
P1209 ingestion ok

Event Timeline

ardumont triaged this task as Normal priority.Oct 26 2021, 10:37 AM
ardumont created this task.
ardumont added a project: Save Code Now.
ardumont added a subscriber: zimoun.
ardumont updated the task description. (Show Details)Oct 26 2021, 10:40 AM
anlambert added a subscriber: anlambert.Oct 26 2021, 11:18 AM

This is because I made the wrong assumption that URL paths to git repos for the git.code.sf.net netloc are necessarily prefixed by /p/.
So URLs starting with https://git.code.sf.net/u/ are currently rejected when submitting save requests through the Web UI , see related frontend code.

Diff fixing that invalid behavior incoming.

anlambert added a revision: D6551: assets/save: Fix sourceforge git repository URL validation.Oct 26 2021, 11:30 AM
anlambert added a commit: rDWAPPS2f5d8cc1fbd3: assets/save: Fix sourceforge git repository URL validation.Oct 26 2021, 1:19 PM
anlambert closed this task as Resolved.Oct 26 2021, 5:45 PM
anlambert claimed this task.

Fixed and deployed, origin https://git.code.sf.net/u/bsomervi/hamlib.git has been successfully submitted and is currently being loaded into the archive, closing this.

gitlab-migration changed the task status from Resolved to Migrated.Jan 8 2023, 10:02 PM
gitlab-migration claimed this task.
gitlab-migration added a subscriber: gitlab-migration.

This task has been migrated to GitLab.

About · Developer information · Legal