Page MenuHomeSoftware Heritage
Feed Advanced Search

Aug 19 2021

anlambert retitled D6117: Makefile.local: add dependency between test and ts-build-so targets from Makefile.local: Fix make test command and add dependency to ts-build-so to Makefile.local: add dependency between test and ts-build-so targets.
Aug 19 2021, 4:58 PM
anlambert updated the diff for D6117: Makefile.local: add dependency between test and ts-build-so targets.

Remove TEST_DIRS modification.

Aug 19 2021, 4:57 PM
anlambert added a comment to D6117: Makefile.local: add dependency between test and ts-build-so targets.

I don't think that issue is specific to swh-search, I have it with other packages from time to time. rm build/ -rf should fix it.

Aug 19 2021, 4:55 PM
anlambert retitled D6117: Makefile.local: add dependency between test and ts-build-so targets from Makefile.local: Fix make test command and add dependency to ts-build-soFor some reasons, I have the following error when calling `make test`.```python3 -m pytest . to Makefile.local: Fix make test command and add dependency to ts-build-so.
Aug 19 2021, 4:52 PM
anlambert retitled D6117: Makefile.local: add dependency between test and ts-build-so targets from Makefile.local: Fix make test command and add dependency to ts-build-so For some reasons, I have the following error when calling `make test`. ``` python3 -m pytest . to Makefile.local: Fix make test command and add dependency to ts-build-soFor some reasons, I have the following error when calling `make test`.```python3 -m pytest ..
Aug 19 2021, 4:50 PM
anlambert requested review of D6117: Makefile.local: add dependency between test and ts-build-so targets.
Aug 19 2021, 4:49 PM
anlambert added inline comments to D6004: misc/coverage: Revamp and improve archive coverage widget.
Aug 19 2021, 3:58 PM
anlambert updated the diff for D6004: misc/coverage: Revamp and improve archive coverage widget.

Update:

  • Rename section titles according to @zack suggestions
  • Remove vertical padding around counters to gain vertical space
  • Add fallback when scheduler metrics or deposit lists are not available, widget with logos will stil be displayed but without counters info
Aug 19 2021, 3:56 PM
anlambert added a comment to D6004: misc/coverage: Revamp and improve archive coverage widget.

As a minor suggestion I propose the following heading changes:

 listed origins -> regular crawling
 legacy origins -> discontinued hosting
deposited origins -> on demand archival
Aug 19 2021, 3:13 PM
anlambert added inline comments to D6113: vault API: Rename bundle types and use SWHIDs to identify objects.
Aug 19 2021, 3:09 PM
anlambert accepted D6112: Rename bundle types and use SWHIDs everywhere instead of raw sha1_git.

Looks good but the SQL schema migration file is missing in sql/upgrades so I cannot accept the diff yet.

Actually, we're going to drop the database + objstorage and recreate it, writing a migration for this looks like too much trouble for a cache.

Aug 19 2021, 3:02 PM
anlambert closed D6115: tests: Ensure they all can be run with multiple hypothesis examples.
Aug 19 2021, 3:00 PM
anlambert committed rDWAPPS87cc9e042dc2: tests: Ensure they all can be run with multiple hypothesis examples (authored by anlambert).
tests: Ensure they all can be run with multiple hypothesis examples
Aug 19 2021, 3:00 PM
anlambert updated the diff for D6116: api/metadata: Fix issues detected with hypothesis.

Update: Provide RawExtrinsicMetadata targetting core SWHIDs as test inputs and reverse related changes.

Aug 19 2021, 2:55 PM
anlambert added a comment to D6116: api/metadata: Fix issues detected with hypothesis.

We don't want to allow extended SWHID in the public API, you should restrict data generated by hypothesis instead

Aug 19 2021, 2:17 PM
anlambert added a comment to D6115: tests: Ensure they all can be run with multiple hypothesis examples.

Does it mean we need to do def test_inner on *every* test that uses hypothesis?

Aug 19 2021, 2:09 PM
anlambert updated the diff for D6116: api/metadata: Fix issues detected with hypothesis.

Rebase

Aug 19 2021, 1:05 PM
anlambert updated the diff for D6115: tests: Ensure they all can be run with multiple hypothesis examples.

Fix a comment

Aug 19 2021, 1:05 PM
anlambert added inline comments to D6081: Fix api_raw_extrinsic_metadata_swhid-related bugs found when using the 'slow' hypothesis profile.
Aug 19 2021, 1:01 PM
anlambert added a comment to D6116: api/metadata: Fix issues detected with hypothesis.

Oh I missed D6081, I guess we both encounter the same kind of issues but fixes are not exactly the same.

Aug 19 2021, 12:57 PM
anlambert accepted D6110: Replace index-fossology-license-for-range with index-fossology-license-for-partition.
Aug 19 2021, 12:52 PM
anlambert added inline comments to D6115: tests: Ensure they all can be run with multiple hypothesis examples.
Aug 19 2021, 12:51 PM
anlambert requested review of D6116: api/metadata: Fix issues detected with hypothesis.
Aug 19 2021, 12:40 PM
anlambert requested changes to D6112: Rename bundle types and use SWHIDs everywhere instead of raw sha1_git.

Looks good but the SQL schema migration file is missing in sql/upgrades so I cannot accept the diff yet.

Aug 19 2021, 12:28 PM
anlambert requested review of D6115: tests: Ensure they all can be run with multiple hypothesis examples.
Aug 19 2021, 12:27 PM
anlambert accepted D6111: Add support for releases pointing to other releases or contents..
Aug 19 2021, 12:18 PM
anlambert added a comment to D6083: hypothesis: Run with more examples by default.

@vlorentz, I have submitted D6115 and D6116 to ensure swh-web tests can be safely executed with multiple hypothesis examples.

Aug 19 2021, 12:15 PM
anlambert added a revision to T1695: Make hypothesis strategies for swh-web stateless: D6115: tests: Ensure they all can be run with multiple hypothesis examples.
Aug 19 2021, 12:12 PM · Web app

Aug 18 2021

anlambert added a comment to D6083: hypothesis: Run with more examples by default.

Sounds good, thanks! Should I close this diff?

Aug 18 2021, 3:40 PM
anlambert added a comment to D6083: hypothesis: Run with more examples by default.

I need help to fix these failures...

Aug 18 2021, 3:35 PM
anlambert committed rDWAPPS885be5dde5b5: package.json: Upgrade dependencies (authored by anlambert).
package.json: Upgrade dependencies
Aug 18 2021, 12:06 PM
anlambert committed rDWAPPS889f88644a24: browse/utils: Remove dead code (authored by anlambert).
browse/utils: Remove dead code
Aug 18 2021, 12:06 PM
anlambert closed T3486: Content with mime type application/pgp-keys and encoding us-ascii cannot be displayed. as Resolved by committing rDWAPPSc9d89d93b7df: browse/utils: Fix edge case in prepare_content_for_display.
Aug 18 2021, 12:06 PM · Web app
anlambert closed D6107: browse/utils: Fix edge case in prepare_content_for_display.
Aug 18 2021, 12:06 PM
anlambert committed rDWAPPSc9d89d93b7df: browse/utils: Fix edge case in prepare_content_for_display (authored by anlambert).
browse/utils: Fix edge case in prepare_content_for_display
Aug 18 2021, 12:05 PM

Aug 17 2021

anlambert requested review of D6107: browse/utils: Fix edge case in prepare_content_for_display.
Aug 17 2021, 5:11 PM
anlambert planned changes to D6004: misc/coverage: Revamp and improve archive coverage widget.
Aug 17 2021, 4:58 PM
anlambert updated the summary of D6004: misc/coverage: Revamp and improve archive coverage widget.
Aug 17 2021, 4:43 PM
anlambert updated the diff for D6004: misc/coverage: Revamp and improve archive coverage widget.

Update:

  • rebase
  • implement search links for all origin types
  • polish widget rendering: add scrollbar for origin type with lot of instances
Aug 17 2021, 4:42 PM
anlambert added a revision to T3486: Content with mime type application/pgp-keys and encoding us-ascii cannot be displayed.: D6107: browse/utils: Fix edge case in prepare_content_for_display.
Aug 17 2021, 3:30 PM · Web app
anlambert accepted D6106: T3339 Fix various formatting typos in getting started with SWH API..

Looks good to me, thanks !

Aug 17 2021, 2:57 PM
anlambert accepted D6105: git_bare: Statically check for exhaustiveness of enum matching.

Nice !

Aug 17 2021, 2:23 PM
anlambert accepted D6104: git_bare: Add support for contents pointed by snapshots.
Aug 17 2021, 2:20 PM
anlambert accepted D6099: git_bare: Add support for directories as snapshot branches.

LGTM

Aug 17 2021, 12:04 PM
anlambert accepted D6102: git_bare: Use an enum to represent the root object type.

+1, and code is more readable that way imho

Aug 17 2021, 11:22 AM
anlambert accepted D6101: Rename obj_type to bundle_type.

LGTM, we should also rename that parameter in swh-web code related to the vault.

Aug 17 2021, 11:16 AM
anlambert accepted D6100: git_bare: add some modularity to directory creation.
Aug 17 2021, 11:09 AM
anlambert added a comment to D6099: git_bare: Add support for directories as snapshot branches.

Could you add a test for this ?

Aug 17 2021, 11:06 AM
anlambert accepted D6098: git_bare: Skip loading empty lists.
Aug 17 2021, 11:02 AM
anlambert accepted D6097: git_bare: Deduplicate loading of release subgraphs.
Aug 17 2021, 11:00 AM
anlambert accepted D6096: git_bare: Fix crash on dangling branches.
Aug 17 2021, 10:55 AM
anlambert accepted D6095: Disable bundle size limit when running from the CLI..
Aug 17 2021, 10:54 AM

Aug 16 2021

anlambert accepted D6093: storage-cassandra: Remove the default src override.

LGTM

Aug 16 2021, 4:29 PM
anlambert accepted D6092: counters: Match the default configuration to the real production url.

Great, thanks !

Aug 16 2021, 4:06 PM
anlambert created P1120 add swh-search static dir to django.
Aug 16 2021, 12:37 PM

Jul 24 2021

anlambert added a comment to T3442: Make GitLab lister more robust to HTTP errors .
swh-lister_1                     | [2021-07-24 08:58:25,127: INFO/ForkPoolWorker-1] Task swh.lister.gitlab.tasks.FullGitLabRelister[717c82b2-175a-492c-b701-22b4fd34e5e2] succeeded in 139476.781209187s: {'pages': 27470, 'origins': 2746838}
Jul 24 2021, 11:47 AM · Lister

Jul 23 2021

anlambert updated the diff for D6004: misc/coverage: Revamp and improve archive coverage widget.

Update: Activate origins search links in collapsible elements.

Jul 23 2021, 5:49 PM
anlambert created P1098 (An Untitled Masterwork).
Jul 23 2021, 4:59 PM
anlambert closed T3442: Make GitLab lister more robust to HTTP errors as Resolved.

Closing this as requested.

Jul 23 2021, 4:48 PM · Lister
anlambert closed D6021: gitlab: Update requests query parameters.
Jul 23 2021, 3:15 PM
anlambert closed D6022: gitlab: Handle HTTP status code 500 when listing projects.
Jul 23 2021, 3:15 PM
anlambert committed rDLSe904f4760ef1: gitlab: Handle HTTP status code 500 when listing projects (authored by anlambert).
gitlab: Handle HTTP status code 500 when listing projects
Jul 23 2021, 3:15 PM
anlambert committed rDLS52c315015543: gitlab: Update requests query parameters (authored by anlambert).
gitlab: Update requests query parameters
Jul 23 2021, 3:15 PM
anlambert updated the diff for D6022: gitlab: Handle HTTP status code 500 when listing projects.

Fix typo.

Jul 23 2021, 3:07 PM
anlambert added a comment to T3405: GraphQL apis for SWH.

I stumbled across GitLab GraphQL API while working on T3442, could be a great source of inspiration.

Jul 23 2021, 2:45 PM · GraphQL API
anlambert requested review of D6022: gitlab: Handle HTTP status code 500 when listing projects.
Jul 23 2021, 2:40 PM
anlambert added a comment to T3442: Make GitLab lister more robust to HTTP errors .

For the record, my lister is still running, 1320500 gitlab.com origins listed so far.

Jul 23 2021, 2:39 PM · Lister
anlambert added a revision to T3442: Make GitLab lister more robust to HTTP errors : D6022: gitlab: Handle HTTP status code 500 when listing projects.
Jul 23 2021, 2:37 PM · Lister
anlambert requested review of D6021: gitlab: Update requests query parameters.
Jul 23 2021, 2:11 PM
anlambert closed D6020: gitlab: Adapt requests retry policy to consider HTTP 50x status codes.
Jul 23 2021, 2:06 PM
anlambert committed rDLS73f85c0b8a42: gitlab: Adapt requests retry policy to consider HTTP 50x status codes (authored by anlambert).
gitlab: Adapt requests retry policy to consider HTTP 50x status codes
Jul 23 2021, 2:06 PM
anlambert requested review of D6020: gitlab: Adapt requests retry policy to consider HTTP 50x status codes.
Jul 23 2021, 1:57 PM
anlambert added a revision to T3442: Make GitLab lister more robust to HTTP errors : D6020: gitlab: Adapt requests retry policy to consider HTTP 50x status codes.
Jul 23 2021, 1:54 PM · Lister
anlambert updated the task description for T3442: Make GitLab lister more robust to HTTP errors .
Jul 23 2021, 12:19 PM · Lister
anlambert added a comment to T3127: Compute and display distribution of origins by forge.
In T3127#67581, @anlambert wrote:

    I am a bit puzzled by the numbers shown: eeally we have only 200k origins for GitLab.com.?

Indeed there is something weird here as we have more than one million gitlab.com origins in database.

softwareheritage=> select count(*) from origin where url like 'https://gitlab.com/%';
  count  
---------
 1023499
(1 row)

Looks like something was missed when computing lister metrics from scheduler database, this needs further investigations.

Indeed, please do look into this, thanks.

Jul 23 2021, 12:17 PM · Metrics/monitoring, Web app, Roadmap 2021, meta-task
anlambert triaged T3442: Make GitLab lister more robust to HTTP errors as Normal priority.
Jul 23 2021, 12:14 PM · Lister

Jul 22 2021

anlambert updated the summary of D6004: misc/coverage: Revamp and improve archive coverage widget.
Jul 22 2021, 6:23 PM
anlambert updated the diff for D6004: misc/coverage: Revamp and improve archive coverage widget.
  • Improve origin category texts
  • Fix code retrieving lister metrics as some of them were dicarded
  • Add display of distribution of origins per origins type, hidden by default, can be displayed by clicking on any collapsible elements (total origin counts)
Jul 22 2021, 6:16 PM
anlambert updated the summary of D6004: misc/coverage: Revamp and improve archive coverage widget.
Jul 22 2021, 6:16 PM
anlambert triaged T3441: Implement query to get origin visit types dynamically as Normal priority.
Jul 22 2021, 2:41 PM · Archive search
anlambert created P1097 (An Untitled Masterwork).
Jul 22 2021, 2:05 PM
anlambert created P1096 origin types from elasticsearch.
Jul 22 2021, 12:59 PM
anlambert added a comment to T3127: Compute and display distribution of origins by forge.

Thanks for these details: this count is missing the 800k git origins: @ardumont and @olasd should be able to tell you how to find them

Jul 22 2021, 12:29 PM · Metrics/monitoring, Web app, Roadmap 2021, meta-task

Jul 21 2021

anlambert closed D6013: assets/guided_tour: Improve tour and fix redirection bug.
Jul 21 2021, 5:58 PM
anlambert committed rDWAPPS481647f863a6: assets/guided_tour: Improve tour and fix redirection bug (authored by anlambert).
assets/guided_tour: Improve tour and fix redirection bug
Jul 21 2021, 5:58 PM
anlambert updated the diff for D6013: assets/guided_tour: Improve tour and fix redirection bug.

Address @ardumont comment.

Jul 21 2021, 5:34 PM
anlambert added a comment to T3127: Compute and display distribution of origins by forge.

I am a bit puzzled by the numbers shown: eeally we have only 200k origins for GitLab.com.?

Jul 21 2021, 5:26 PM · Metrics/monitoring, Web app, Roadmap 2021, meta-task
anlambert updated subscribers of D6013: assets/guided_tour: Improve tour and fix redirection bug.
Jul 21 2021, 3:26 PM
anlambert added a comment to T3127: Compute and display distribution of origins by forge.

Instead, we could split the coverage widget into two tabs

  • one giving a high level overview of the archived origins, similar to what we have now with logos and counters
  • one giving the details of all forges we archived so far, displayed in a table as you suggested with relevant metrics and links to search origins for a given forge
Jul 21 2021, 3:23 PM · Metrics/monitoring, Web app, Roadmap 2021, meta-task
anlambert requested review of D6013: assets/guided_tour: Improve tour and fix redirection bug.
Jul 21 2021, 2:31 PM
anlambert added a revision to T3437: Review guided tour and collect feedback from testers: D6013: assets/guided_tour: Improve tour and fix redirection bug.
Jul 21 2021, 2:13 PM · Web app
anlambert added inline comments to D6005: docs/query-language: Describe search query language syntax.
Jul 21 2021, 11:18 AM

Jul 20 2021

anlambert updated the diff for D6004: misc/coverage: Revamp and improve archive coverage widget.

Rebase

Jul 20 2021, 4:28 PM
anlambert closed D6008: cypress: Upgrade to 8.0 and fix flaky test.
Jul 20 2021, 4:27 PM
anlambert committed rDWAPPS914c19e314c7: cypress: Upgrade to 8.0 and fix flaky test (authored by anlambert).
cypress: Upgrade to 8.0 and fix flaky test
Jul 20 2021, 4:27 PM
anlambert added a comment to D6008: cypress: Upgrade to 8.0 and fix flaky test.

The diff seems to fix the previously observed flaky test but got bitten by another one which does not happen so often thanks to cypress retry features.

Jul 20 2021, 4:23 PM
anlambert committed rDDOCd200a98043d5: faq: Fix some typos and link displays (authored by anlambert).
faq: Fix some typos and link displays
Jul 20 2021, 3:27 PM
anlambert requested review of D6008: cypress: Upgrade to 8.0 and fix flaky test.
Jul 20 2021, 3:22 PM
anlambert updated the summary of D6004: misc/coverage: Revamp and improve archive coverage widget.
Jul 20 2021, 12:58 PM
anlambert updated the diff for D6004: misc/coverage: Revamp and improve archive coverage widget.
  • Add paragraphs detailing each origins category
  • Add missing Phabricator origins in listed ones
  • Address @ardumont comment about doi.org netlocs for deposits
  • Use only png logos to simplify their integration
  • Resize some large logos
  • Remove no longer used logos
Jul 20 2021, 12:57 PM