Page MenuHomeSoftware Heritage

assets/guided_tour: Improve tour and fix redirection bug
ClosedPublic

Authored by anlambert on Wed, Jul 21, 2:13 PM.

Details

Summary

Reword some sentences and add step showing SWHID with lines qualifer.

Fix redirection at end of tour when started from homepage.

Related to T3437

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6013 (id=21722)

Rebasing onto 914c19e314...

Current branch diff-target is up to date.
Changes applied before test
commit e946f25ad0da729b69f8a1f26bc64ea3eb5c20ce
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 20 16:26:59 2021 +0200

    assets/guided_tour: Improve tour and fix redirection bug
    
    Reword some sentences and add step showing SWHID with lines qualifer.
    
    Fix redirection at end of tour when started from homepage.
    
    Related to T3437

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/980/ for more details.

ardumont added a subscriber: ardumont.

lgtm

one non-blocking suggestion inline.

assets/src/bundles/guided_tour/guided-tour-steps.yaml
89

i liked it as source code but as you wish ;)

Also that stays consistent with the other "source code" mentioned below.

This revision is now accepted and ready to land.Wed, Jul 21, 3:11 PM
anlambert added inline comments.
assets/src/bundles/guided_tour/guided-tour-steps.yaml
89

I guess @moranegg here was refering to source as the place the code was captured from.

I will rephrase into: You can go directly to the place the source code was captured.

Build is green

Patch application report for D6013 (id=21730)

Rebasing onto 914c19e314...

Current branch diff-target is up to date.
Changes applied before test
commit 481647f863a62d0a6f28fadca9e6653851f6a398
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jul 20 16:26:59 2021 +0200

    assets/guided_tour: Improve tour and fix redirection bug
    
    Reword some sentences and add step showing SWHID with lines qualifer.
    
    Fix redirection at end of tour when started from homepage.
    
    Related to T3437

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/981/ for more details.