Differential D6020

gitlab: Adapt requests retry policy to consider HTTP 50x status codes
ClosedPublic
Actions

Authored by anlambert on Jul 23 2021, 1:54 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3442: Make GitLab lister more robust to HTTP errors

Commits

rDLS73f85c0b8a42: gitlab: Adapt requests retry policy to consider HTTP 50x status codes

Summary

Temporarily server failures can happen when listing a GitLab instance,
HTTP status codes 502, 503 or 520 are returned in that case.

So adapt lister requests retry policy to execute requests again when
such errors are encountered.

Related to T3442

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 23 2021, 1:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 23 2021, 1:54 PM

Build is green

Patch application report for D6020 (id=21759)

Rebasing onto f00d41d0cd...

Current branch diff-target is up to date.

Changes applied before test

commit 73f85c0b8a429c973334606263722fc3086178c1
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Jul 23 13:51:10 2021 +0200

    gitlab: Adapt requests retry policy to consider HTTP 50x status codes
    
    Temporarily server failures can happen when listing a GitLab instance,
    HTTP status codes 502, 503 or 520 are returned in that case.
    
    So adapt lister requests retry policy to execute requests again when
    such errors are encountered.
    
    Related to T3442

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/333/ for more details.

Harbormaster completed remote builds in B22726: Diff 21759.Jul 23 2021, 1:57 PM

anlambert requested review of this revision.Jul 23 2021, 1:57 PM

ardumont accepted this revision.Jul 23 2021, 1:58 PM

This revision is now accepted and ready to land.Jul 23 2021, 1:58 PM

Closed by commit rDLS73f85c0b8a42: gitlab: Adapt requests retry policy to consider HTTP 50x status codes (authored by anlambert). · Explain WhyJul 23 2021, 2:06 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLS73f85c0b8a42: gitlab: Adapt requests retry policy to consider HTTP 50x status codes.