Page MenuHomeSoftware Heritage
Feed All Stories

Sep 28 2020

ardumont edited P789 vagrant up test failure.
Sep 28 2020, 8:40 PM
ardumont edited P789 vagrant up test failure.
Sep 28 2020, 8:37 PM
ardumont added a comment to P789 vagrant up test failure.
$ vagrant up prod-worker01
...
Copy iso file /usr/share/virtualbox/VBoxGuestAdditions.iso into the box /tmp/VBoxGuestAdditions.iso
Mounting Virtualbox Guest Additions ISO to: /mnt
mount: /mnt: WARNING: device write-protected, mounted read-only.
Installing Virtualbox Guest Additions 6.0.24 - guest version is 5.2.0
Verifying archive integrity... All good.
Uncompressing VirtualBox 6.0.24 Guest Additions for Linux........
VirtualBox Guest Additions installer
Copying additional installer modules ...
Installing additional modules ...
VirtualBox Guest Additions: Starting.
VirtualBox Guest Additions: Building the VirtualBox Guest Additions kernel
modules.  This may take a while.
VirtualBox Guest Additions: To build modules for other installed kernels, run
VirtualBox Guest Additions:   /sbin/rcvboxadd quicksetup <version>
VirtualBox Guest Additions: or
VirtualBox Guest Additions:   /sbin/rcvboxadd quicksetup all
VirtualBox Guest Additions: Building the modules for kernel 4.19.0-10-amd64.
update-initramfs: Generating /boot/initrd.img-4.19.0-10-amd64
VirtualBox Guest Additions: Running kernel modules will not be replaced until
the system is restarted
An error occurred during installation of VirtualBox Guest Additions 6.0.24. Some functionality may not work as intended.
In most cases it is OK that the "Window System drivers" installation failed.
Unmounting Virtualbox Guest Additions ISO from: /mnt
Got different reports about installed GuestAdditions version:
Virtualbox on your host claims:   5.2.0
VBoxService inside the vm claims: 6.0.24
Going on, assuming VBoxService is correct...
Got different reports about installed GuestAdditions version:
Virtualbox on your host claims:   5.2.0
VBoxService inside the vm claims: 6.0.24
Going on, assuming VBoxService is correct...
==> prod-worker01: Setting hostname...
==> prod-worker01: Configuring and enabling network interfaces...
==> prod-worker01: Installing NFS client...
==> prod-worker01: Exporting NFS shared folders...
==> prod-worker01: Preparing to edit /etc/exports. Administrator privileges will be required...
==> prod-worker01: Mounting NFS shared folders...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!
Sep 28 2020, 8:33 PM
ardumont created P789 vagrant up test failure.
Sep 28 2020, 8:29 PM
rdicosmo committed rMSLDe9f73d27a38d: Revert "Update sponsor image": incorrect form factor (authored by rdicosmo).
Revert "Update sponsor image": incorrect form factor
Sep 28 2020, 7:44 PM
rdicosmo added a reverting change for rMSLD2340e2e126cd: Update sponsor image: rMSLDe9f73d27a38d: Revert "Update sponsor image": incorrect form factor.
Sep 28 2020, 7:44 PM
ardumont added a comment to P788 ram redistribution.

Related to D4071

Sep 28 2020, 7:44 PM
ardumont created D4071: terraform/staging: Align proxmox and staging declaration.
Sep 28 2020, 7:41 PM
ardumont created P788 ram redistribution.
Sep 28 2020, 7:33 PM
rdicosmo committed rMSLD2340e2e126cd: Update sponsor image (authored by rdicosmo).
Update sponsor image
Sep 28 2020, 7:31 PM
ardumont accepted D4070: tox/black: Pin version to pre-commit one and exclude test resources.
Sep 28 2020, 7:18 PM
ardumont committed rDDEPa2830a9b0bc2: deposit.api.checks: Add docstring to module (authored by ardumont).
deposit.api.checks: Add docstring to module
Sep 28 2020, 7:16 PM
ardumont closed D4063: deposit.api.checks: Add docstring to module.
Sep 28 2020, 7:16 PM
ardumont committed rDDEP8d4f19a3f3cf: tests: Explicit the bad request scenario error messages (authored by ardumont).
tests: Explicit the bad request scenario error messages
Sep 28 2020, 7:16 PM
ardumont closed D4069: tests: Explicit the bad request scenario error message.
Sep 28 2020, 7:16 PM
ardumont committed rDDEPb15033d6ce7c: tests: Ensure all empty body test cases are covered (authored by ardumont).
tests: Ensure all empty body test cases are covered
Sep 28 2020, 7:15 PM
ardumont closed D4067: tests: Ensure all empty body test cases are covered.
Sep 28 2020, 7:15 PM
ardumont committed rDDEPf05480888a31: deposit.parsers: Process namespace when using xmltodict.parse (authored by ardumont).
deposit.parsers: Process namespace when using xmltodict.parse
Sep 28 2020, 7:14 PM
ardumont closed D4065: deposit.parsers: Process namespace when using xmltodict.parse.
Sep 28 2020, 7:14 PM
olasd closed T1872: staging infra: New vlan, a subtask of T1785: Setup staging infrastructure, as Resolved.
Sep 28 2020, 6:57 PM · Staging environment, System administration
olasd closed T1872: staging infra: New vlan, a subtask of T2628: Recycle ceph-osd2 as objstorage/storage backend for staging, as Resolved.
Sep 28 2020, 6:57 PM · Staging environment, System administration
olasd closed T1872: staging infra: New vlan, a subtask of T2627: Recycle ceph-osd1 as staging database host, as Resolved.
Sep 28 2020, 6:57 PM · Staging environment, System administration
olasd closed T1872: staging infra: New vlan, a subtask of T2501: Proxmox reliability improvements (Summer 2020), as Resolved.
Sep 28 2020, 6:57 PM · System administration
olasd closed T1872: staging infra: New vlan as Resolved.

This was now just a matter of doing the clickity click on all hosts. They're now using the dedicated vlan.

Sep 28 2020, 6:57 PM · Staging environment, Staff, System administration
swh-public-ci added a comment to D4070: tox/black: Pin version to pre-commit one and exclude test resources.

Build is green

Sep 28 2020, 6:49 PM
anlambert created D4070: tox/black: Pin version to pre-commit one and exclude test resources.
Sep 28 2020, 6:42 PM
olasd added a comment to T1872: staging infra: New vlan.

I've added a bridge vmbr443 to all hypervisors.

Sep 28 2020, 6:11 PM · Staging environment, Staff, System administration
swh-public-ci added a comment to D4063: deposit.api.checks: Add docstring to module.

Build is green

Sep 28 2020, 6:10 PM
vlorentz accepted D4069: tests: Explicit the bad request scenario error message.
Sep 28 2020, 6:09 PM
vlorentz accepted D4063: deposit.api.checks: Add docstring to module.
Sep 28 2020, 6:09 PM
swh-public-ci added a comment to D4069: tests: Explicit the bad request scenario error message.

Build is green

Sep 28 2020, 6:07 PM
ardumont updated the diff for D4063: deposit.api.checks: Add docstring to module.

Explicit a bit the checks

Sep 28 2020, 6:05 PM
ardumont updated the diff for D4069: tests: Explicit the bad request scenario error message.

rework commit message

Sep 28 2020, 6:04 PM
swh-public-ci added a comment to D4069: tests: Explicit the bad request scenario error message.

Build is green

Sep 28 2020, 6:04 PM
swh-public-ci added a comment to D4067: tests: Ensure all empty body test cases are covered.

Build is green

Sep 28 2020, 6:02 PM
swh-public-ci added a comment to D4065: deposit.parsers: Process namespace when using xmltodict.parse.

Build is green

Sep 28 2020, 5:59 PM
ardumont updated the diff for D4069: tests: Explicit the bad request scenario error message.

Rebase

Sep 28 2020, 5:57 PM
ardumont updated the diff for D4067: tests: Ensure all empty body test cases are covered.

Rebase

Sep 28 2020, 5:57 PM
ardumont updated the diff for D4065: deposit.parsers: Process namespace when using xmltodict.parse.

Rebase

Sep 28 2020, 5:56 PM
ardumont retitled D4069: tests: Explicit the bad request scenario error message from tests: Ensure all 400 scenarios check the correct response to tests: Explicit the bad request scenario error message.
Sep 28 2020, 5:52 PM
swh-public-ci added a comment to D4069: tests: Explicit the bad request scenario error message.

Build is green

Sep 28 2020, 5:48 PM
ardumont created D4069: tests: Explicit the bad request scenario error message.
Sep 28 2020, 5:45 PM
olasd added a comment to T1872: staging infra: New vlan.

I wanted to rename the bridges on the proxmox hosts to something clearer (like vmbr-staging) but it turns out that proxmox only supports bridges named /vmbr\d+/. Ugh.

Sep 28 2020, 5:42 PM · Staging environment, Staff, System administration
vlorentz accepted D4067: tests: Ensure all empty body test cases are covered.
Sep 28 2020, 5:35 PM
vlorentz requested changes to D4063: deposit.api.checks: Add docstring to module.

Should be a little more detailed.

Sep 28 2020, 5:35 PM
vlorentz accepted D4065: deposit.parsers: Process namespace when using xmltodict.parse.
Sep 28 2020, 5:34 PM
vlorentz added a comment to D4065: deposit.parsers: Process namespace when using xmltodict.parse.

Can you also remove the xmlns declaration in the "empty" XML data file?

Sep 28 2020, 5:34 PM
tenma added a comment to D4066: Fix buffer interface protocol and impls.

If whatever component before BPS has its flush called with no object_types, it depends on the impl of this component how it chains well. As is, it should either chain down the arg unprocessed (from *args/**kwargs for example, what I have done for all proxies before I understood the getattr hooks), call it without this arg or give it a valid value like OBJECT_TYPES (which could be shared). In short intermediate should not have an invalid default passed down verbatim.
The case of concrete storage is not clear, because they don't chain call it nor need it in the first place. So any value is OK.
We have no other component than BPS that would do something with this (buffering) interface though, and it maybe would not make sense to have another.

Sep 28 2020, 5:09 PM
ardumont updated the summary of D4065: deposit.parsers: Process namespace when using xmltodict.parse.
Sep 28 2020, 5:09 PM
anlambert updated the summary of D4068: jobs/swh-environment: Improve build script.
Sep 28 2020, 4:41 PM
anlambert created D4068: jobs/swh-environment: Improve build script.
Sep 28 2020, 4:41 PM
olasd added a comment to D4066: Fix buffer interface protocol and impls.

(I'll note that the buffer storage usually comes *before* the RPC client, so the actual concern is probably moot. But the apparent mismatch in default arguments between different implems might lead to surprising behavior in the future.)

Sep 28 2020, 4:28 PM
olasd requested changes to D4066: Fix buffer interface protocol and impls.

What happens when we have the following layering:

Sep 28 2020, 4:24 PM
swh-public-ci added a comment to D4067: tests: Ensure all empty body test cases are covered.

Build is green

Sep 28 2020, 4:21 PM
ardumont updated the summary of D4067: tests: Ensure all empty body test cases are covered.
Sep 28 2020, 4:21 PM
ardumont added inline comments to D4013: Allow deposit metadata update on deposit already complete.
Sep 28 2020, 4:20 PM
anlambert accepted D4066: Fix buffer interface protocol and impls.
Sep 28 2020, 4:19 PM
swh-public-ci added a comment to D4066: Fix buffer interface protocol and impls.

Build is green

Sep 28 2020, 4:19 PM
olasd accepted D4066: Fix buffer interface protocol and impls.
Sep 28 2020, 4:19 PM
haltode updated the summary of D4064: Early FUSE implementation, with support for blob and directory objects.
Sep 28 2020, 4:19 PM
tenma added a comment to D4066: Fix buffer interface protocol and impls.

Tested on storage and loader-core as seen with mr grep '\.flush('.

Sep 28 2020, 4:19 PM
ardumont updated the summary of D4065: deposit.parsers: Process namespace when using xmltodict.parse.
Sep 28 2020, 4:18 PM
ardumont created D4067: tests: Ensure all empty body test cases are covered.
Sep 28 2020, 4:18 PM
swh-public-ci added a comment to D4065: deposit.parsers: Process namespace when using xmltodict.parse.

Build is green

Sep 28 2020, 4:15 PM
tenma created D4066: Fix buffer interface protocol and impls.
Sep 28 2020, 4:15 PM
ardumont created D4065: deposit.parsers: Process namespace when using xmltodict.parse.
Sep 28 2020, 4:13 PM
olasd committed rDSTOe37c8f7ccc14: Pin black in tox to the same version as .pre-commit-config.yaml (authored by olasd).
Pin black in tox to the same version as .pre-commit-config.yaml
Sep 28 2020, 3:38 PM
vsellier updated the diff for D4025: Add netbox inventory tool support.
  • rebase
  • add the vagrant configuration
Sep 28 2020, 3:35 PM
zack added a comment to D4064: Early FUSE implementation, with support for blob and directory objects.

I forgot to mention: sharding archive/ and meta/ as archive/XX/ and meta/XX/ is also an important one, but probably not a blocker for an initial merge into master.
However, it might be more convenient to implement it right away rather than having to add it later. Up to you.

Sep 28 2020, 3:28 PM
vsellier committed rSPSITE0c8e46a88da2: adapt the configuration for the vagrant environment (authored by vsellier).
adapt the configuration for the vagrant environment
Sep 28 2020, 3:26 PM
zack requested changes to D4064: Early FUSE implementation, with support for blob and directory objects.

This is amazing, I didn't expect it to reach this level of functionality so quickly, kudos! :-)

Sep 28 2020, 3:26 PM
vsellier closed D3989: adapt configuration for the vagrant environment.
Sep 28 2020, 3:26 PM
vsellier updated the diff for D3989: adapt configuration for the vagrant environment.

rebase

Sep 28 2020, 3:25 PM
olasd added a project to T2628: Recycle ceph-osd2 as objstorage/storage backend for staging: Staging environment.
Sep 28 2020, 3:12 PM · Staging environment, System administration
olasd added a project to T2627: Recycle ceph-osd1 as staging database host: Staging environment.
Sep 28 2020, 3:12 PM · Staging environment, System administration
vsellier committed rSENVc6ff01ebc08b: add vagrant configuration and documentation (authored by vsellier).
add vagrant configuration and documentation
Sep 28 2020, 2:55 PM
vsellier committed rSENV7585ad03eb24: Create the virtualbox image used to instantiate the vagrant environment (authored by vsellier).
Create the virtualbox image used to instantiate the vagrant environment
Sep 28 2020, 2:55 PM
vsellier closed D3967: Vagrant environment to test puppet locally.
Sep 28 2020, 2:55 PM
vsellier updated the diff for D3967: Vagrant environment to test puppet locally.

Switch the default test branch to staging

Sep 28 2020, 2:54 PM
vsellier updated the diff for D3967: Vagrant environment to test puppet locally.
  • Add a script to avoid to commit each change before being able to test it (watch-vagrant-conf)
  • Update the documentation accordingly
  • Declare the admin-inventory server
Sep 28 2020, 2:52 PM
haltode updated the summary of D4064: Early FUSE implementation, with support for blob and directory objects.
Sep 28 2020, 2:41 PM
anlambert created P787 storage flush - no more default value for object_types argument.
Sep 28 2020, 2:39 PM
haltode added inline comments to D4064: Early FUSE implementation, with support for blob and directory objects.
Sep 28 2020, 2:31 PM
swh-public-ci added a comment to D4064: Early FUSE implementation, with support for blob and directory objects.

Build is green

Sep 28 2020, 2:28 PM
haltode created D4064: Early FUSE implementation, with support for blob and directory objects.
Sep 28 2020, 2:27 PM
vsellier added inline comments to D4062: declare the swh-docker-dev job.
Sep 28 2020, 2:20 PM
vsellier updated the diff for D4062: declare the swh-docker-dev job.

rebase

Sep 28 2020, 2:19 PM
vsellier updated the diff for D4061: Add documentation to test locally.

Change the commit message according to the diff's feedback

Sep 28 2020, 2:19 PM
swh-public-ci added a comment to D4063: deposit.api.checks: Add docstring to module.

Build is green

Sep 28 2020, 2:19 PM
ardumont committed rDDEP87b39c10eea2: test_deposit_atom: Fix incomplete tests (authored by ardumont).
test_deposit_atom: Fix incomplete tests
Sep 28 2020, 2:17 PM
ardumont closed D4060: test_deposit_atom: Fix incomplete tests.
Sep 28 2020, 2:17 PM
ardumont committed rDDEP7560021ad09a: deposit_update: Drop the unneeded check on the directory_missing call (authored by ardumont).
deposit_update: Drop the unneeded check on the directory_missing call
Sep 28 2020, 2:17 PM
ardumont closed D4059: deposit_update: Drop the unneeded check on the directory_missing call.
Sep 28 2020, 2:17 PM
swh-public-ci added a comment to D4059: deposit_update: Drop the unneeded check on the directory_missing call.

Build is green

Sep 28 2020, 2:16 PM
vsellier updated the diff for D4062: declare the swh-docker-dev job.
  • rebase
  • Remove the now useless CASS_DRIVER_NO_CYTHON option
Sep 28 2020, 2:15 PM
ardumont added inline comments to D4062: declare the swh-docker-dev job.
Sep 28 2020, 2:15 PM
ardumont created D4063: deposit.api.checks: Add docstring to module.
Sep 28 2020, 2:14 PM
vsellier updated the diff for D4061: Add documentation to test locally.

fix typo on the commit message

Sep 28 2020, 2:13 PM
ardumont updated the diff for D4059: deposit_update: Drop the unneeded check on the directory_missing call.

Rebase

Sep 28 2020, 2:13 PM
olasd accepted D4061: Add documentation to test locally.

Please improve the wording on the README commit message:

Sep 28 2020, 2:13 PM