Updating 87b39c10..73120b72
Fast-forward
 swh/deposit/api/checks.py                            |  2 ++
 swh/deposit/parsers.py                               | 11 ++++++++++-
 swh/deposit/tests/api/test_deposit_atom.py           | 18 ++++++++++--------
 .../tests/api/test_deposit_private_read_metadata.py  |  8 --------
 swh/deposit/tests/api/test_deposit_update.py         | 20 +++++++++++---------
 swh/deposit/tests/api/test_parser.py                 |  4 ----
 .../data/atom/entry-data-empty-body-no-namespace.xml |  2 ++
 .../tests/data/atom/entry-data-empty-body.xml        |  2 +-
 swh/deposit/tests/data/atom/entry-data3.xml          |  2 +-
 9 files changed, 37 insertions(+), 32 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/entry-data-empty-body-no-namespace.xml

Changes applied before test

commit 73120b72171c1f8884ab5d63da8fe0a7e25ea391
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 28 16:18:37 2020 +0200

    tests: Ensure all empty body test cases are covered

commit d86c192234a025a027202379789e074441dadbc3
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 28 16:09:59 2020 +0200

    deposit.parsers: Process namespace when using xmltodict.parse
    
    This keeps the existing behavior though by mapping the expanded name to simpler
    namespaces.
    
    This also fixes some test data sample which were not properly defining their
    namespace.
    
    This will allow to deal more properly the empty body case which is incomplete
    right now.

commit cc8d12524845811345735a00e836f29dea8fac8c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 28 14:15:48 2020 +0200

    deposit.api.checks: Add docstring to module

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/155/ for more details.

Harbormaster completed remote builds in B15655: Diff 14359.Sep 28 2020, 4:21 PM

vlorentz accepted this revision.Sep 28 2020, 5:35 PM

This revision is now accepted and ready to land.Sep 28 2020, 5:35 PM

Rebase

Build is green

Patch application report for D4067 (id=14363)

Could not rebase; Attempt merge onto 87b39c10ee...

Updating 87b39c10..b15033d6
Fast-forward
 swh/deposit/parsers.py                               | 11 ++++++++++-
 swh/deposit/tests/api/test_deposit_atom.py           | 18 ++++++++++--------
 .../tests/api/test_deposit_private_read_metadata.py  |  8 --------
 swh/deposit/tests/api/test_deposit_update.py         | 20 +++++++++++---------
 swh/deposit/tests/api/test_parser.py                 |  4 ----
 .../data/atom/entry-data-empty-body-no-namespace.xml |  2 ++
 .../tests/data/atom/entry-data-empty-body.xml        |  2 +-
 swh/deposit/tests/data/atom/entry-data3.xml          |  2 +-
 8 files changed, 35 insertions(+), 32 deletions(-)
 create mode 100644 swh/deposit/tests/data/atom/entry-data-empty-body-no-namespace.xml

Changes applied before test

commit b15033d6ce7c4b60cbf0c82c299a0ed322e7e2e7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 28 16:18:37 2020 +0200

    tests: Ensure all empty body test cases are covered

commit f05480888a317c5cbc181ebdaa8d98e58914cc06
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 28 16:09:59 2020 +0200

    deposit.parsers: Process namespace when using xmltodict.parse
    
    This keeps the existing behavior though by mapping the expanded name to simpler
    namespaces.
    
    This also fixes some test data sample which were not properly defining their
    namespace.
    
    This will allow to deal more properly the empty body case which is incomplete
    right now.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/158/ for more details.

Harbormaster completed remote builds in B15659: Diff 14363.Sep 28 2020, 6:02 PM

Closed by commit rDDEPb15033d6ce7c: tests: Ensure all empty body test cases are covered (authored by ardumont). · Explain WhySep 28 2020, 7:15 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEPb15033d6ce7c: tests: Ensure all empty body test cases are covered.