Differential D4060

test_deposit_atom: Fix incomplete tests
ClosedPublic
Actions

Authored by ardumont on Sep 28 2020, 1:58 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDDEP87b39c10eea2: test_deposit_atom: Fix incomplete tests

Summary

They were all an instance of the same missing SLUG header instead of their
dedicated perimeters...

Test Plan

tox

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 28 2020, 1:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 28 2020, 1:58 PM

vlorentz accepted this revision.Sep 28 2020, 1:59 PM

This revision is now accepted and ready to land.Sep 28 2020, 1:59 PM

Build is green

Patch application report for D4060 (id=14335)

Could not rebase; Attempt merge onto d1f3f69c90...

Updating d1f3f69c..87b39c10
Fast-forward
 MANIFEST.in                                        |   1 +
 swh/deposit/api/checks.py                          |  54 ++++++++++
 swh/deposit/api/deposit_update.py                  |  27 +++--
 swh/deposit/api/private/deposit_check.py           |  51 +---------
 swh/deposit/tests/api/test_checks.py               |  78 +++++++++++++++
 swh/deposit/tests/api/test_deposit_atom.py         |   7 ++
 .../tests/api/test_deposit_private_check.py        |  77 +-------------
 swh/deposit/tests/api/test_deposit_update.py       | 111 +++++++++++++++------
 .../entry-data-fail-metadata-functional-checks.xml |   7 ++
 9 files changed, 242 insertions(+), 171 deletions(-)
 create mode 100644 swh/deposit/api/checks.py
 create mode 100644 swh/deposit/tests/api/test_checks.py
 create mode 100644 swh/deposit/tests/data/atom/entry-data-fail-metadata-functional-checks.xml

Changes applied before test

commit 87b39c10eea2ae2b4714e330a1b6ca104a3fcf81
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 28 13:57:05 2020 +0200

    test_deposit_atom: Fix incomplete tests
    
    They were all an instance of the same missing SLUG header instead of their
    dedicated perimeters...

commit 7560021ad09a1187c9393ef4b3ffeffb1f0e13cf
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Sep 28 13:18:58 2020 +0200

    deposit_update: Drop the unneeded check on the directory_missing call
    
    We are working with a SWHID generated by the deposit which is already tested in
    another way. This checks is thus redundant.

commit 36d6b760f4a2746b01dddf788bffc81bd7b36742
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Sun Sep 27 15:36:32 2020 +0200

    Check updated metadata are correctly stored in the metadata storage

commit 92f99745f35b95b1717d9344bd9b4e3f74b0cc20
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Sep 25 13:31:29 2020 +0200

    Add functional metadata checks prior to updating them
    
    This refactor the common code executed by the checker so we functionally check
    everything the same way.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/151/ for more details.

Harbormaster completed remote builds in B15633: Diff 14335.Sep 28 2020, 2:00 PM

Closed by commit rDDEP87b39c10eea2: test_deposit_atom: Fix incomplete tests (authored by ardumont). · Explain WhySep 28 2020, 2:17 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDDEP87b39c10eea2: test_deposit_atom: Fix incomplete tests.

ardumont mentioned this in D4069: tests: Explicit the bad request scenario error message.Sep 28 2020, 5:45 PM

ardumont mentioned this in rDDEP8d4f19a3f3cf: tests: Explicit the bad request scenario error messages.Sep 28 2020, 7:16 PM