- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Sep 28 2020
Use only one commit per diff
Split this into 2 diffs, one for the doc, the other one to actually add the job and we are good ;)
Build is green
please add a module docstring to checks.py
Build is green
Add origin to the raw extrinsic metadata stored in the metadata storage
Build is green
Build is green
You should add an origin context to the RawExtrinsicMetadata object, to be consistent with the deposit loader.
Let's not forget to remove the directory_missing check later
Build is green
Build is green
Rebase
Rebase
Use the PUT endpoint
Note that some checks are commented because they currently fail. Those are
storage issues. The fetcher and authority metadata fields are not properly set
when read from the raw_extrinsic_metadata_get endpoint somehow ¯\_(ツ)_/¯.
That should most probably be the subject for another storage diff.
as discussed on side-channels, it should be a PUT
I have added the `--pull` option in the job configuration so the python image will always be pulled (if needed) during the build :
The lister is deployed, this forge is not listed though (codeberg.org is).
Can this be closed now? What's missing? Adding a listing task?
Sep 27 2020
Like i said in the update diff message, there remains the check on the actual metadata stored (FIXME for now).
I'd like to dedicate to this in another iteration (diff) though.
So the eventual discussion on that can happen there.
Build is green
Build is green
Build is green
Rebase on latest D4013
Adapt according to remaining unadapted suggestions (and more):
- Actually add new metadata information during update instead of replacing those (technically also move the code from the PUT to the POST method part)
- Update docstrings accordingly
- Rename storage attribute to storage_metadata
- Drop self.provider setup to actually reference the deposit client as the provider (and adapt the other part already using it)
- Send raw metadata into the metadata storage (instead of the parsed json one)
It seems the python 3.7 images on the jenkins master is quite old :
root@thyssen:~# docker images | grep python python 3.7 a4cc999cf2aa 16 months ago 929MB
I'm guessing it's because $VERSION_CODENAME is empty here: https://forge.softwareheritage.org/source/swh-environment/browse/master/docker/Dockerfile$3
Sep 26 2020
Build is green
Build is green
Build is green
Build is green
Build is green
Build is green
Build is green
Rebase
Rebase
Rebase
Rebase
Rebase
/me *sighs* second round rebase, i forgot to pull --rebase first
Build is green
Rebase on latest D4013
Fix test
There should be another diff in regards to that test.
At least to add a file similar to the original one (with the xmlns namespace...) which should pass the same way... (heads up, it does not...)
Currently, the check on emptiness fails with that xmlns, why i removed it here (as i'm being lazy right now).
Like i said, I'll adapt in another diff. I don't want to be sidetracked too much right now.
Build has FAILED
Build is green