Page MenuHomeSoftware Heritage
Differential D4062

declare the swh-docker-dev job
ClosedPublic
Actions

Authored by vsellier on Sep 28 2020, 2:08 PM.

Details

Reviewers
ardumont
anlambert
Group Reviewers
Reviewers
Commits
rCJSWH61acbce9e440: declare the swh-docker-dev job

Diff Detail

Repository
rCJSWH Jenkins jobs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vsellier created this revision.Sep 28 2020, 2:08 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 28 2020, 2:08 PM
Harbormaster completed remote builds in B15636: Diff 14338.Sep 28 2020, 2:08 PM
ardumont accepted this revision.Sep 28 2020, 2:09 PM
ardumont added a subscriber: ardumont.

\m/

thanks

This revision is now accepted and ready to land.Sep 28 2020, 2:09 PM
anlambert accepted this revision.Sep 28 2020, 2:11 PM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
jobs/swh-docker-dev.yaml
25

You can remove the --build-arg=CASS_DRIVER_NO_CYTHON=1 option here.

This was needed at the time to speedup the build of the cassandra-driver Python module but binary wheels are now provided on PyPI (no more compilation needed).

ardumont added inline comments.Sep 28 2020, 2:15 PM
jobs/swh-docker-dev.yaml
25

nice catch ;)

vsellier updated this revision to Diff 14344.Sep 28 2020, 2:15 PM
  • rebase
  • Remove the now useless CASS_DRIVER_NO_CYTHON option
Harbormaster completed remote builds in B15642: Diff 14344.Sep 28 2020, 2:16 PM
vsellier updated this revision to Diff 14348.Sep 28 2020, 2:19 PM

rebase

Harbormaster completed remote builds in B15646: Diff 14348.Sep 28 2020, 2:19 PM
vsellier marked 2 inline comments as done.Sep 28 2020, 2:20 PM
vsellier added inline comments.
jobs/swh-docker-dev.yaml
25

the diff was updated to remove the option

vsellier updated this revision to Diff 14418.Sep 29 2020, 6:40 PM
vsellier marked an inline comment as done.

rebase

Harbormaster completed remote builds in B15707: Diff 14418.Sep 29 2020, 6:40 PM
Closed by commit rCJSWH61acbce9e440: declare the swh-docker-dev job (authored by vsellier). · Explain WhySep 29 2020, 6:40 PM
This revision was automatically updated to reflect the committed changes.
vsellier added a commit: rCJSWH61acbce9e440: declare the swh-docker-dev job.

Revision Contents
Changeset List

PathSize
jobs/
30 lines

Diff 14419

View Options

jobs/swh-docker-dev.yaml

Loading...
About · Developer information · Legal