Page MenuHomeSoftware Heritage
Feed Advanced Search

Sep 4 2020

douardda updated the diff for D3871: Add a short `quickstart` guide.

rebase

Sep 4 2020, 4:57 PM
douardda committed rDDOC4d8395a926ff: Add a RPC vault worker->objstorage link in the arch diagram (authored by douardda).
Add a RPC vault worker->objstorage link in the arch diagram
Sep 4 2020, 1:54 PM
douardda closed D3866: Add a RCP a vault worker->objstorage link in the arch diagram.
Sep 4 2020, 1:54 PM
douardda updated the diff for D3866: Add a RCP a vault worker->objstorage link in the arch diagram.

rebase + typos in ci msg

Sep 4 2020, 1:54 PM
douardda added a comment to D3866: Add a RCP a vault worker->objstorage link in the arch diagram.

Sep 4 2020, 11:06 AM

Sep 3 2020

douardda updated the diff for D3871: Add a short `quickstart` guide.

Add the magic touch

Sep 3 2020, 4:10 PM
douardda updated the diff for D3871: Add a short `quickstart` guide.

includes seirl's remarks (well the easy part of them)

Sep 3 2020, 3:44 PM
douardda added a comment to D3871: Add a short `quickstart` guide.
In D3871#95682, @seirl wrote:

Thanks, this looks good!

Apart from minor nitpicks, my only concern here is that it might not be 100% clear who this doc is addressing. I reckon that people clicking on the "quickstart" page of swh.graph can come from different situations:

  • people who want to use swh-graph without any consideration for the rest of the SWH infrastructure on an arbitrary graph (what you seem to have written here)
  • people who want to install swh-graph as part of their SWH development environment
  • people who would like to run topology experiments on our graph but have no idea where to start
  • ...

In that regard, I am not sure "quickstart" is appropriate here -- but I really don't have a better idea of how this doc should be written. I am okay for merging that as-is until we figure out what we want to show potential users. Maybe @zack would like to chime in here?

I guess it would probably be a good idea to at least start with an intro paragraph about what we're trying to achieve in this tutorial?

Sep 3 2020, 3:36 PM
douardda created D3871: Add a short `quickstart` guide.
Sep 3 2020, 2:32 PM
douardda resigned from D3861: tests: Unify lister initialization under the `initialized_lister` fixture.

okay-ish. I still don't really get the point of this diff. You still have as many fixtures as before, it's just that they all have the same same. For me it defies the simplification/clarification this diff claims it aims at. I won't reject but I'm not convinced neither (sorry).

Sep 3 2020, 9:21 AM

Sep 2 2020

douardda added a comment to D3863: Refactor revision_get storage API to return Revision objects.

looks ok but I find the commit message too cryptic.

Sep 2 2020, 5:09 PM
douardda requested changes to D3861: tests: Unify lister initialization under the `initialized_lister` fixture.

I'm not sure I get what problem this diff is solving (and the commit message gives no clue about it).
The "why", focus on the "why" (and "how", if needed) :-)

Sep 2 2020, 5:02 PM
douardda created D3866: Add a RCP a vault worker->objstorage link in the arch diagram.
Sep 2 2020, 4:37 PM
douardda committed rDENV71846b8131a1: Small fix in test_git_loader.py to make flake8 happy (authored by douardda).
Small fix in test_git_loader.py to make flake8 happy
Sep 2 2020, 2:47 PM

Sep 1 2020

douardda added a comment to D3857: test_cli: Exclude launchpad lister from the check.

we could argue that having the launchpad lister attempting a connection on instantiation is pretty bad, but yeah, ok

Sep 1 2020, 4:02 PM

Aug 27 2020

douardda closed D3843: Update a bit the architecture description.
Aug 27 2020, 5:05 PM
douardda closed T2478: backfill origin-visit and origin-visit-status topics, a subtask of T2310: Make origin visits immutable, as Wontfix.
Aug 27 2020, 4:43 PM · Storage manager, Data Model
douardda closed T2478: backfill origin-visit and origin-visit-status topics as Wontfix.

I guess this task can be closed, since this backfilling process will be part of the one we will run soon to fill the new kafka cluster

Aug 27 2020, 4:43 PM · Storage manager, Data Model
douardda added a comment to T995: Investigate and fix snapshots with broken links.

what's the status of this task today? is there a probe that tracks these broken links? (or a script one can run)

Aug 27 2020, 4:40 PM · Archive content
douardda added a comment to T645: Type swh-storage endpoints with swh.model objects.

what's missing for this task to be closed?

Aug 27 2020, 4:32 PM · Data Model, Storage manager
douardda raised the priority of T2313: Archive git.fsfe.org (Gitea) from Wishlist to High.
Aug 27 2020, 4:29 PM · Archive coverage, Lister
douardda committed rMSLD127b04ca0ead: 2020 onbloarding talk: add a few slides on the sw arch (authored by douardda).
2020 onbloarding talk: add a few slides on the sw arch
Aug 27 2020, 3:57 PM
douardda committed rMSLDb0680739ad08: Update general-achitecture and swh-modules-deps graphs (authored by douardda).
Update general-achitecture and swh-modules-deps graphs
Aug 27 2020, 3:57 PM
douardda added a comment to T1924: Deploy packagist Lister.

I guess this also depends on a packagist loader, which we do not have at all for now...

Aug 27 2020, 11:16 AM · Lister, Archive coverage

Aug 26 2020

douardda committed rDDOCaa1840cffc6f: Update a bit the architecture description (authored by douardda).
Update a bit the architecture description
Aug 26 2020, 5:24 PM
douardda committed rDENVeaafd57741b7: docker: add gitea and launchpad listers in the lister's conf (authored by douardda).
docker: add gitea and launchpad listers in the lister's conf
Aug 26 2020, 5:14 PM
douardda committed rDENVc183376eab6e: Remove useless objstorage config entry from conf/web.yml (authored by douardda).
Remove useless objstorage config entry from conf/web.yml
Aug 26 2020, 5:14 PM
douardda closed D3841: Remove useless objstorage config entry from conf/web.yml.
Aug 26 2020, 5:14 PM
douardda updated the diff for D3841: Remove useless objstorage config entry from conf/web.yml.

rebase + anlambert's comment

Aug 26 2020, 5:13 PM
douardda added a comment to D3841: Remove useless objstorage config entry from conf/web.yml.

While you are are on it, can you also remove the objstorage dependency in swh-web service definition inside docker-compose.yml ?

Aug 26 2020, 4:53 PM
douardda added a comment to D3844: Add a validating storage proxy, to check ids before insertion..

On the other hand, it will be computationally expensive, especially for contents.
What do you think?

Aug 26 2020, 11:53 AM
douardda added a comment to T2313: Archive git.fsfe.org (Gitea).

Also beware that the default pagination value in the gitea lister is 3 (https://forge.softwareheritage.org/source/swh-lister/browse/master/swh/lister/gitea/lister.py$23) so it is very slow.

Aug 26 2020, 11:08 AM · Archive coverage, Lister
douardda closed T1734: Create a Lister for launchpad.net as Resolved.
Aug 26 2020, 11:01 AM · Lister, Archive coverage
douardda added a comment to T2313: Archive git.fsfe.org (Gitea).

Ok I was expecting something a bit smart in explore.sapk.fr, but not really:

Aug 26 2020, 10:48 AM · Archive coverage, Lister
douardda raised the priority of T2358: Deploy launchpad lister on staging from Normal to High.
Aug 26 2020, 10:29 AM · System administration, Lister, Archive coverage
douardda added a comment to T2313: Archive git.fsfe.org (Gitea).

now we have the gitea lister, we should (upgrade swh.lister on prod and) add a few listing tasks, like this fsfe instance, as well as other instances like https://codeberg.org.

Aug 26 2020, 10:23 AM · Archive coverage, Lister

Aug 25 2020

douardda committed rDLSa97613a05635: Update the list of provided listers in the README file (authored by douardda).
Update the list of provided listers in the README file
Aug 25 2020, 6:33 PM
douardda committed rDLS7ef7425d5528: Keep plugins sorted in setup.py (authored by douardda).
Keep plugins sorted in setup.py
Aug 25 2020, 6:30 PM
douardda created D3843: Update a bit the architecture description.
Aug 25 2020, 5:09 PM
douardda committed rDDOC8fc016537fd2: Update the task-lister diagram (authored by douardda).
Update the task-lister diagram
Aug 25 2020, 5:09 PM
douardda closed D3842: Update the task-lister diagram.
Aug 25 2020, 5:09 PM
douardda committed rDDOC315ca7d02fb3: Update a bit the general archtecture diagram (authored by douardda).
Update a bit the general archtecture diagram
Aug 25 2020, 5:09 PM
douardda closed D3838: Update a bit the general archtecture diagram.
Aug 25 2020, 5:09 PM
douardda created D3842: Update the task-lister diagram.
Aug 25 2020, 4:38 PM
douardda updated the diff for D3838: Update a bit the general archtecture diagram.

small improvements

Aug 25 2020, 4:37 PM
douardda created D3841: Remove useless objstorage config entry from conf/web.yml.
Aug 25 2020, 4:13 PM
douardda updated the diff for D3838: Update a bit the general archtecture diagram.

remove the webapp->objstorage RPC link

Aug 25 2020, 4:10 PM
douardda added a comment to D3838: Update a bit the general archtecture diagram.

Aug 25 2020, 4:04 PM
douardda added a comment to D3838: Update a bit the general archtecture diagram.

Aug 25 2020, 4:02 PM
douardda added a comment to D3838: Update a bit the general archtecture diagram.

Aug 25 2020, 4:01 PM
douardda added a comment to D3838: Update a bit the general archtecture diagram.

For the record, there is not really a RPC link between the webapp and the objstorage as its use is wrapped by the content_* methods of the storage interface.
So I think you should remove that new link.

Aug 25 2020, 4:00 PM
douardda updated the diff for D3838: Update a bit the general archtecture diagram.

improve the diagram

Aug 25 2020, 3:59 PM
douardda committed rDSTO4532a4dc64e7: Add a --check-config option for cli commands (authored by douardda).
Add a --check-config option for cli commands
Aug 25 2020, 11:52 AM
douardda closed T2525: Prevent the storage server from starting in case of db version mismatch , a subtask of T2524: Storage database migration tooling, as Resolved.
Aug 25 2020, 11:52 AM · Storage manager
douardda closed T2525: Prevent the storage server from starting in case of db version mismatch as Resolved by committing rDSTO4532a4dc64e7: Add a --check-config option for cli commands.
Aug 25 2020, 11:52 AM · Storage manager
douardda committed rDSTO2a35c0bb231c: Remove the deprecated config-path option from `swh storage rpc-serve` command (authored by douardda).
Remove the deprecated config-path option from `swh storage rpc-serve` command
Aug 25 2020, 11:52 AM
douardda closed D3834: Add a --check-config option for cli commands.
Aug 25 2020, 11:52 AM
douardda created D3838: Update a bit the general archtecture diagram.
Aug 25 2020, 11:28 AM
douardda updated the diff for D3834: Add a --check-config option for cli commands.

rebase

Aug 25 2020, 10:51 AM
douardda updated the diff for D3834: Add a --check-config option for cli commands.

type annotate the new ensure_check_config helper function

Aug 25 2020, 9:52 AM

Aug 24 2020

douardda committed rDSTOcc33dd359692: Add support for a new "check_config" config option in get_storage() (authored by douardda).
Add support for a new "check_config" config option in get_storage()
Aug 24 2020, 5:24 PM
douardda closed D3832: Add support for a new "check_config" config option in get_storage().
Aug 24 2020, 5:24 PM
douardda committed rDSTO4dd9597723f0: Check for db version mismatch in PgStorage.check_config() (authored by douardda).
Check for db version mismatch in PgStorage.check_config()
Aug 24 2020, 5:24 PM
douardda closed D3831: Check for db version mismatch in PgStorage.check_config().
Aug 24 2020, 5:24 PM
douardda committed rDSTOc16ff506ad52: Add a check_dbversion() method to the Db class (authored by douardda).
Add a check_dbversion() method to the Db class
Aug 24 2020, 5:24 PM
douardda committed rDSTO629d2d10ee97: Fix pytest_plugin's database janitor: do not truncate the dbversion table (authored by douardda).
Fix pytest_plugin's database janitor: do not truncate the dbversion table
Aug 24 2020, 5:24 PM
douardda closed D3814: Add a check_dbversion() method to the Db class.
Aug 24 2020, 5:24 PM
douardda updated the diff for D3834: Add a --check-config option for cli commands.

rebase + add closes T2525 in the ci msg

Aug 24 2020, 5:01 PM
douardda updated the diff for D3832: Add support for a new "check_config" config option in get_storage().

rebase

Aug 24 2020, 5:00 PM
douardda updated the diff for D3831: Check for db version mismatch in PgStorage.check_config().

rebase

Aug 24 2020, 5:00 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

rebase

Aug 24 2020, 4:59 PM
douardda created D3834: Add a --check-config option for cli commands.
Aug 24 2020, 4:51 PM
douardda updated the diff for D3832: Add support for a new "check_config" config option in get_storage().

rebase

Aug 24 2020, 4:49 PM
douardda updated the diff for D3831: Check for db version mismatch in PgStorage.check_config().

rebase

Aug 24 2020, 4:49 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

pick the correct commit to be stashed...

Aug 24 2020, 4:48 PM
douardda updated the diff for D3832: Add support for a new "check_config" config option in get_storage().

rebase

Aug 24 2020, 4:41 PM
douardda updated the diff for D3831: Check for db version mismatch in PgStorage.check_config().

rebase

Aug 24 2020, 4:41 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

fix failed black magic as ween by ardumont

Aug 24 2020, 4:40 PM
douardda added inline comments to D3814: Add a check_dbversion() method to the Db class.
Aug 24 2020, 4:36 PM
douardda added a revision to T2525: Prevent the storage server from starting in case of db version mismatch : D3832: Add support for a new "check_config" config option in get_storage().
Aug 24 2020, 2:51 PM · Storage manager
douardda created D3832: Add support for a new "check_config" config option in get_storage().
Aug 24 2020, 2:51 PM
douardda created D3831: Check for db version mismatch in PgStorage.check_config().
Aug 24 2020, 2:50 PM
douardda triaged T2530: Write a simple "quick start" for swh-graph as High priority.
Aug 24 2020, 10:59 AM · Documentation, Compressed graph service

Aug 21 2020

douardda accepted D3824: api/identifiers: Fix endpoints documentation rendering issue.
Aug 21 2020, 11:13 AM

Aug 20 2020

douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

rebase

Aug 20 2020, 5:43 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

rebase

Aug 20 2020, 4:33 PM
douardda accepted D3812: package loader: Add the 'url' to the original_artifact extrinsic metadata..

ok but please explain why in your commit message...

Aug 20 2020, 12:57 PM
douardda accepted D3816: tests: remove invalid assertion.
Aug 20 2020, 12:55 PM
douardda accepted D3811: Import db_transaction_generator and db_transaction directly from swh-core..
Aug 20 2020, 12:53 PM
douardda abandoned D3815: Import db_transaction* from swh-core instead of swh-storage.

as reported by vlorentz, duplicate of D3811

Aug 20 2020, 12:41 PM
douardda updated the diff for D3814: Add a check_dbversion() method to the Db class.

as said in the commit message, It must be updated jointly in 30-swh-schema.sql
(including after a rebase...)

Aug 20 2020, 12:21 PM
douardda created D3815: Import db_transaction* from swh-core instead of swh-storage.
Aug 20 2020, 12:16 PM
douardda added a revision to T2525: Prevent the storage server from starting in case of db version mismatch : D3814: Add a check_dbversion() method to the Db class.
Aug 20 2020, 12:10 PM · Storage manager
douardda created D3814: Add a check_dbversion() method to the Db class.
Aug 20 2020, 12:10 PM
douardda added a comment to T2525: Prevent the storage server from starting in case of db version mismatch .

Just to make is clear, my main objective here is to have a seatbelt for the mirror scenario: prevent a mirror with updated code but not-yet-updated database from even running until the DB migration script has been executed.

Aug 20 2020, 11:16 AM · Storage manager
douardda updated the task description for T2525: Prevent the storage server from starting in case of db version mismatch .
Aug 20 2020, 11:04 AM · Storage manager
douardda updated the task description for T2525: Prevent the storage server from starting in case of db version mismatch .
Aug 20 2020, 11:02 AM · Storage manager
douardda triaged T2525: Prevent the storage server from starting in case of db version mismatch as Normal priority.
Aug 20 2020, 10:57 AM · Storage manager
douardda triaged T2524: Storage database migration tooling as Normal priority.
Aug 20 2020, 10:55 AM · Storage manager
douardda created T2524: Storage database migration tooling.
Aug 20 2020, 10:55 AM · Storage manager