Differential D3811

Import db_transaction_generator and db_transaction directly from swh-core.
ClosedPublic
Actions

Authored by vlorentz on Aug 20 2020, 9:00 AM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Commits

rDCIDXd9e931cc8970: Import db_transaction_generator and db_transaction directly from swh-core.

Summary

swh-storage v0.13.3 will stop reexporting it.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 20 2020, 9:00 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 20 2020, 9:00 AM

Build is green

Patch application report for D3811 (id=13424)

Rebasing onto b717a504a8...

Current branch diff-target is up to date.

Changes applied before test

commit 1e6d4b8d1f535dda43e9476902d1771d13755522
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 09:00:15 2020 +0200

    Import db_transaction_generator and db_transaction directly from swh-core.
    
    swh-storage v0.13.3 will stop reexporting it.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/43/ for more details.

Harbormaster completed remote builds in B14688: Diff 13424.Aug 20 2020, 9:02 AM

vlorentz mentioned this in D3815: Import db_transaction* from swh-core instead of swh-storage.Aug 20 2020, 12:31 PM

rebase

Build is green

Patch application report for D3811 (id=13432)

Could not rebase; Attempt merge onto b717a504a8...

Updating b717a50..d9e931c
Fast-forward
 swh/indexer/storage/__init__.py | 2 +-
 swh/indexer/tests/utils.py      | 9 +--------
 2 files changed, 2 insertions(+), 9 deletions(-)

Changes applied before test

commit d9e931cc8970643cc94177c1f97df83fd4fbdb60
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 09:00:15 2020 +0200

    Import db_transaction_generator and db_transaction directly from swh-core.
    
    swh-storage v0.13.3 will stop reexporting it.

commit 66bbfdf29664e7c5b5afcff16e007302286f0dff
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 20 12:45:32 2020 +0200

    tests: remove invalid assertion
    
    It assumed contents are paginated by their sha1, which is
    an implementation detail of the storage (and isn't true for the
    cassandra storage, or for the new in-mem).
    
    And it's irrelevant anyway, as it only serves to test the consistency
    of swh-storage, not swh-indexer.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/46/ for more details.

Harbormaster completed remote builds in B14696: Diff 13432.Aug 20 2020, 12:48 PM

douardda accepted this revision.Aug 20 2020, 12:53 PM

This revision is now accepted and ready to land.Aug 20 2020, 12:53 PM

Closed by commit rDCIDXd9e931cc8970: Import db_transaction_generator and db_transaction directly from swh-core. (authored by vlorentz). · Explain WhyAug 20 2020, 12:59 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDXd9e931cc8970: Import db_transaction_generator and db_transaction directly from swh-core..