Differential D3861

tests: Unify lister initialization under the `initialized_lister` fixture
AbandonedPublic
Actions

Authored by ardumont on Sep 2 2020, 1:30 PM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Summary

This avoids too many different lister initialization fixtures (lister_cran, lister_bitbucket, etc...).

Related to D3860#95396 (initial suggestion)

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14891
Build 22945: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 22944: arc lint + arc unit

Event Timeline

ardumont created this revision.Sep 2 2020, 1:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 2 2020, 1:30 PM

ardumont mentioned this in D3860: tests: Separate lister instantiations.Sep 2 2020, 1:32 PM

Build is green

Patch application report for D3861 (id=13642)

Rebasing onto 5a5b7ef70b...

Current branch diff-target is up to date.

Changes applied before test

commit 29831f49f79e0d281a2f5cb501d7129f9655093e
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 2 13:25:47 2020 +0200

    tests: Replace lister_xyz fixtures with initialized_lister fixture

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/36/ for more details.

Harbormaster completed remote builds in B14876: Diff 13642.Sep 2 2020, 1:33 PM

ardumont edited the summary of this revision. (Show Details)Sep 2 2020, 2:18 PM

I'm not sure I get what problem this diff is solving (and the commit message gives no clue about it).
The "why", focus on the "why" (and "how", if needed) :-)

This revision now requires changes to proceed.Sep 2 2020, 5:02 PM

ardumont retitled this revision from tests: Replace lister_xyz fixtures with initialized_lister fixture to tests: Unify lister initialization under the `initialized_lister` fixture.Sep 2 2020, 5:58 PM

ardumont edited the summary of this revision. (Show Details)

Rework commit message, aligning it with the current diff description

Build is green

Patch application report for D3861 (id=13658)

Rebasing onto 5a5b7ef70b...

Current branch diff-target is up to date.

Changes applied before test

commit 4d280da2b76755d0533c37b8558bf3db24581792
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Sep 2 13:25:47 2020 +0200

    tests: Unify lister initialization under the `initialized_lister` fixture
    
    This avoids too many different lister initialization fixtures (lister_cran,
    lister_bitbucket, etc...).

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/37/ for more details.

Harbormaster completed remote builds in B14891: Diff 13658.Sep 2 2020, 6:45 PM

okay-ish. I still don't really get the point of this diff. You still have as many fixtures as before, it's just that they all have the same same. For me it defies the simplification/clarification this diff claims it aims at. I won't reject but I'm not convinced neither (sorry).