Differential D3857

test_cli: Exclude launchpad lister from the check
ClosedPublic
Actions

Authored by ardumont on Sep 1 2020, 3:57 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLSe99d3464e463: test_cli: Exclude launchpad lister from the check

Summary

I did not put too much thinking on this as the listers will be rewritten soon.

This should fix the build [1]

[1] https://jenkins.softwareheritage.org/view/Debian%20packages/job/debian/job/packages/job/DLS/job/gbp-buildpackage/77/console

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Sep 1 2020, 3:57 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 1 2020, 3:57 PM

Build is green

Patch application report for D3857 (id=13629)

Rebasing onto 250160ad75...

Current branch diff-target is up to date.

Changes applied before test

commit e99d3464e463f593e769e4f7355e7a0b4a2006c1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Sep 1 15:55:24 2020 +0200

    test_cli: Exclude launchpad lister from the check
    
    This should fix the build [1]
    
    [1] https://jenkins.softwareheritage.org/view/Debian%20packages/job/debian/job/packages/job/DLS/job/gbp-buildpackage/77/console

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/28/ for more details.

Harbormaster completed remote builds in B14862: Diff 13629.Sep 1 2020, 4:00 PM

anlambert accepted this revision.Sep 1 2020, 4:01 PM

This revision is now accepted and ready to land.Sep 1 2020, 4:01 PM

we could argue that having the launchpad lister attempting a connection on instantiation is pretty bad, but yeah, ok

ardumont added inline comments.Sep 1 2020, 4:05 PM

swh/lister/tests/test_cli.py
28–30	fixture setup i'm referring to https://forge.softwareheritage.org/source/swh-lister/browse/master/swh/lister/launchpad/tests/conftest.py$41-42