closed by d33d009d1fb9b89d47df3476c7da86c88b1d4035
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 29 2020
Apr 28 2020
correct django pinning
fixes according to comments
In D3073#74847, @anlambert wrote:While individual doc build can still be launched in each subproject, I am fine with it.
trigger jenkins (maybe)
trigger jenkins
update index.rst
and remaining references to the storage fixture in test_cli...
forgot tox.ini
fixes according to anlambert's comments
Apr 27 2020
closed by 3043177f79b24d2c5791c3196bd17116f83086bc
update copyright dates of modifed files + fix a typo
Apr 24 2020
rebase
clean import statements in test_cli.py
rebase
rebase + add forgotten test_kafka_writer test file
Adapt according to ardumont's comments
looks fine to me, but the few minor comments. I'll let @vlorentz gives his green stamp on this.
Apr 23 2020
rebased
yet more comments
Add more comments in the convoluted test code
ok but IMHO something should be done, some day, to "normalize" also this command so it accepts the "standard" configuration scheme (via --config-file or the SWH_CONFIG_FILE env var). But that's another task. Thanks for the fix.
In D3056#74217, @olasd wrote:Jeez. The check_rpc_serve context manager is so backwards it broke my brain a little. Took me quite a while to figure out that the thread actually runs the test rather than the server. I also think the synchronization between the test and the server initialization should be done more explicitly.
(but I don't really have a better thing to suggest right now)
rebase
Add a commit to "normalize" the get_journal_client() function
In D3044#73903, @ardumont wrote:I'd say it'd be neat to add some docstrings and type at the same time, don't you think?
In D3040#73644, @ardumont wrote:Technically, this sounds fine ;)
What is the new use case? Will we merge back the content topics into one or something?