Differential D3061

Remove recently added test_cli.test_rpc_serve* tests
ClosedPublic
Actions

Authored by douardda on Apr 24 2020, 3:19 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTOecadd5373783: Remove recently added test_cli.test_rpc_serve* tests

Summary

these are unreliable and werkzeug's tests WSGI server does not handle
being executed from pytest very well (means it executes pytest all over
again).

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 24 2020, 3:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 24 2020, 3:19 PM

good bye ;)

This revision is now accepted and ready to land.Apr 24 2020, 3:21 PM

Build is green

Patch application report for D3061 (id=10893)

Rebasing onto 038c30b408...

Current branch diff-target is up to date.

Changes applied before test

commit ecadd5373783cfbf656f4e13d497f9d1d2ed2f57
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 24 15:16:06 2020 +0200

    Remove recently added test_cli.test_rpc_serve* tests
    
    these are unreliable and werkzeug's tests WSGI server does not handle
    being executed from pytest very well (means it executes pytest all over
    again).

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/132/ for more details.

Harbormaster completed remote builds in B12045: Diff 10893.Apr 24 2020, 3:25 PM

Closed by commit rDSTOecadd5373783: Remove recently added test_cli.test_rpc_serve* tests (authored by douardda). · Explain WhyApr 24 2020, 3:47 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSTOecadd5373783: Remove recently added test_cli.test_rpc_serve* tests.