Differential D3044

Move get_journal_client function to swh.journal.client
ClosedPublic
Actions

Authored by douardda on Apr 22 2020, 4:50 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T2355: Make swh-journal independent from swh-storage or swh-objstorage

Commits

rDJNLdc96335dbf5a: Normalize the get_journal_client() function
rDJNL72ea87ccf784: Move get_journal_client function to swh.journal.client

Summary

but make it not click-specific (get rid of the ctx argument).

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Apr 22 2020, 4:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 22 2020, 4:50 PM

Build was aborted

Patch application report for D3044 (id=10826)

Rebasing onto 42f4a89abc...

Current branch diff-target is up to date.

Changes applied before test

commit bec3b54f642016c9c7db97b7c34cc10a32ca49ac
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Apr 22 16:31:31 2020 +0200

    Move get_journal_client function in swh.journal.client
    
    but make it not click-specific (get rid of the ctx argument).

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/53/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/53/console

Harbormaster failed remote builds in B11980: Diff 10826!Apr 22 2020, 5:11 PM

zack retitled this revision from Move get_journal_client function in swh.journal.client to Move get_journal_client function to swh.journal.client.Apr 22 2020, 5:18 PM

I'd say it'd be neat to add some docstrings and type at the same time, don't you think?

douardda mentioned this in D3040: Add a split_content argument to object_dicts() and objects() strategies.Apr 23 2020, 9:47 AM

In D3044#73903, @ardumont wrote:

I'd say it'd be neat to add some docstrings and type at the same time, don't you think?

docstring, for sure, typing, well, does not hurt either I guess :-)

Add a commit to "normalize" the get_journal_client() function

Build is green

Patch application report for D3044 (id=10839)

Rebasing onto 42f4a89abc...

Current branch diff-target is up to date.

Changes applied before test

commit dc96335dbf5a245238b7fbedb7d81e36491c45c8
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Apr 23 11:00:09 2020 +0200

    Normalize the get_journal_client() function
    
    make it similar to other get_xxx factory functions we have:
    
    - make it take a `cls` first argument (only supports "kafka" for now),
    - take **kwargs as arguments to be passed to the class constructor.
    
    This comes with the following changes in configuration:
    
    - the config entry for the journal client is now "journal_client" (instead
      of "journal"),
    - the journal_client config dict must have a "cls" field (only "kafka" being
      supported for now).
    
    Compatibility should be ensured.

commit 72ea87ccf784f4a3f6e0d1def7abd371a8c77d5c
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Apr 22 16:31:31 2020 +0200

    Move get_journal_client function to swh.journal.client
    
    but make it not click-specific (get rid of the ctx argument).
    
    This is needed so we can use this function from non-cli related code,
    and when extracting replayer out of swh-journal.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/54/ for more details.

Harbormaster completed remote builds in B11994: Diff 10839.Apr 23 2020, 11:56 AM

awesome ;)

This revision is now accepted and ready to land.Apr 23 2020, 11:58 AM

Closed by commit rDJNL72ea87ccf784: Move get_journal_client function to swh.journal.client (authored by douardda). · Explain WhyApr 23 2020, 12:27 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDJNL72ea87ccf784: Move get_journal_client function to swh.journal.client.

douardda added a commit: rDJNLdc96335dbf5a: Normalize the get_journal_client() function.

ardumont mentioned this in D3049: codemeta: Add compatibility with PyLD >= 2.0.0..Apr 23 2020, 2:43 PM

ardumont mentioned this in D3057: indexer.cli: Adapt get_journal_client instantiation.Apr 23 2020, 4:12 PM

ardumont mentioned this in rDCIDX1d0600055e51: cli: Adapt journal client instantiation according to latest change.Apr 23 2020, 4:26 PM