Page MenuHomeSoftware Heritage

Move the content of swh/objstorage/__init__.py in swh/objstorage/factory.py
ClosedPublic

Authored by douardda on Apr 24 2020, 3:51 PM.

Details

Summary

This is needed to "empty" the swh.objstorage's *module* from any
non-subpackage objects, so we can implement the swh.objstorage.replayer
outside the swh.objstorage's repo, in a dedicated repo/project.

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3062 (id=10895)

Rebasing onto 17f81a701e...

Current branch diff-target is up to date.
Changes applied before test
commit 68d01a09251b18de3c6a865d7c2fcbe0b1a6af8f
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 24 15:39:35 2020 +0200

    Move the content of swh/objstorage/__init__.py in swh/objstorage/factory.py
    
    This is needed to "empty" the swh.objstorage's *module* from any
    non-subpackage objects, so we can implement the swh.objstorage.replayer
    outside the swh.objstorage's repo, in a dedicated repo/project.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/3/ for more details.

ardumont added a subscriber: ardumont.

ok, some comments in the diff.

swh/objstorage/__init__.py
9

make that the official type ;)

__path__: Iterable[str]...
swh/objstorage/tests/test_multiplexer_filter.py
1

always the header ;)

This revision is now accepted and ready to land.Apr 24 2020, 3:59 PM

update copyright dates of modifed files + fix a typo

Build is green

Patch application report for D3062 (id=10912)

Rebasing onto 17f81a701e...

Current branch diff-target is up to date.
Changes applied before test
commit bd2b5e651aedf25feefa4b7970e80f620afd2b6b
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Apr 24 15:39:35 2020 +0200

    Move the content of swh/objstorage/__init__.py in swh/objstorage/factory.py
    
    This is needed to "empty" the swh.objstorage's *module* from any
    non-subpackage objects, so we can implement the swh.objstorage.replayer
    outside the swh.objstorage's repo, in a dedicated repo/project.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/5/ for more details.