Update: Skip redundant post_load check when revisions are identified as identical in prepare

Fix is now deployed to production, closing this.

Rebase

Update: Wrap temporary folder creation in a private method

Bye bye duplicated code related to browsing contents, thanks a lot for that !

Overall looks good to me ! I added a couple of nitpick comments to handle before landing this.

Cool, thanks !

Forgot to rebase, closed by rDWAPPScd747fd0e79be6e2cfe941c25479f4c2b30bd6bb.

Looks good to me.

Update:

• handle @vlorentz comments
• ensure all get_snapshot_context code is covered by tests

Great, thanks !

@anlambert Can you take this diff from here?

Looks good to me, better indeed.

Since D6608 got landed and deployed to production, revision reconstruction discrepancy is detected earlier and there is already a couple reported on sentry,
so keeping this opened.

Duplicate of T3724 I think

Update license header

Update: Ensure to pass a valid url to URL constructor and encode path query parameter value

In D6614#171828, @vlorentz wrote:

Then when doing this:

directoryUrl += `?path=${path}`;

directoryUrl will end with ?path=/path&/foo and that's not good

In D6614#171796, @vlorentz wrote:

What if there is a & character in the path?

Not an issue, URL object will correctly parse it as part of the path.

>>> s = "http://example.org/path&/foo?service=swh&query=bar"
"http://example.org/path&/foo?service=swh&query=bar"
>>> new URL(s)
URL { href: "http://example.org/path&/foo?service=swh&query=bar", origin: "http://example.org", protocol: "http:", username: "", password: "", host: "example.org", hostname: "example.org", port: "", pathname: "/path&/foo", search: "?service=swh&query=bar" }
​

Cool, nice pytest trick to know !

Looks good to me.

Update: Address @vlorentz comments

Update: Simplify test implementation

Update: Improve commit messages in test

The issue is related to the difference of fetched revision data whether we use the swh.loader.svn.SvnLoader class (fetching revisions
one at a time through a ping pong with the svn server) or the swh.loader.svn.SvnLoaderFromRemoteDump class (fetching all revisions
to a dump file in one operation).

Original comment posted in T3695 by @ardumont

Rebase