Page MenuHomeSoftware Heritage

Add types to the svn module
ClosedPublic

Authored by ardumont on Wed, Nov 10, 3:49 PM.

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D6636 (id=24124)

Rebasing onto 0f70f07bc3...

Current branch diff-target is up to date.
Changes applied before test
commit cbb442cff73b2eda34f31f8f9c7c48a470cd6234
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 10 15:45:58 2021 +0100

    Add types to the svn module
    
    Related to T3719

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/186/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/186/console

Harbormaster returned this revision to the author for changes because remote builds failed.Wed, Nov 10, 3:52 PM
Harbormaster failed remote builds in B25003: Diff 24124!
vlorentz added inline comments.
swh/loader/svn/svn.py
170

need to update this

225–231

would make sense to add a data structure for this, at least a namedtuple

Build is green

Patch application report for D6636 (id=24125)

Rebasing onto 0f70f07bc3...

Current branch diff-target is up to date.
Changes applied before test
commit b7ed7adf9ea50b4499acce2533ebba53c829e37f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 10 15:45:58 2021 +0100

    Add types to the svn module
    
    Related to T3719

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/187/ for more details.

swh/loader/svn/svn.py
225–231

yes, in another diff though if you don't mind (i'm lazy right now).

anlambert added a subscriber: anlambert.

Cool, thanks !

This revision is now accepted and ready to land.Wed, Nov 17, 10:57 AM

[don't remember the difference but the hash is different now]

Build is green

Patch application report for D6636 (id=24163)

Rebasing onto 65c6ae9e12...

Current branch diff-target is up to date.
Changes applied before test
commit 49cd7cc4fadb961d6eae46e33ac092d8a09c53c9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Nov 10 15:45:58 2021 +0100

    Add types to the svn module
    
    Related to T3719

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/190/ for more details.

This revision was automatically updated to reflect the committed changes.