Page MenuHomeSoftware Heritage

browse/snapshot_context: Handle snapshot containing only releases
ClosedPublic

Authored by anlambert on Tue, Nov 16, 11:42 AM.

Details

Summary

This fixes observed errors when trying to browse a snapshot containing
only releases.

Releases targeting directories are also now properly handled.

Related to T3724

Diff Detail

Repository
rDWAPPS Web applications
Branch
browse-snapshot-releases-only
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25030
Build 39115: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 39114: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D6641 (id=24139)

Rebasing onto e2659cfed5...

Current branch diff-target is up to date.
Changes applied before test
commit 9725d7135b2e7fab7074d1cd20c2cf33cfef9e6d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 15 16:36:29 2021 +0100

    browse/snapshot_context: Handle snapshot containing only releases
    
    Related to T3724

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1233/ for more details.

vlorentz added inline comments.
swh/web/browse/snapshot_context.py
602

Wouldn't it make sense to use the last one? If releases are named after versions, the last one is more likely the be the most recent, which is the "best" one

swh/web/tests/browse/test_snapshot_context.py
11–12

for consistency with other packages.

(we really need to get rid of this.....)

swh/web/browse/snapshot_context.py
602

Indeed it makes sense, will update.

swh/web/tests/browse/test_snapshot_context.py
11–12

ack, yes it is so confusing, not the first time I encounter that issue.

Update:

  • handle @vlorentz comments
  • ensure all get_snapshot_context code is covered by tests

Build is green

Patch application report for D6641 (id=24150)

Rebasing onto 4eff12ad51...

First, rewinding head to replay your work on top of it...
Applying: browse/snapshot_context: Handle snapshots containing only releases
Changes applied before test
commit f4b352c1e51525584da3772de44502b4d06d189c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 15 16:36:29 2021 +0100

    browse/snapshot_context: Handle snapshots containing only releases
    
    That specific case was not covered at all as such snapshots could not
    be found into the archive until recently.
    
    So ensure to handle such snapshots properly and add exhaustive tests
    to cover all possible execution paths.
    
    Related to T3724

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1239/ for more details.

swh/web/browse/snapshot_context.py
586

are you sure it can't be a directory or content?

swh/web/browse/snapshot_context.py
586

I did not see any HEAD alias pointing to other object types so far.
I could raise an exception but does it really worth it ?

swh/web/browse/snapshot_context.py
586

Yeah, let's raise an exception, it will save us a few minutes if it ever shows up in Sentry

swh/web/browse/snapshot_context.py
586

In fact, we are good here as branch aliases targeting object types different from revision or release are already filtered out by the process_snapshot_branches function.

So we can keep that code as it is.

This revision is now accepted and ready to land.Tue, Nov 16, 5:48 PM