Page MenuHomeSoftware Heritage

ra: Handle invalid values for svn:eol-style property
ClosedPublic

Authored by anlambert on Thu, Nov 4, 11:32 AM.

Details

Summary

Some repositories in the wild have invalid values for that
property so we must handle that edge case.

Related sentry issue

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6604 (id=23995)

Rebasing onto b326099c73...

Current branch diff-target is up to date.
Changes applied before test
commit 830482755fe63a110ad720b2d4e5d328465f4b9d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 4 11:31:07 2021 +0100

    ra: Handle invalid values for svn:eol-style property
    
    Some repositories in the wild have invalid values for that
    property so we must handle that edge case.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/158/ for more details.

vlorentz added inline comments.
swh/loader/svn/ra.py
39–43

why do we do this at all, anyway?

vlorentz added inline comments.
swh/loader/svn/ra.py
39–43

pffffffff

Could you add a comment in the code to link to that explanation?

(or even copy all of it for future-proofing)

This revision is now accepted and ready to land.Thu, Nov 4, 12:12 PM
swh/loader/svn/ra.py
39–43

pffffffff

yeah, subversion ...

Could you add a comment in the code to link to that explanation?

There is already one here.