Page MenuHomeSoftware Heritage

loader: Perform a complete reloading when detecting altered history
ClosedPublic

Authored by anlambert on Thu, Nov 4, 4:48 PM.

Details

Summary

When attempting to load again a subversion repository, if the history is
detected as altered compared to latest loading (a commit modified on
the server using the svnadmin command for instance) then do a complete
reloading of the repository instead of aborting the loading process.

Related to T3694

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6611 (id=24007)

Rebasing onto 830482755f...

Current branch diff-target is up to date.
Changes applied before test
commit 057e00bf93dcc0c3817e7e06f94615ab4a35ff00
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Nov 4 16:43:21 2021 +0100

    loader: Perform a complete reloading when detecting altered history
    
    When attempting to load again a subversion repository, if the history is
    detected as altered compared to latest loading (a commit modified on
    the server using the svnadmin command for instance) then do a complete
    reloading of the repository instead of aborting the loading process.
    
    Related to T3694

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/160/ for more details.

This revision is now accepted and ready to land.Mon, Nov 8, 10:49 AM
ardumont added a subscriber: ardumont.

lgtm

Thanks.

I'd make the debug message into an info one but that's fine as it is.

swh/loader/svn/loader.py
276–280

Make it at least informational so we can notice it happens.