Page MenuHomeSoftware Heritage

pytest_plugin: Increase poll timeout in consume_messages
ClosedPublic

Authored by anlambert on Wed, Nov 17, 4:36 PM.

Details

Summary

This prevents flaky test_storage_replayer in swh-storage tests.

The test above often fails when running the swh-environment Jenkins job.

I managed to reproduce the issue locally by running that test again and again in an infinite loop.

Once the poll timeout increased running the test again in an infinte loop does not fail anymore.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6649 (id=24175)

Rebasing onto a38c6e7e94...

First, rewinding head to replay your work on top of it...
Applying: pytest_plugin: Increase poll timeout in consume_messages
Changes applied before test
commit 6036945bc4d0bbc5606220e3d8b75f2397fdf380
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 17 16:29:42 2021 +0100

    pytest_plugin: Increase poll timeout in consume_messages
    
    This prevents flaky test_storage_replayer in swh-storage tests.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/184/ for more details.

This revision is now accepted and ready to land.Thu, Nov 18, 10:22 AM

Build is green

Patch application report for D6649 (id=24182)

Rebasing onto a38c6e7e94...

Current branch diff-target is up to date.
Changes applied before test
commit bac6b474b229e4c81edc4a3c6579a390b9767847
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 17 16:29:42 2021 +0100

    pytest_plugin: Increase poll timeout in consume_messages
    
    This prevents flaky test_storage_replayer in swh-storage tests.

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/185/ for more details.