Page MenuHomeSoftware Heritage

loader: Fix error when first revision number is not one
ClosedPublic

Authored by ardumont on Wed, Nov 3, 6:07 PM.

Details

Summary

It exist cases where the first revision number returned by a subversion
server has a value greater than one.

The loader did not expect such cases in its current implementation and
was raising an error preventing the loading of such repository in the
archive (apart when using the SvnLoaderFromRemoteDump class which
always dumps revisions starting from number one).

So ensure to cover that case in loader implementation.

Related to T3701

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D6602 (id=23990)

Rebasing onto b326099c73...

Current branch diff-target is up to date.
Changes applied before test
commit e921b70754ba6a85300369df97675bcc45a3abb3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 3 17:59:29 2021 +0100

    loader: Fix error when first revision number is not one
    
    It exist cases where the first revision number returned by a subversion
    server has a value greater than one.
    
    The loader did not expect such cases in its current implementation and
    was raising an error preventing the loading of such repository in the
    archive (apart when using the SvnLoaderFromRemoteDump class which
    always dumps revisions starting from number one).
    
    So ensure to cover that case in loader implementation.
    
    Related to T3701

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/155/ for more details.

Update: Simplify test implementation

Build is green

Patch application report for D6602 (id=23992)

Rebasing onto b326099c73...

Current branch diff-target is up to date.
Changes applied before test
commit 94af4ab193d42b0676fc5e6c9ac6d6539b548d18
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 3 17:59:29 2021 +0100

    loader: Fix error when first revision number is not one
    
    It exist cases where the first revision number returned by a subversion
    server has a value greater than one.
    
    The loader did not expect such cases in its current implementation and
    was raising an error preventing the loading of such repository in the
    archive (apart when using the SvnLoaderFromRemoteDump class which
    always dumps revisions starting from number one).
    
    So ensure to cover that case in loader implementation.
    
    Related to T3701

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/156/ for more details.

Any idea why this happens?

I suppose svnadmin configuration divergence is possible.

As an example, it's possible to share a svn repository for multiple projects...
(check the apache svn repository).

This revision is now accepted and ready to land.Mon, Nov 8, 12:29 PM
ardumont edited reviewers, added: anlambert; removed: ardumont.
This revision now requires review to proceed.Mon, Nov 8, 3:00 PM

Build is green

Patch application report for D6602 (id=24035)

Rebasing onto 057e00bf93...

Current branch diff-target is up to date.
Changes applied before test
commit 51f4d54bdfd611c51ed1a798e2e0c1ebad877860
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Nov 3 17:59:29 2021 +0100

    loader: Fix error when first revision number is not one
    
    It exist cases where the first revision number returned by a subversion
    server has a value greater than one.
    
    The loader did not expect such cases in its current implementation and
    was raising an error preventing the loading of such repository in the
    archive (apart when using the SvnLoaderFromRemoteDump class which
    always dumps revisions starting from number one).
    
    So ensure to cover that case in loader implementation.
    
    Related to T3701

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/163/ for more details.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Nov 8, 4:06 PM
This revision was automatically updated to reflect the committed changes.