Bump swh-model requirement

In D5879#150208, @anlambert wrote:

In D5879#150207, @zack wrote:

I think this also needs bumping the versioned dependency on swh-model (and a release of that).

already done ;-)

In D5879#150207, @zack wrote:

I think this also needs bumping the versioned dependency on swh-model (and a release of that).

Looks good to me !

Rebase

Possible duplicated origins should be handled but looks good otherwise.

Looks good to me ! You can now merge your feature branch in the master one and push it to remote, phabricator will automatically close the diff afterwards.

In D5869#149887, @ardumont wrote:

An alternative would be to use a postgres db in docker instead.

But fine, let's see how it goes.

Almost there, more code can be simplified and commit message should be improved.

Looks good but can be improved a little.

Issue has been resolved and tarballs hosted on the Internet Archive can now be properly loaded in production (see example).

This should happen both client and server side (as fallback).

Ack, I should have ping on you on that change. Plus now that painless script errors are caught by an exception handler, long pytest report printing the bulk error exceptions should not happen so often.

Fix implemented in D5859 works \o/

I just figured out that data we are missing (Content-Length, Last-Modified) from tarballs archived by the Internet archive are in fact available in x-archive-orig-* HTTP response headers

Forgot to remove bug in painless code

Use multiline string and use dict.get to prevent errors if JSON schema changes.

@ardumont, @rdicosmo, I just figured out that data we are missing (Content-Length, Last-Modified) from tarballs archived by the Internet archive are in fact available in x-archive-orig-* HTTP response headers, see below:

Update commit message

Fix typo

Apply @vlorentz comment

In T3157#66041, @jayeshv wrote:

This will simplify branches view implementation. You should create a diff to handle it.

Yes. Let me check it's side effects as well. The 'archive.lookup_snapshot' is called from multiple places.

In T3157#66039, @jayeshv wrote:

@anlambert Thank you. I will try to do some refactoring here.

There is no need to use JavaScript here from my point of view.

The ideal fix would be to refactor the code to move the entire presentation logic to the template engine. (We already have a check in the template to show "The list of branches is empty" message in case the branch list is empty. But, i think this case will never occur with the current server code)

More answers after further reading and analysis.

This will eventually cause a 404 error when the user search for a non existing branch name in the UI. I don't think this is the intended behavior.

not for review, just to make sure it's enough to fix the build [1]