anlambert retitled this revision from tarball/uncompress: Ensure destination folder exists before unpacking It enables to avoid errors such as the one encountered in P1068. Depends on D5856 to tarball/uncompress: Ensure destination folder exists before unpacking.Jun 11 2021, 3:35 PM

anlambert edited the summary of this revision. (Show Details)

anlambert added a parent revision: D5856: tests/tarball: Use uncompress function instead of private ones.

Build is green

Patch application report for D5857 (id=20960)

Could not rebase; Attempt merge onto cbf07d953e...

Updating cbf07d9..02bf964
Fast-forward
 swh/core/tarball.py            |  9 ++++----
 swh/core/tests/test_tarball.py | 50 +++++-------------------------------------
 2 files changed, 10 insertions(+), 49 deletions(-)

Changes applied before test

commit 02bf96407ff4c619a76644c4675807e90fea699e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 11 15:31:55 2021 +0200

    tarball/uncompress: Ensure destination folder exists before unpacking

commit 14f8c4296819d6c3de1cfee5d81d9081aa6668e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 11 15:23:26 2021 +0200

    tests/tarball: Use uncompress function instead of private ones
    
    Do not leak internal swh.core.tarball implementation in tests.
    
    Also fix swh.core.tarball.uncompress documentation and implementation,
    the function should not return a value.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/232/ for more details.

ardumont published this revision for review.Jun 11 2021, 3:36 PM

ardumont accepted this revision.

This revision is now accepted and ready to land.Jun 11 2021, 3:37 PM

Build is green

Patch application report for D5857 (id=20960)

Could not rebase; Attempt merge onto cbf07d953e...

Updating cbf07d9..02bf964
Fast-forward
 swh/core/tarball.py            |  9 ++++----
 swh/core/tests/test_tarball.py | 50 +++++-------------------------------------
 2 files changed, 10 insertions(+), 49 deletions(-)

Changes applied before test

commit 02bf96407ff4c619a76644c4675807e90fea699e
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 11 15:31:55 2021 +0200

    tarball/uncompress: Ensure destination folder exists before unpacking

commit 14f8c4296819d6c3de1cfee5d81d9081aa6668e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 11 15:23:26 2021 +0200

    tests/tarball: Use uncompress function instead of private ones
    
    Do not leak internal swh.core.tarball implementation in tests.
    
    Also fix swh.core.tarball.uncompress documentation and implementation,
    the function should not return a value.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/233/ for more details.

Harbormaster completed remote builds in B21939: Diff 20960.Jun 11 2021, 3:37 PM

Closed by commit rDCORE02bf96407ff4: tarball/uncompress: Ensure destination folder exists before unpacking (authored by anlambert). · Explain WhyJun 11 2021, 3:42 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDCORE02bf96407ff4: tarball/uncompress: Ensure destination folder exists before unpacking.