Differential D5877

assets/save: Ensure to use canonical github repo URL as origin URL
ClosedPublic
Actions

Authored by anlambert on Jun 15 2021, 5:58 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T1110: document GitHub caseness caveats
T2187: Origin URL duplicates due to caps and .git URL

Commits

rDWAPPS1bd55d031ec8: assets/save: Ensure to use canonical github repo URL as origin URL

Summary

When a save code now request is submitted for a github repository,
ensure to use the canonical repository URL by getting it from the
github Web API.

The purpose is to avoid adding duplicated github origins in the
archive.

Related to T1110
Related to T2187

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 15 2021, 5:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 15 2021, 5:58 PM

Great.

ardumont accepted this revision.Jun 15 2021, 6:03 PM

This revision is now accepted and ready to land.Jun 15 2021, 6:03 PM

Build is green

Patch application report for D5877 (id=21051)

Rebasing onto 01ffb31ff7...

Current branch diff-target is up to date.

Changes applied before test

commit 1bd55d031ec8fb360ba4a2fe652862fe4dabb0ac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jun 15 17:53:42 2021 +0200

    assets/save: Ensure to use canonical github repo URL as origin URL
    
    When a save code now request is submitted for a github repository,
    ensure to use the canonical repository URL by getting it from the
    github Web API.
    
    The purpose is to avoid adding duplicated github origins in the
    archive.
    
    Related to T1110
    Related to T2187

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/879/ for more details.

Harbormaster completed remote builds in B22042: Diff 21051.Jun 15 2021, 6:08 PM

Closed by commit rDWAPPS1bd55d031ec8: assets/save: Ensure to use canonical github repo URL as origin URL (authored by anlambert). · Explain WhyJun 16 2021, 10:52 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS1bd55d031ec8: assets/save: Ensure to use canonical github repo URL as origin URL.