Page MenuHomeSoftware Heritage

tests/tarball: Use uncompress function instead of private ones
ClosedPublic

Authored by anlambert on Jun 11 2021, 3:27 PM.

Details

Summary

Do not leak internal swh.core.tarball implementation in tests.

Also fix swh.core.tarball.uncompress documentation and implementation,
the function should not return a value.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D5856 (id=20958)

Rebasing onto cbf07d953e...

Current branch diff-target is up to date.
Changes applied before test
commit 14f8c4296819d6c3de1cfee5d81d9081aa6668e7
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Fri Jun 11 15:23:26 2021 +0200

    tests/tarball: Use uncompress function instead of private ones
    
    Do not leak internal swh.core.tarball implementation in tests.
    
    Also fix swh.core.tarball.uncompress documentation and implementation,
    the function should not return a value.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/231/ for more details.

This revision is now accepted and ready to land.Jun 11 2021, 3:31 PM