identify: Fix exclude_patterns parameter type for identify_object
ClosedPublic
Actions

Authored by anlambert on Jun 16 2021, 12:15 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDHGf3232bfd6786: identify: Fix exclude_patterns parameter type for identify_object

Summary

Since rDMODe09446a6f44b9070ea70a9760bc82dee0bbcb687, it must be an
iterable of bytes.

Issue spotted thanks to the swh-environment build on Jenkins and the
new failing tests.

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jun 16 2021, 12:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 16 2021, 12:15 PM

Build is green

Patch application report for D5879 (id=21063)

Rebasing onto 2877eb3c4e...

Current branch diff-target is up to date.

Changes applied before test

commit 86a0689f8116a51a9e0fd093e06577af8a6ec1c6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jun 16 12:11:10 2021 +0200

    identify: Fix exclude_patterns parameter type for identify_object
    
    Since rDMODe09446a6f44b9070ea70a9760bc82dee0bbcb687, it must be an
    iterable of bytes.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/256/ for more details.

Harbormaster completed remote builds in B22054: Diff 21063.Jun 16 2021, 12:17 PM

anlambert requested review of this revision.Jun 16 2021, 12:17 PM

I think this also needs bumping the versioned dependency on swh-model (and a release of that).

In D5879#150207, @zack wrote:

I think this also needs bumping the versioned dependency on swh-model (and a release of that).

already done ;-)

In D5879#150208, @anlambert wrote:

In D5879#150207, @zack wrote:

I think this also needs bumping the versioned dependency on swh-model (and a release of that).

already done ;-)

remain dep bumping though, will update

Bump swh-model requirement

Build is green

Patch application report for D5879 (id=21064)

Rebasing onto 2877eb3c4e...

Current branch diff-target is up to date.

Changes applied before test

commit f3232bfd67869c1acd66bbb871139908cc8dd910
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Jun 16 12:11:10 2021 +0200

    identify: Fix exclude_patterns parameter type for identify_object
    
    Since rDMODe09446a6f44b9070ea70a9760bc82dee0bbcb687, it must be an
    iterable of bytes.

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/257/ for more details.

Harbormaster completed remote builds in B22055: Diff 21064.Jun 16 2021, 12:31 PM

ardumont accepted this revision.Jun 16 2021, 12:35 PM

This revision is now accepted and ready to land.Jun 16 2021, 12:35 PM

Closed by commit rDLDHGf3232bfd6786: identify: Fix exclude_patterns parameter type for identify_object (authored by anlambert). · Explain WhyJun 16 2021, 12:47 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDHGf3232bfd6786: identify: Fix exclude_patterns parameter type for identify_object.