split the commit in 3 parts
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Dec 11 2020
Dec 9 2020
fix and improve the long int encoding examples
Question: who should be responsible for filling this table? The loader or the storage (as side effect of revision_add)?
Dec 8 2020
Ok so the plan is a first step as simple as possible, implementing what @olasd proposed in the task, put this table in the storage, and provide a simple batch get API endpoint.
fix typing according to olasd's comment
In D4684#117170, @anlambert wrote:Cool, thanks ! Can you push a new tag for swh-core once landed ? This will make swh-web CI happy.
and requirements-http.txt
ci msg
Also the "Currently" in not appropriate, there is not any chance the 7.10.0 will be updated, so the I'd get rid of the "currently" in this caveat entry description.
Not sure the debian specific part is needed here. It's only a transient problem that will hit very few (most probably swh team mate only) people.
Dec 7 2020
not sure why this is needed but otherwise lgtm
(not sure why tests are red) lgtm
fix indentation pbs
In T2827#54141, @olasd wrote:Just to be sure (I'm confused even after reading the history document), HedgeDoc is the *community* fork of the HackMD code base (which was named CodiMD), and has no relationship with the original upstream company running hackmd.io. Correct?
Dec 4 2020
improve the doc
done for the journal. We might want to do the same in the RPC low level stack (swh.core.api), some day (or replace this later by gRPC or so :-) )
overall lgtm but see comments
Add a few tests for msgpack codecs (dates and long integers)
Improve (?) the commit message
Simplify a bit the bw compat code (no need for "genericity" there)
Use (poorly/not documented) timestapmp/datetime feature flags of mashpack to handle datetime objs
Dec 3 2020
forgot to save before commit...
Update the documentation for (WIP) extended type based datetime encoding
can storage be easily added to the backup server?
Replace usage of arrow for its humanize() feature by the humanize module
Dec 2 2020
Dec 1 2020
lgtm *but*:
- you should remove the ".84" part in the timestamps (I first read 1h -> 42h)
- I'd like the commit message to give a bit more details on what this diff really is doing (if I get the idea, keep the directory structure between 2 revisions and "apply the modifications" rather than rebuild the whole structure, right?)
typos and (somes) fixes reported by vlorentz
In D4633#115780, @vlorentz wrote:Oh, and you need to add something to explain anonymized topics
typo
Nov 30 2020
Note: I have not made any proofreading yet, so it should be full of typos and errors...
LGTM. I was wondering if a regexp would not be simpler for the validation step, but it would make error message more generic and less user friendly.
Nov 27 2020
ok we are getting close I think. Just a few more comments to be handled and we are done.
I think the best would be to put this directly in swh-docs ( rDDOC ) because it's kind of "transverse" between swh-journal, swh-storage and swh-indexer.
Nov 25 2020
Thanks!
it's not completely clear why the @never_cache did not work any more, but meh.
This may be better suited to a fix in the web API, via proper cache config headers, as @olasd mentioned on IRC (probably via https://docs.djangoproject.com/en/3.1/topics/cache/#downstream-caches )
Nov 24 2020
bit sad indeed, but LGTM
Nov 23 2020
lgtm (besides the retries_left=3 stuff)
ok ok ok
In D4554#113843, @douardda wrote:swh.core[db] is already a dep in requirements-swh.txt, why would is be needed here?
But more importantly, I disagree with the validity of the diff because pytest-posgtgresql is used directly in this package (in conftest.py), not only by the mean of the swh.core.tests.db package.