Replace usage of arrow datetime objects in favor of pure datetime ones
ClosedPublic
Actions

Authored by douardda on Dec 2 2020, 9:52 AM.

Details

Reviewers

ardumont
olasd

Group Reviewers

Reviewers

Maniphest Tasks

T2835: Get rid of the arrow library

Commits

rDSCH3c8707599ae1: Replace usage of arrow datetime objects in favor of pure datetime ones

Summary

Note that the arrow library remains used for its humanize() feature in the cli
pretty printing function.

Closes T2835.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Dec 2 2020, 9:52 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 2 2020, 9:52 AM

Build is green

Patch application report for D4642 (id=16472)

Rebasing onto 1b390a7b01...

Current branch diff-target is up to date.

Changes applied before test

commit 87d72c892939211da4ef4bb7f2d721bc51c3470a
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Dec 2 09:49:33 2020 +0100

    Replace usage of arrow datetime objects in favor of pure datetime ones
    
    Note that the arrow library remains used for its humanize() feature in the cli
    pretty printing function.
    
    Closes T2835.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/81/ for more details.

Harbormaster completed remote builds in B17658: Diff 16472.Dec 2 2020, 9:54 AM

lgtm

I'd argue to completely remove the arrow dependency though...

swh/scheduler/celery_backend/pika_listener.py
20	jsyk, we should probably move this oneliner in swh.core it's duplicated in other modules (e.g. swh.storage.utils.now comes to mind, but not only there)...
swh/scheduler/cli/task.py
118	Can't we use something else? (i'm unsure what humanize really does) If we keep the arrow dependency, i fear its use will come back at one point or another...

Other remarks, questions, inline.

This revision is now accepted and ready to land.Dec 2 2020, 10:09 AM

olasd added a subscriber: olasd.Dec 2 2020, 12:04 PM

olasd added inline comments.

swh/scheduler/celery_backend/pika_listener.py
20	meh, it's a trivial oneliner, I don't think it's really worth a dependency shuffle (OTOH it's really annoying that this pattern is still not available in the stdlib)

olasd added inline comments.Dec 2 2020, 12:07 PM

swh/scheduler/cli/task.py
118	It turns a time interval into a human readable sentence ("a few seconds ago", ...). I agree this feature is probably not worth the extra dependency on its own.

olasd added inline comments.Dec 2 2020, 12:09 PM

swh/scheduler/cli/task.py
118	(we could replace it with python-humanize, which works with native python types instead of it's own special flakes)

douardda added inline comments.Dec 2 2020, 2:37 PM

swh/scheduler/celery_backend/pika_listener.py
20	I'm on @olasd side here, at least for now.
swh/scheduler/cli/task.py
118	let's try with humanize (I thought we already depend on it somewhere, but cannot find the dep)

Replace usage of arrow for its humanize() feature by the humanize module

Build is green

Patch application report for D4642 (id=16505)

Rebasing onto 1b390a7b01...

Current branch diff-target is up to date.

Changes applied before test

commit 3c8707599ae1cc721c5ee80b6def30e2374725b6
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Dec 2 09:49:33 2020 +0100

    Replace usage of arrow datetime objects in favor of pure datetime ones
    
    Note that the humanize library is now used in the cli pretty printing
    function (in place of the arrow hiumanize feature).
    
    As a result, displayed output from some cli commands may slightly differ.
    
    Closes T2835.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/82/ for more details.

Harbormaster completed remote builds in B17691: Diff 16505.Dec 3 2020, 10:33 AM

olasd accepted this revision.Dec 3 2020, 10:54 AM

ardumont accepted this revision.Dec 3 2020, 10:55 AM

Closed by commit rDSCH3c8707599ae1: Replace usage of arrow datetime objects in favor of pure datetime ones (authored by douardda). · Explain WhyDec 3 2020, 10:59 AM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSCH3c8707599ae1: Replace usage of arrow datetime objects in favor of pure datetime ones.