Page MenuHomeSoftware Heritage

cli: Subscribe journal client to origin_visit_status
ClosedPublic

Authored by ardumont on Dec 7 2020, 8:54 AM.

Details

Summary

Related to T2590
Depends on D4670

Test Plan

tox
(failing for unrelated reasons)

Diff Detail

Repository
rDSEA Archive search
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build has FAILED

Patch application report for D4671 (id=16573)

Could not rebase; Attempt merge onto c3e5bf0a11...

Updating c3e5bf0..9646009
Fast-forward
 swh/search/cli.py            | 26 +++++++++++++---
 swh/search/journal_client.py | 16 +++++++++-
 swh/search/tests/test_cli.py | 70 +++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 106 insertions(+), 6 deletions(-)
Changes applied before test
commit 9646009720da7d2110d4dd07c62ba4795b0ecba6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:26:50 2020 +0100

    cli: Subscribe journal client to origin_visit_status
    
    Related to T2590

commit 408d51ef571391b85edf4ab570b1280ff5761aea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:39:21 2020 +0100

    cli: Allow topic prefix declaration through cli or configuration
    
    This will allow using multiple instances of journal client both for subscribing
    to different prefixed topics (swh.journal.objects and swh.journal.indexed).
    
    Related to T2590

commit 8ffcec124b73ecc2d5362cdc0429902ec6c2be27
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:34:41 2020 +0100

    cli: Allow object-type declaration through cli or configuration
    
    This will allow using multiple instances of journal client both for subscribing
    to different topics.
    
    Related to T2590

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/44/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/44/console

douardda added a subscriber: douardda.

(not sure why tests are red) lgtm

This revision is now accepted and ready to land.Dec 7 2020, 4:04 PM

(not sure why tests are red) lgtm

currently all swh-search tests are red unrelatedly
It's in-progress through and details are in a dedicated task [1]

[1] T2791

Build has FAILED

Patch application report for D4671 (id=16573)

Could not rebase; Attempt merge onto c3e5bf0a11...

Updating c3e5bf0..9646009
Fast-forward
 swh/search/cli.py            | 26 +++++++++++++---
 swh/search/journal_client.py | 16 +++++++++-
 swh/search/tests/test_cli.py | 70 +++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 106 insertions(+), 6 deletions(-)
Changes applied before test
commit 9646009720da7d2110d4dd07c62ba4795b0ecba6
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:26:50 2020 +0100

    cli: Subscribe journal client to origin_visit_status
    
    Related to T2590

commit 408d51ef571391b85edf4ab570b1280ff5761aea
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:39:21 2020 +0100

    cli: Allow topic prefix declaration through cli or configuration
    
    This will allow using multiple instances of journal client both for subscribing
    to different prefixed topics (swh.journal.objects and swh.journal.indexed).
    
    Related to T2590

commit 8ffcec124b73ecc2d5362cdc0429902ec6c2be27
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:34:41 2020 +0100

    cli: Allow object-type declaration through cli or configuration
    
    This will allow using multiple instances of journal client both for subscribing
    to different topics.
    
    Related to T2590

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/49/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/49/console

Keep the origin_intrinsic_metadata entry already there (just an excuse to trigger back the build)

Build is green

Patch application report for D4671 (id=16602)

Rebasing onto 408d51ef57...

Current branch diff-target is up to date.
Changes applied before test
commit 94d305509e7b5e63511a3f636440c74cb4419602
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:26:50 2020 +0100

    cli: Subscribe journal client to origin_visit_status
    
    Related to T2590

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/50/ for more details.