Differential D4669

cli: Allow object-type declaration through cli or configuration
ClosedPublic
Actions

Authored by ardumont on Dec 7 2020, 8:52 AM.

Details

Reviewers

douardda

Group Reviewers

Reviewers

Maniphest Tasks

T2590: Finish the indexer -> swh-search pipeline

Commits

rDSEA8ffcec124b73: cli: Allow object-type declaration through cli or configuration

Summary

This will allow using multiple instances of journal client both for subscribing
to different topics.

Related to T2590

Test Plan

tox
(might be failing for unrelated reasons)

Diff Detail

Repository

rDSEA Archive search

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 7 2020, 8:52 AM

ardumont added a child revision: D4670: cli: Allow topic prefix declaration through cli or configuration.Dec 7 2020, 8:53 AM

Build has FAILED

Patch application report for D4669 (id=16571)

Rebasing onto c3e5bf0a11...

Current branch diff-target is up to date.

Changes applied before test

commit 8ffcec124b73ecc2d5362cdc0429902ec6c2be27
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:34:41 2020 +0100

    cli: Allow object-type declaration through cli or configuration
    
    This will allow using multiple instances of journal client both for subscribing
    to different topics.
    
    Related to T2590

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/42/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/42/console

Harbormaster failed remote builds in B17753: Diff 16571!Dec 7 2020, 8:53 AM

ardumont mentioned this in D4661: search.cli: Subscribe journal client to origin_intrinsic_metadata topic.Dec 7 2020, 8:58 AM

douardda accepted this revision.Dec 7 2020, 4:06 PM

This revision is now accepted and ready to land.Dec 7 2020, 4:06 PM

Build is green

Patch application report for D4669 (id=16571)

Rebasing onto c3e5bf0a11...

Current branch diff-target is up to date.

Changes applied before test

commit 8ffcec124b73ecc2d5362cdc0429902ec6c2be27
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Dec 4 21:34:41 2020 +0100

    cli: Allow object-type declaration through cli or configuration
    
    This will allow using multiple instances of journal client both for subscribing
    to different topics.
    
    Related to T2590

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/47/ for more details.

Harbormaster completed remote builds in B17753: Diff 16571.Dec 7 2020, 10:07 PM

Closed by commit rDSEA8ffcec124b73: cli: Allow object-type declaration through cli or configuration (authored by ardumont). · Explain WhyDec 8 2020, 9:48 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSEA8ffcec124b73: cli: Allow object-type declaration through cli or configuration.