Page MenuHomeSoftware Heritage

requirements-test.txt: Drop no longer needed pytest-postgresql requirement
ClosedPublic

Authored by ardumont on Fri, Nov 20, 5:17 PM.

Details

Summary

requirements-swh.txt already declares the swh.core[db] dependency which
transitively pulls it.

Related to T2746

(That still needs some work on the debian front)

Test Plan

tox

Diff Detail

Repository
rDSCH Scheduling utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Fri, Nov 20, 5:17 PM

Build is green

Patch application report for D4548 (id=16145)

Rebasing onto 2f9e8ec122...

Current branch diff-target is up to date.
Changes applied before test
commit b4b921234b813bdd2c368fce92322d8ef2c43f10
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:17:14 2020 +0100

    requirements-test.txt: Drop no longer needed pytest-postgresql requirement
    
    requirements-swh.txt already declares the swh.core[db] dependency which
    transitively pulls it.
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/73/ for more details.

ardumont added inline comments.Fri, Nov 20, 5:18 PM
requirements-test.txt
3

wondering if i need to drop it entirely as i did here
or if i need to replace it with swh.core[db] or swh.core[testing]
(both would pull pytest-postgresql afaiui with D4543)

ardumont updated this revision to Diff 16146.Fri, Nov 20, 5:22 PM

Be explicit instead of implying dependency

ardumont added inline comments.Fri, Nov 20, 5:23 PM
requirements-test.txt
3

well, i preferred being explicit it and conservative on the deps to pull so I chose to replace pytest-postgresql by swh.core[db]

Build is green

Patch application report for D4548 (id=16146)

Rebasing onto 2f9e8ec122...

Current branch diff-target is up to date.
Changes applied before test
commit 6d38934ebb38bc65bc30c1c6edcb438acad41682
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:17:14 2020 +0100

    requirements-test.txt: Explicit swh.core[db] as test requirement
    
    instead of pytest-postgresql which is a transitive dependency from swh.core[db]
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/74/ for more details.

ardumont edited the summary of this revision. (Show Details)Fri, Nov 20, 5:26 PM
douardda accepted this revision.Mon, Nov 23, 12:36 PM
This revision is now accepted and ready to land.Mon, Nov 23, 12:36 PM
ardumont updated this revision to Diff 16185.Mon, Nov 23, 1:11 PM

Drop dependency instead

Build is green

Patch application report for D4548 (id=16185)

Rebasing onto 2f9e8ec122...

Current branch diff-target is up to date.
Changes applied before test
commit 49ed8194bf74233888f841768f234d1dc3a31243
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Nov 20 17:17:14 2020 +0100

    requirements-test.txt: Drop no longer needed pytest-postgresql requirement
    
    requirements-swh.txt already declares the swh.core[db] dependency which
    transitively pulls it.
    
    Related to T2746

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/76/ for more details.