Page MenuHomeSoftware Heritage
Feed Advanced Search

Oct 3 2018

zack updated the task description for T1234: Allow simple read-only connections to db from swh nodes.
Oct 3 2018, 3:42 PM · System administration
zack triaged T1234: Allow simple read-only connections to db from swh nodes as Normal priority.
Oct 3 2018, 3:40 PM · System administration
zack triaged T1233: use CNAME for upcoming jenkins CI as High priority.
Oct 3 2018, 3:40 PM · System administration
zack accepted D463: SQL schema: uniformize comments.

(thanks)

Oct 3 2018, 3:10 PM
zack accepted D461: doc: use inkscape instead of dia to generate image files.
Oct 3 2018, 3:08 PM
zack added a comment to D453: Make 'make' in swh-*/docs/ should run 'make' in swh-*/docs/images/.

as discussed, this diff should be abandoned

Oct 3 2018, 11:13 AM
zack requested changes to D455: Provide Sphinx targets in docs/images/ (see D453)..

I've addressed this as in rDSTO16ffb6eb9264a367a595c83c19babcfe7fb8e432
Unless you disagree with that solution, please abandon this diff

Oct 3 2018, 11:12 AM
zack committed rDSTO16ffb6eb9264: docs: make sure images are built/cleaned on sphinx targets (authored by zack).
docs: make sure images are built/cleaned on sphinx targets
Oct 3 2018, 11:11 AM
zack committed rDSTO7fa1a3436dac: images/Makefile: fix filenames (authored by zack).
images/Makefile: fix filenames
Oct 3 2018, 11:11 AM
zack requested changes to D454: Provide Sphinx targets in docs/images/ (see D453)..
Oct 3 2018, 11:09 AM
zack added a comment to D454: Provide Sphinx targets in docs/images/ (see D453)..

I've addressed this as in rDMOD6f5d74b261a3571b1915710d729af5d6ceb8804e
If it's OK with you, please abandon this diff

Oct 3 2018, 11:09 AM
zack committed rDMOD6f5d74b261a3: docs: make sure images are built/cleaned on sphinx targets (authored by zack).
docs: make sure images are built/cleaned on sphinx targets
Oct 3 2018, 11:08 AM
zack renamed T1223: identifiers.org URL resolution should support swh:id contextual parameters from Request from identifiers.org to add contextual params to swh-id to identifiers.org URL resolution should support swh:id contextual parameters.
Oct 3 2018, 10:04 AM · Metadata workflow
zack added a comment to T1223: identifiers.org URL resolution should support swh:id contextual parameters.

As far as I can tell from their documentation this cannot be made to work, because they only support http://identifiers.org/[collection]/[entity] as meta-syntax, and even use query strings for their profile stuff.

Oct 3 2018, 10:03 AM · Metadata workflow

Oct 2 2018

zack requested changes to D455: Provide Sphinx targets in docs/images/ (see D453)..

requesting changes discussed in D453#8780

Oct 2 2018, 4:54 PM
zack requested changes to D454: Provide Sphinx targets in docs/images/ (see D453)..

requesting changes discussed in D453#8780

Oct 2 2018, 4:54 PM
zack requested changes to D453: Make 'make' in swh-*/docs/ should run 'make' in swh-*/docs/images/.

updating diff status to match the current state of the discussion

Oct 2 2018, 4:53 PM
zack added a comment to T1225: webapp: The "getting started" page says to install npm, but it's not available in Debian 9..
$ curl -L https://npmjs.org/install.sh | sudo sh
Oct 2 2018, 4:02 PM · Documentation, Web app
zack added a comment to T1194: storage API server: nicer landing page.

This is now done.

Oct 2 2018, 10:55 AM · Storage manager
zack committed rDSTOf5dd8ac755b5: nicer landing page, pointing to homepage and API doc (authored by zack).
nicer landing page, pointing to homepage and API doc
Oct 2 2018, 10:55 AM
zack closed T1194: storage API server: nicer landing page as Resolved by committing rDSTOf5dd8ac755b5: nicer landing page, pointing to homepage and API doc.
Oct 2 2018, 10:55 AM · Storage manager

Oct 1 2018

zack triaged T1219: add tests to git loader as High priority.
Oct 1 2018, 7:40 PM · Sprint 2018 12, Git loader
zack raised the priority of T954: Add tests to loader-mercurial from Normal to High.

cc: @douardda , just because we discussed this today :)

Oct 1 2018, 7:39 PM · Mercurial loader
zack accepted D452: bundle20_loader: fix incorrect usage of MultiHash.from_data().

thanks!

Oct 1 2018, 7:36 PM
zack requested changes to D453: Make 'make' in swh-*/docs/ should run 'make' in swh-*/docs/images/.
Oct 1 2018, 7:34 PM
zack added a comment to D453: Make 'make' in swh-*/docs/ should run 'make' in swh-*/docs/images/.

Thanks, this was indeed a problem and this solution works.

Oct 1 2018, 7:34 PM
zack added reviewers for D452: bundle20_loader: fix incorrect usage of MultiHash.from_data(): Reviewers, ardumont.
Oct 1 2018, 5:19 PM
zack added a comment to T611: support for external definitions in the svn/subversion loader.

@zack Can you enlighten me as to why we want to store that information at the directory level (and not say at the revision one)?

Oct 1 2018, 4:58 PM · SVN Loader
zack added a comment to D451: Build and copy all images to swh-docs' build output..

So, the problem is that running "make" into swh-model/docs/ should also run "make" into swh-model/docs/images/, which currently isn't done. (And, symmetrically, make clean should also clean under images.)

Oct 1 2018, 4:50 PM
zack added a comment to D451: Build and copy all images to swh-docs' build output..
In D451#8735, @vlorentz wrote:
~/swh-environment/swh-docs/docs
make
Oct 1 2018, 4:38 PM
zack added a comment to D451: Build and copy all images to swh-docs' build output..

can you tell me how did you build?

Oct 1 2018, 4:34 PM
zack updated subscribers of D451: Build and copy all images to swh-docs' build output..

There is no CI building the doc for now (which is a problem per se, but that's a different debate :-)) However I did publish the doc myself ~1 hour ago.
I think what happened is that the last person who published the doc (I think @seirl ) didn't build the images locally and published that way, inducing the error you were seeing.
This is certainly proof that our publishing process for the doc is too flaky.
But on the other hand I don't think this diff is needed — the problem is elsewhere, e.g., doc build should fail rather than publish broken docs.

Oct 1 2018, 4:23 PM
zack requested changes to D451: Build and copy all images to swh-docs' build output..

Images like the one you mention are working on docs.s.o, see https://docs.softwareheritage.org/devel/swh-model/data-model.html#data-structure .
So I need some more context to understand this diff. Can you elaborate?

Oct 1 2018, 4:03 PM
zack committed rDSCH239bdec4762d: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 4:01 PM
zack committed rDOBJSb0ddd88299fa: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 4:01 PM
zack committed rDOBJS13645031e2eb: fix codespell typos (authored by zack).
fix codespell typos
Oct 1 2018, 4:01 PM
zack committed rDLDTAR245bd17530b0: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:58 PM
zack committed rDLDTARe97221efade5: README: fix typo (authored by zack).
README: fix typo
Oct 1 2018, 3:58 PM
zack committed rDLDPY70426eb61f0b: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:57 PM
zack committed rDWAPPS23e71a657a06: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:56 PM
zack added a reviewer for D449: Fix dependencies.: ardumont.
Oct 1 2018, 3:55 PM
zack edited reviewers for D451: Build and copy all images to swh-docs' build output., added: zack; removed: seirl.
Oct 1 2018, 3:55 PM
zack committed rDLDBASE0aae360c8fd0: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:53 PM
zack committed rDLS3d65b9f223c1: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:53 PM
zack committed rDLS0417c0c61a42: gitlab/models.py: drop unused import (authored by zack).
gitlab/models.py: drop unused import
Oct 1 2018, 3:53 PM
zack committed rDCIDXd09f5b4a7e63: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:52 PM
zack committed rDCIDX41d32347ab6f: fix typos (authored by zack).
fix typos
Oct 1 2018, 3:52 PM
zack committed rDDEP000ba80916b6: docs: fix typos (authored by zack).
docs: fix typos
Oct 1 2018, 3:51 PM
zack committed rDDEPf40cdfe62af7: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:51 PM
zack committed rDCORE32e58df63778: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:49 PM
zack committed rDARCcc612d497ecd: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:48 PM
zack committed rDVAU31b3d34ccc4f: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:48 PM
zack committed rDSTO84905b3b60aa: WIP (authored by zack).
WIP
Oct 1 2018, 3:48 PM
zack committed rDSTO306f547a35e2: SQL: drop obsolete indexes and functions related to occurrence tables (authored by zack).
SQL: drop obsolete indexes and functions related to occurrence tables
Oct 1 2018, 3:48 PM
zack committed rDSTOddb37a5896d0: revamp SQL schema: dropping occurrences and uniforming comments (authored by zack).
revamp SQL schema: dropping occurrences and uniforming comments
Oct 1 2018, 3:48 PM
zack closed D446: [WIP] storage: drop obsolete occurrences-related stuff.
Oct 1 2018, 3:48 PM
zack committed rDSTO003e1a746c20: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDTPLe99829360be5: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDMOD94c1a97bdc84: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDMIRFOR4444ad06561d: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDLDSVN8f1aa187a967: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDLDHG3dec1e1a2d2e: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDLDG0be6f89d2692: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDLDDIR7fdb5f43180e: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDLDDEB0afef371cb6b: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDJNL5f76e60f3436: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack committed rDDOC3e0f1b2cf939: docs: add title and brief module description (authored by zack).
docs: add title and brief module description
Oct 1 2018, 3:47 PM
zack removed hashtags from Staff: #software_heritage, #swh.
Oct 1 2018, 2:52 PM
zack added a member for Staff: mollydb.
Oct 1 2018, 2:47 PM
zack added a reviewer for D450: Update bin/pip-swh-packages to list requirement-test.txt: seirl.
Oct 1 2018, 2:35 PM

Sep 30 2018

zack triaged T1216: web app: demote timeline in favor of more browsable calendar as Low priority.
Sep 30 2018, 3:55 PM · Web app

Sep 28 2018

zack renamed T818: indexer DB should not use bytea for mimetype and encoding columns from Indexer mimetype: Use text instead of bytea for mimetype and encoding columns? to indexer DB should not use bytea for mimetype and encoding columns.
Sep 28 2018, 10:34 AM · Storage manager, Indexer

Sep 27 2018

zack added inline comments to D435: hashutil: Migrate towards MultiHash api.
Sep 27 2018, 1:48 PM
zack updated the summary of D446: [WIP] storage: drop obsolete occurrences-related stuff.
Sep 27 2018, 12:40 PM
zack added a comment to D446: [WIP] storage: drop obsolete occurrences-related stuff.
In D446#8588, @ardumont wrote:

You might already be working on that, but that's worth mentioning, there remains to:

  • check the indexes file (sql/swh-indexes.sql) to drop the releated indexes
Sep 27 2018, 12:11 PM
zack updated the diff for D446: [WIP] storage: drop obsolete occurrences-related stuff.
  • SQL: drop obsolete indexes and functions related to occurrence tables
Sep 27 2018, 12:10 PM
zack triaged T1212: git loader: add an option to force re-download/ingest everything as Normal priority.
Sep 27 2018, 11:39 AM · Git loader
zack assigned T1211: reingest missing early objects to olasd.
Sep 27 2018, 11:38 AM · Archive content
zack triaged T1211: reingest missing early objects as Normal priority.
Sep 27 2018, 11:36 AM · Archive content
Herald added a reviewer for D446: [WIP] storage: drop obsolete occurrences-related stuff: Reviewers.
Sep 27 2018, 10:13 AM

Sep 26 2018

zack accepted D443: docs/getting-started.md: Add missing runtime dependency.
Sep 26 2018, 11:10 AM
zack triaged T1210: web app: nearest date visit resolution failure as Low priority.
Sep 26 2018, 8:51 AM · Web app

Sep 25 2018

zack accepted D442: sql/bin/db-init: remove createuser and privileges (we now assume a peer superuser).
Sep 25 2018, 3:19 PM
zack added a comment to T704: beautify wiki URLs.

\o/

Sep 25 2018, 2:44 PM · Easy hack, System administration
zack requested changes to D440: sql/bin/db-init: simpler usage with sensible defaults.

Thanks, I liked the idea. I've only reported minor things here and there.

Sep 25 2018, 2:18 PM
zack accepted D440: sql/bin/db-init: simpler usage with sensible defaults.
Sep 25 2018, 2:18 PM
zack added inline comments to D440: sql/bin/db-init: simpler usage with sensible defaults.
Sep 25 2018, 2:18 PM
zack accepted D441: getting-started: use DB peer auth.

Thanks, this is indeed much simpler.

Sep 25 2018, 2:18 PM
zack added a reviewer for D441: getting-started: use DB peer auth: zack.
Sep 25 2018, 2:18 PM

Sep 23 2018

zack added a comment to D409: Use mercurial tags as named pointer (referenced in the snapshot).

I'm not sure why the status of this diff is abandoned, but I'm picking up the discussion on whether the mercurial loader should create release objects because it started here.
Since we last exchanged here, we also exchanged f2f, so rather than picking up all the sub-thread I'm focusing on the main points.

Sep 23 2018, 4:48 PM
zack renamed T1209: web app: empty lines in text files displayed as "{1}" from empty lines displayed as "{1}" to web app: empty lines in text files displayed as "{1}".
Sep 23 2018, 8:10 AM · Web app
zack triaged T1209: web app: empty lines in text files displayed as "{1}" as Normal priority.

definitely a bug, thanks for reporting!

Sep 23 2018, 8:10 AM · Web app

Sep 22 2018

zack added a comment to T1208: Review / extend web app robots.txt.

for comparison:

Sep 22 2018, 2:53 PM · Web app
zack added a comment to T1208: Review / extend web app robots.txt.

being crawled along million-revision VCS histories doesn't sound particularly appealing :-)

Sep 22 2018, 2:52 PM · Web app
zack added a comment to T1207: Enhance web app behavior when encountering snapshots with a large number of branches.

in terms of UX, I think this should do something like:

  • show the default branch (HEAD) if no explicit branch has been requested, some branches (according to whatever pagination is implemented by the back-end) and tell the user "sorry, this snapshot has too many branches to be shown…". GitHub does something similar for very large dirs, and it's totally fine. (BTW, do we have something similar for very large dirs? we should!)
  • if an explicit branch has been requested, show that one instead of the default one, and do as above for everything else
Sep 22 2018, 2:51 PM · Web app
zack added a comment to T1161: SVN loader: Create local dump of remote repository to speed up loading task.

FWIW, this is my main worry about this approach.

Sep 22 2018, 12:12 PM · SVN Loader

Sep 20 2018

zack added a comment to T1204: webapp/browse: Share search query to the world.

+1

Sep 20 2018, 11:21 AM · Web app
zack committed rDDOCf615d154acd6: getting started: make language more consistent around packages/modules (authored by zack).
getting started: make language more consistent around packages/modules
Sep 20 2018, 10:15 AM
zack committed rDDOC02977fb6e36b: getting started: better section titles (authored by zack).
getting started: better section titles
Sep 20 2018, 10:12 AM
zack committed rDDOC5acfd929f2e9: getting_started: install swh packages in a virtualenv (authored by seirl).
getting_started: install swh packages in a virtualenv
Sep 20 2018, 10:12 AM