[WIP] storage: drop obsolete occurrences-related stuff
ClosedPublic
Actions

Authored by zack on Sep 27 2018, 10:13 AM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDSTO306f547a35e2: SQL: drop obsolete indexes and functions related to occurrence tables
rDSTOddb37a5896d0: revamp SQL schema: dropping occurrences and uniforming comments

Summary

Goal is to remove obsolete occurrence-related tables and dependent objects (indexes, functions, storage endpoints, etc.).

While at it, I'm also taking the chance of uniforming style and messages in the SQL definitions, but those changes will be committed separately.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

zack created this revision.Sep 27 2018, 10:13 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 27 2018, 10:13 AM

Harbormaster completed remote builds in B1450: Diff 1367.Sep 27 2018, 10:13 AM

Sounds right.

You might already be working on that, but that's worth mentioning, there remains to:

check the indexes file (sql/swh-indexes.sql) to drop the related indexes
add the migration script sql/upgrades/121.sql which adds the equivalent drop instructions.

Cheers,

SQL: drop obsolete indexes and functions related to occurrence tables

Harbormaster completed remote builds in B1453: Diff 1372.Sep 27 2018, 12:10 PM

In D446#8588, @ardumont wrote:

You might already be working on that, but that's worth mentioning, there remains to:

check the indexes file (sql/swh-indexes.sql) to drop the releated indexes

Nice catch. I didn't look outside swh-schema.sql, but there was indeed dangling stuff elsewhere: indexes, but also functions…
Diff updated

add the migration script sql/upgrades/121.sql which adds the equivalent drop instructions.

bin/db-upgrade now fails with a Java traceback :-(

zack retitled this revision from revamp SQL schema: dropping occurrences and uniforming comments to [WIP] storage: drop obsolete occurrences-related stuff.Sep 27 2018, 12:40 PM

zack edited the summary of this revision. (Show Details)

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2018, 3:47 PM

Closed by commit rDSTOddb37a5896d0: revamp SQL schema: dropping occurrences and uniforming comments (authored by zack). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sql/

swh-schema.sql

171 lines

Diff 1391

View Options

[WIP] storage: drop obsolete occurrences-related stuffClosedPublicActions