Page MenuHomeSoftware Heritage

add tests to git loader
Closed, ResolvedPublic

Description

as per title: the Git loader is a key component of our in-production toolchain, we should really have tests around at least its basic ingestion logic

Event Timeline

zack created this task.Oct 1 2018, 7:40 PM
zack triaged this task as High priority.
vlorentz claimed this task.Oct 30 2018, 3:14 PM
vlorentz closed this task as Resolved.Nov 9 2018, 1:45 PM

Resolved by D622.

zack added a comment.Nov 9 2018, 1:48 PM

Resolved by D622.

Based on https://jenkins.softwareheritage.org/view/swh%20master/job/DLDG/job/tests/5/cobertura/loader_git/ I'd argue that tests has been added to the loader part of git-loader, but not to the updater part of it, which is what is used mostly in production (yes, it's an historical misnomer, and I really wish that the two could be merged, but that's unrelated to T1219…).

So either we keep this task open as WIP status, or we add a new dedicated one to keep track that the git "updater" needs tests.

vlorentz reopened this task as Open.Nov 9 2018, 5:49 PM
ardumont changed the task status from Open to Work in Progress.
ardumont added a project: Sprint 2018 12.
ardumont moved this task from Backlog to in progress on the Sprint 2018 12 board.
ardumont added a subscriber: vlorentz.
ardumont closed this task as Resolved.Dec 17 2018, 1:55 PM

Up to 85% now.

ardumont moved this task from in progress to done on the Sprint 2018 12 board.Dec 17 2018, 1:56 PM
ardumont moved this task from done to deployed on the Sprint 2018 12 board.
ardumont raised the priority of this task from High to Needs Triage.