as per title: the Git loader is a key component of our in-production toolchain, we should really have tests around at least its basic ingestion logic
|Work in Progress||None||T1411 reach a minimum of 80% SLOC coverage across all components|
|Resolved||ardumont||T1219 add tests to git loader|
- Mentioned In
- rDLDG5c274a582e2c: converters: Add missing edge case test scenario
D833: Add coverage to swh-loader-git repository
rDLDG65f740c8a13c: loader.git.reader: Remove unused code
D831: loader.git.reader: Remove unused code
rDLDGc7bf9e26f88c: Run git loader tests on BulkUpdater too.
rDLDGcaf409fb67a5: New tests for the Git loader.
- Mentioned Here
- D622: New tests for the Git loader.
Based on https://jenkins.softwareheritage.org/view/swh%20master/job/DLDG/job/tests/5/cobertura/loader_git/ I'd argue that tests has been added to the loader part of git-loader, but not to the updater part of it, which is what is used mostly in production (yes, it's an historical misnomer, and I really wish that the two could be merged, but that's unrelated to T1219…).
So either we keep this task open as WIP status, or we add a new dedicated one to keep track that the git "updater" needs tests.