add tests to git loader
Closed, MigratedEdits Locked
Actions

Assigned To

Authored By

	zack
	Oct 1 2018, 7:40 PM

Description

as per title: the Git loader is a key component of our in-production toolchain, we should really have tests around at least its basic ingestion logic

rDLDG Git loader
	Closed	D665 Run git loader tests on BulkUpdater too.
	Closed	D622 New tests for the Git loader.

		Status	Assigned	Task
		Migrated	gitlab-migration	T1411 reach a minimum of 80% SLOC coverage across all components
		Migrated	gitlab-migration	T1219 add tests to git loader

zack triaged this task as High priority.Oct 1 2018, 7:40 PM

zack created this task.

Resolved by D622.

In T1219#24586, @vlorentz wrote:

Resolved by D622.

Based on https://jenkins.softwareheritage.org/view/swh%20master/job/DLDG/job/tests/5/cobertura/loader_git/ I'd argue that tests has been added to the loader part of git-loader, but not to the updater part of it, which is what is used mostly in production (yes, it's an historical misnomer, and I really wish that the two could be merged, but that's unrelated to T1219…).

So either we keep this task open as WIP status, or we add a new dedicated one to keep track that the git "updater" needs tests.

vlorentz reopened this task as Open.Nov 9 2018, 5:49 PM

ardumont changed the task status from Open to Work in Progress.Dec 17 2018, 12:01 PM

ardumont claimed this task.

ardumont moved this task from Backlog to in progress on the Sprint 2018 12 board.

ardumont added a subscriber: vlorentz.