Page MenuHomeSoftware Heritage

lewo (Antoine Eiche)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2019, 9:45 AM (55 w, 5 d)

Recent Activity

Thu, Aug 27

lewo added a comment to T2430: lookup ingested tarballs (or similar source code containers) by container checksum.

@samplet wow! that's pretty cool! Thank you ;)

Thu, Aug 27, 10:28 PM · Data Model

Aug 2 2020

lewo added a comment to T2510: nixguix: Filter out unsupported artifacts from ingestion.

I'm currently using the following regex to filter the exposed urls .tar.gz$|.zip$|tar.bz2$|.tbz$|.tar.xz$|.tgz$|.tar$ but I'm pretty sure it could be improved.

Aug 2 2020, 9:27 PM · Package Loader

Jun 17 2020

lewo added a comment to T1352: ingest Guix (SD) packages.

@zack

We need a name for this origin type, one of the hardest problem in CS :-)

Where is it used? Is it a new attribute?
We actually had to choose a name for the visit type, and with a lot of inspiration, we choose nixguix :-/

Jun 17 2020, 3:15 PM · Archive coverage
lewo added a comment to T1352: ingest Guix (SD) packages.

@zimoun

Do you mean filter the unsupported urls for the field "urls" in the "type": "url"?
Or do you mean only export "type": "url" and remove all the other types from 'sources.json', for instance "git"?

Jun 17 2020, 3:13 PM · Archive coverage

Jun 15 2020

lewo updated subscribers of T1352: ingest Guix (SD) packages.

The nixguix loader is working well since 2 weeks on the nixpkgs sources.json file!
So, we can now consider the sources.json file format as stable and you could make the required changes on your sources.json file. A new SHW origin should then be added.

Jun 15 2020, 5:53 PM · Archive coverage

Jun 5 2020

lewo updated the diff for D2958: client: support optional date in Revision and Release.

Fix ardumont comment and rebase

Jun 5 2020, 9:59 AM

Jun 2 2020

lewo created T2430: lookup ingested tarballs (or similar source code containers) by container checksum.
Jun 2 2020, 7:03 PM · Data Model

May 27 2020

lewo created T2426: Remove date popups on the visit page when cursor doesn't point it anymore .
May 27 2020, 10:36 AM · Web app

May 25 2020

lewo added a comment to D3178: nixguix: Override known_artifacts to filter out evaluation branch.

I'm wondering if we should not catch the exception on a missing metadatas instead. It is much more simple and I think we could have more branches like the evaluation one in the future. If we add git sources, the git loader will be in charge of loading the source and the nixguix loader will still add a pending branch to the snapshot.

May 25 2020, 7:25 PM
lewo added inline comments to D2949: nixguix: catch and log artifact resolution failures.
May 25 2020, 5:33 PM · Package Loader
lewo added inline comments to D2949: nixguix: catch and log artifact resolution failures.
May 25 2020, 12:08 PM · Package Loader

May 14 2020

lewo added a comment to D2025: [wip] swh.lister.functionalPackages: add lister getting sources from a JSON file.

What's the status of this patch series? Would be great to deploy it. :-)

May 14 2020, 10:43 AM · Lister

Apr 29 2020

lewo committed rDWCLI6bb36697bea8: client: add `visits` method to get the list of an origin visits (authored by lewo).
client: add `visits` method to get the list of an origin visits
Apr 29 2020, 4:43 PM
lewo closed D2881: client: add `visits` method to get the list of an origin visits.
Apr 29 2020, 4:43 PM
lewo updated the diff for D2881: client: add `visits` method to get the list of an origin visits.

Rebased

Apr 29 2020, 4:37 PM

Apr 15 2020

lewo updated the diff for D2881: client: add `visits` method to get the list of an origin visits.

Rebased

Apr 15 2020, 10:40 AM

Apr 3 2020

lewo updated the diff for D2958: client: support optional date in Revision and Release.

Fix flake8

Apr 3 2020, 5:01 PM
lewo created D2958: client: support optional date in Revision and Release.
Apr 3 2020, 4:50 PM
lewo committed rDLDBASE592156740883: nixguix: validate and clean sources.json structure (authored by lewo).
nixguix: validate and clean sources.json structure
Apr 3 2020, 3:30 PM
lewo closed D2951: nixguix: validate and clean sources.json structure.
Apr 3 2020, 3:30 PM
lewo added inline comments to D2951: nixguix: validate and clean sources.json structure.
Apr 3 2020, 3:23 PM
lewo updated the diff for D2951: nixguix: validate and clean sources.json structure.

Addressed @ardumont comments. Thanks for your review!

Apr 3 2020, 3:23 PM
lewo created D2951: nixguix: validate and clean sources.json structure.
Apr 3 2020, 10:38 AM

Apr 2 2020

lewo updated the diff for D2881: client: add `visits` method to get the list of an origin visits.

Thanks @zack @ardumont. I addressed your comments.

Apr 2 2020, 6:23 PM
lewo updated the diff for D2881: client: add `visits` method to get the list of an origin visits.

@olasd I addressed all of your comments. Thanks for your review.

Apr 2 2020, 3:13 PM
lewo committed rDLDBASE78aa3e1c5088: nixguix: rename the test file (authored by lewo).
nixguix: rename the test file
Apr 2 2020, 12:00 PM
lewo committed rDLDBASEfbf457e92cbd: nixguix: rename the `url` source attribute to `urls` (authored by lewo).
nixguix: rename the `url` source attribute to `urls`
Apr 2 2020, 12:00 PM
lewo closed D2944: nixguix: small refactoring.
Apr 2 2020, 12:00 PM
lewo added a comment to D2944: nixguix: small refactoring.

Thanks!

Apr 2 2020, 12:00 PM
lewo created D2944: nixguix: small refactoring.
Apr 2 2020, 11:31 AM
lewo committed rDLDBASE0ff6cdedf0fc: nixguix: add the integrity attribute in release metadata (authored by lewo).
nixguix: add the integrity attribute in release metadata
Apr 2 2020, 10:41 AM
lewo closed D2907: nixguix: use the integrity attribute as snapshot branch name.
Apr 2 2020, 10:41 AM

Mar 31 2020

lewo added inline comments to D2907: nixguix: use the integrity attribute as snapshot branch name.
Mar 31 2020, 12:12 PM
lewo updated the diff for D2907: nixguix: use the integrity attribute as snapshot branch name.

Remove the second loader instanciation in test_loader_incremental.

Mar 31 2020, 12:00 PM

Mar 30 2020

lewo added a comment to D2907: nixguix: use the integrity attribute as snapshot branch name.

@olasd Another drawback is I would need to make one API call per release in order to list all integrity attributes of a snapshot. Even with a cache on the client side, the first run would require ~15000 calls to the SWH API. Do you have a rate limiting on these API endpoints?

Mar 30 2020, 3:21 PM
lewo updated the diff for D2907: nixguix: use the integrity attribute as snapshot branch name.

Reduce commit diff :/

Mar 30 2020, 12:40 PM
lewo updated the diff for D2907: nixguix: use the integrity attribute as snapshot branch name.

No longer use the integrity as branch name but the url instead.

Mar 30 2020, 12:36 PM
lewo added a comment to D2907: nixguix: use the integrity attribute as snapshot branch name.

Thanks for your review. I'm applying your suggestion which looks nice.

Mar 30 2020, 12:10 PM

Mar 27 2020

lewo updated the diff for D2907: nixguix: use the integrity attribute as snapshot branch name.
  • nixguix: rename the test file
Mar 27 2020, 4:38 PM
lewo added a reviewer for D2907: nixguix: use the integrity attribute as snapshot branch name: ardumont.
Mar 27 2020, 3:53 PM
lewo created D2907: nixguix: use the integrity attribute as snapshot branch name.
Mar 27 2020, 3:52 PM

Mar 25 2020

lewo committed rDLDBASE3d944664adab: Rename the functional loader to nixguix loader (authored by lewo).
Rename the functional loader to nixguix loader
Mar 25 2020, 6:11 PM
lewo closed D2875: Rename the functional loader to nixguix loader.
Mar 25 2020, 6:11 PM
lewo created D2881: client: add `visits` method to get the list of an origin visits.
Mar 25 2020, 6:07 PM
lewo added a comment to D2875: Rename the functional loader to nixguix loader.

I don't know if nix_guix would be better than nixguix for the module name!

Mar 25 2020, 11:42 AM
lewo created D2875: Rename the functional loader to nixguix loader.
Mar 25 2020, 11:41 AM

Mar 24 2020

lewo created T2334: Manage failing SSL requests.
Mar 24 2020, 3:52 PM · Core Loader
lewo created T2333: Use non-url identifiers for origin url attribute .
Mar 24 2020, 12:26 PM · Archive content

Mar 23 2020

lewo committed rDLDBASEd1f35f5231a9: package.loader: add a test to reproduce EOFError error (authored by lewo).
package.loader: add a test to reproduce EOFError error
Mar 23 2020, 3:43 PM
lewo closed D2859: package.loader: catch the EOFError exception in uncompress function.
Mar 23 2020, 3:43 PM
lewo updated the diff for D2859: package.loader: catch the EOFError exception in uncompress function.

UPdate cmomit message to only mention the test

Mar 23 2020, 2:22 PM
lewo updated the diff for D2859: package.loader: catch the EOFError exception in uncompress function.

Rebased

Mar 23 2020, 2:21 PM
lewo added inline comments to D2862: Make the swh.loader.package exception handling more granular.
Mar 23 2020, 11:48 AM
lewo added a comment to D2859: package.loader: catch the EOFError exception in uncompress function.

What about this diff? I think it's still valuable since it catch more precisely errors and add a test case;)
WDYT?

Mar 23 2020, 10:44 AM

Mar 20 2020

lewo updated the diff for D2859: package.loader: catch the EOFError exception in uncompress function.

Fix a typo

Mar 20 2020, 4:15 PM
lewo updated the diff for D2859: package.loader: catch the EOFError exception in uncompress function.

I added a test for the EOFError.

Mar 20 2020, 4:13 PM
lewo added a comment to D2859: package.loader: catch the EOFError exception in uncompress function.

I actually succeeded with a bigger truncated file actually: 70KB

Mar 20 2020, 3:27 PM
lewo added a comment to D2859: package.loader: catch the EOFError exception in uncompress function.

Did you try truncating a .tar file to reproduce the issue?

Mar 20 2020, 3:21 PM
lewo added inline comments to D2860: package.loader: Reference a snapshot on partial visit.
Mar 20 2020, 2:46 PM
lewo updated subscribers of D2859: package.loader: catch the EOFError exception in uncompress function.
Mar 20 2020, 11:29 AM
lewo created D2859: package.loader: catch the EOFError exception in uncompress function.
Mar 20 2020, 11:29 AM
lewo committed rDLDBASE4333581e2cd5: package.loader: add extra_branches method (authored by lewo).
package.loader: add extra_branches method
Mar 20 2020, 9:30 AM
lewo committed rDLDBASEd8ad6f3c2e41: functional: create a branch named evaluation pointing to the evaluation commit (authored by lewo).
functional: create a branch named evaluation pointing to the evaluation commit
Mar 20 2020, 9:30 AM
lewo closed D2807: functional.loader: add a pointer to the eval revision.
Mar 20 2020, 9:30 AM

Mar 19 2020

lewo planned changes to D2854: [wip] package.loader: introduce load_target and resolve_target_from.

@ardumont I don't understand why the storage doesn't contains 2 contents (a tarball + a file). The test test_loader_one_visit is failing because there is only 1 content in the storage.

Mar 19 2020, 11:24 AM
lewo updated the diff for D2854: [wip] package.loader: introduce load_target and resolve_target_from.
  • WIP
Mar 19 2020, 11:21 AM
lewo updated the task description for T1991: Implement a Guix/Nix loader.
Mar 19 2020, 11:09 AM · Package Loader
lewo updated the summary of D2854: [wip] package.loader: introduce load_target and resolve_target_from.
Mar 19 2020, 10:52 AM
lewo created D2854: [wip] package.loader: introduce load_target and resolve_target_from.
Mar 19 2020, 10:51 AM
lewo updated the diff for D2793: Use /usr/bin/env bash instead of /bin/bash.

Rebased on master

Mar 19 2020, 9:53 AM

Mar 18 2020

lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 18 2020, 3:07 PM
lewo added inline comments to D2807: functional.loader: add a pointer to the eval revision.
Mar 18 2020, 3:02 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: add extra_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 18 2020, 3:01 PM
lewo committed rDLDBASE03d7dbf69279: Add the functional loader (authored by lewo).
Add the functional loader
Mar 18 2020, 11:11 AM
lewo committed rDLDBASE09373d23b2fe: package.loader: ignore non tarball source (authored by lewo).
package.loader: ignore non tarball source
Mar 18 2020, 11:11 AM
lewo closed D2792: Functional Package Loader.
Mar 18 2020, 11:11 AM

Mar 17 2020

lewo added a comment to D2792: Functional Package Loader.

@olasd Thanks for your comments. I addressed all of them.

Mar 17 2020, 2:55 PM
lewo updated the diff for D2792: Functional Package Loader.
  • Add the functional loader
Mar 17 2020, 2:54 PM
lewo added a comment to D2792: Functional Package Loader.

I'm not so sure about refactoring the base package loader to have two url and origin arguments that are the same most of the time but not all the time; In concrete terms, this means that we should refactor all loaders to use self.origin in the places where they currently use self.url.

For instance, we have the same issue with the pypi loader, where we generate an api url (which we're downloading) from the url of the origin (which is just a user-facing link).

All in all, I think we need to think about doing a refactoring to do this consistently, but I don't think this diff is the right place to do this refactoring; For now, we can just have a hardcoded map from origin url to index url.

Mar 17 2020, 2:44 PM

Mar 16 2020

lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: add extra_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 16 2020, 7:10 PM
lewo added a comment to D2792: Functional Package Loader.

@ardumont I squashed almost all commits and added a task test.

Mar 16 2020, 7:07 PM
lewo updated the diff for D2792: Functional Package Loader.
  • Add the functional loader
Mar 16 2020, 6:41 PM
lewo added a comment to D2792: Functional Package Loader.

I think I need to implement a test for the task also. WDYT?

Mar 16 2020, 5:34 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: add extra_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 16 2020, 5:25 PM
lewo updated the diff for D2792: Functional Package Loader.
  • package.loader: ignore non tarball source
  • package.loader: add origin argument
  • Add the functional loader
  • cli: add the functional loader in the cli tests
  • functional: add test for non json sources files
  • functional: improve test_loader_two_visits
  • functional: add test_loader_incremental
  • functional: move retrieve_sources out of the FunctionalLoader class
  • functional: test the origin_visit
  • functional: add test_uncompress_failure
  • functional: minor fixes in tests
Mar 16 2020, 5:13 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: add extra_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 16 2020, 5:03 PM

Mar 13 2020

lewo added inline comments to D2792: Functional Package Loader.
Mar 13 2020, 11:58 PM
lewo updated the diff for D2792: Functional Package Loader.
  • package.loader: add origin argument
  • Add the functional loader
  • cli: add the functional loader in the cli tests
  • functional: add test for non json sources files
  • functional: improve test_loader_two_visits
  • functional: add test_loader_incremental
  • functional: move retrieve_sources out of the FunctionalLoader class
  • functional: test the origin_visit
  • functional: add test_uncompress_failure
  • functional: minor fixes in tests
Mar 13 2020, 11:58 PM
lewo added a comment to D2792: Functional Package Loader.

So here, i'm missing:

  • loading scenario which test the incremental nature of the visit (that'd test resolve_revision_from)
Mar 13 2020, 5:16 PM
lewo updated the diff for D2792: Functional Package Loader.
  • functional: improve test_loader_two_visits
  • functional: add test_loader_incremental
  • functional: move retrieve_sources out of the FunctionalLoader class
  • functional: test the origin_visit
  • functional: add test_uncompress_failure
Mar 13 2020, 5:14 PM
lewo added a comment to D2025: [wip] swh.lister.functionalPackages: add lister getting sources from a JSON file.

@civodul @zimoun I'm wondering if you generate a sources.json file for any commit of your guix repository or only for those that have been evaluated and pushed to your binary cache by your CI?

Mar 13 2020, 10:36 AM · Lister

Mar 12 2020

lewo created P614 nixpkgs sources.json overview.
Mar 12 2020, 3:59 PM
lewo added a comment to D2792: Functional Package Loader.

I actually don't know how should I manage errors. It seems exception are generally just emitted, without a dedicated log message.
How do you catch errors on production?

Mar 12 2020, 3:12 PM
lewo updated the diff for D2792: Functional Package Loader.
  • functional: add test for non json sources files
Mar 12 2020, 3:06 PM
lewo planned changes to D2807: functional.loader: add a pointer to the eval revision.
Mar 12 2020, 9:38 AM

Mar 11 2020

lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.

Try to base on functional-loader branch

Mar 11 2020, 3:46 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 11 2020, 3:32 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 11 2020, 3:31 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: ignore non tarball source
  • package.loader: add origin argument
  • Add the functional loader
  • cli: add the functional loader in the cli tests
  • package.loader: add hook_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 11 2020, 3:19 PM
lewo retitled D2792: Functional Package Loader from wip: Functional Package Loader to Functional Package Loader.
Mar 11 2020, 3:00 PM