Page MenuHomeSoftware Heritage

lewo (Antoine Eiche)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2019, 9:45 AM (31 w, 4 d)

Recent Activity

Fri, Apr 3

lewo updated the diff for D2958: client: support optional date in Revision and Release.

Fix flake8

Fri, Apr 3, 5:01 PM
lewo created D2958: client: support optional date in Revision and Release.
Fri, Apr 3, 4:50 PM
lewo committed rDLDBASE592156740883: nixguix: validate and clean sources.json structure (authored by lewo).
nixguix: validate and clean sources.json structure
Fri, Apr 3, 3:30 PM
lewo closed D2951: nixguix: validate and clean sources.json structure.
Fri, Apr 3, 3:30 PM
lewo added inline comments to D2951: nixguix: validate and clean sources.json structure.
Fri, Apr 3, 3:23 PM
lewo updated the diff for D2951: nixguix: validate and clean sources.json structure.

Addressed @ardumont comments. Thanks for your review!

Fri, Apr 3, 3:23 PM
lewo created D2951: nixguix: validate and clean sources.json structure.
Fri, Apr 3, 10:38 AM

Thu, Apr 2

lewo updated the diff for D2881: client: add `visits` method to get the list of an origin visits.

Thanks @zack @ardumont. I addressed your comments.

Thu, Apr 2, 6:23 PM
lewo updated the diff for D2881: client: add `visits` method to get the list of an origin visits.

@olasd I addressed all of your comments. Thanks for your review.

Thu, Apr 2, 3:13 PM
lewo committed rDLDBASE78aa3e1c5088: nixguix: rename the test file (authored by lewo).
nixguix: rename the test file
Thu, Apr 2, 12:00 PM
lewo committed rDLDBASEfbf457e92cbd: nixguix: rename the `url` source attribute to `urls` (authored by lewo).
nixguix: rename the `url` source attribute to `urls`
Thu, Apr 2, 12:00 PM
lewo closed D2944: nixguix: small refactoring.
Thu, Apr 2, 12:00 PM
lewo added a comment to D2944: nixguix: small refactoring.

Thanks!

Thu, Apr 2, 12:00 PM
lewo created D2944: nixguix: small refactoring.
Thu, Apr 2, 11:31 AM
lewo committed rDLDBASE0ff6cdedf0fc: nixguix: add the integrity attribute in release metadata (authored by lewo).
nixguix: add the integrity attribute in release metadata
Thu, Apr 2, 10:41 AM
lewo closed D2907: nixguix: use the integrity attribute as snapshot branch name.
Thu, Apr 2, 10:41 AM

Tue, Mar 31

lewo added inline comments to D2907: nixguix: use the integrity attribute as snapshot branch name.
Tue, Mar 31, 12:12 PM
lewo updated the diff for D2907: nixguix: use the integrity attribute as snapshot branch name.

Remove the second loader instanciation in test_loader_incremental.

Tue, Mar 31, 12:00 PM

Mon, Mar 30

lewo added a comment to D2907: nixguix: use the integrity attribute as snapshot branch name.

@olasd Another drawback is I would need to make one API call per release in order to list all integrity attributes of a snapshot. Even with a cache on the client side, the first run would require ~15000 calls to the SWH API. Do you have a rate limiting on these API endpoints?

Mon, Mar 30, 3:21 PM
lewo updated the diff for D2907: nixguix: use the integrity attribute as snapshot branch name.

Reduce commit diff :/

Mon, Mar 30, 12:40 PM
lewo updated the diff for D2907: nixguix: use the integrity attribute as snapshot branch name.

No longer use the integrity as branch name but the url instead.

Mon, Mar 30, 12:36 PM
lewo added a comment to D2907: nixguix: use the integrity attribute as snapshot branch name.

Thanks for your review. I'm applying your suggestion which looks nice.

Mon, Mar 30, 12:10 PM

Fri, Mar 27

lewo updated the diff for D2907: nixguix: use the integrity attribute as snapshot branch name.
  • nixguix: rename the test file
Fri, Mar 27, 4:38 PM
lewo added a reviewer for D2907: nixguix: use the integrity attribute as snapshot branch name: ardumont.
Fri, Mar 27, 3:53 PM
lewo created D2907: nixguix: use the integrity attribute as snapshot branch name.
Fri, Mar 27, 3:52 PM

Wed, Mar 25

lewo committed rDLDBASE3d944664adab: Rename the functional loader to nixguix loader (authored by lewo).
Rename the functional loader to nixguix loader
Wed, Mar 25, 6:11 PM
lewo closed D2875: Rename the functional loader to nixguix loader.
Wed, Mar 25, 6:11 PM
lewo created D2881: client: add `visits` method to get the list of an origin visits.
Wed, Mar 25, 6:07 PM
lewo added a comment to D2875: Rename the functional loader to nixguix loader.

I don't know if nix_guix would be better than nixguix for the module name!

Wed, Mar 25, 11:42 AM
lewo created D2875: Rename the functional loader to nixguix loader.
Wed, Mar 25, 11:41 AM

Tue, Mar 24

lewo created T2334: Manage failing SSL requests.
Tue, Mar 24, 3:52 PM · Core Loader
lewo created T2333: Use non-url identifiers for origin url attribute .
Tue, Mar 24, 12:26 PM · Archive content

Mon, Mar 23

lewo committed rDLDBASEd1f35f5231a9: package.loader: add a test to reproduce EOFError error (authored by lewo).
package.loader: add a test to reproduce EOFError error
Mon, Mar 23, 3:43 PM
lewo closed D2859: package.loader: catch the EOFError exception in uncompress function.
Mon, Mar 23, 3:43 PM
lewo updated the diff for D2859: package.loader: catch the EOFError exception in uncompress function.

UPdate cmomit message to only mention the test

Mon, Mar 23, 2:22 PM
lewo updated the diff for D2859: package.loader: catch the EOFError exception in uncompress function.

Rebased

Mon, Mar 23, 2:21 PM
lewo added inline comments to D2862: Make the swh.loader.package exception handling more granular.
Mon, Mar 23, 11:48 AM
lewo added a comment to D2859: package.loader: catch the EOFError exception in uncompress function.

What about this diff? I think it's still valuable since it catch more precisely errors and add a test case;)
WDYT?

Mon, Mar 23, 10:44 AM

Fri, Mar 20

lewo updated the diff for D2859: package.loader: catch the EOFError exception in uncompress function.

Fix a typo

Fri, Mar 20, 4:15 PM
lewo updated the diff for D2859: package.loader: catch the EOFError exception in uncompress function.

I added a test for the EOFError.

Fri, Mar 20, 4:13 PM
lewo added a comment to D2859: package.loader: catch the EOFError exception in uncompress function.

I actually succeeded with a bigger truncated file actually: 70KB

Fri, Mar 20, 3:27 PM
lewo added a comment to D2859: package.loader: catch the EOFError exception in uncompress function.

Did you try truncating a .tar file to reproduce the issue?

Fri, Mar 20, 3:21 PM
lewo added inline comments to D2860: package.loader: Reference a snapshot on partial visit.
Fri, Mar 20, 2:46 PM
lewo updated subscribers of D2859: package.loader: catch the EOFError exception in uncompress function.
Fri, Mar 20, 11:29 AM
lewo created D2859: package.loader: catch the EOFError exception in uncompress function.
Fri, Mar 20, 11:29 AM
lewo committed rDLDBASE4333581e2cd5: package.loader: add extra_branches method (authored by lewo).
package.loader: add extra_branches method
Fri, Mar 20, 9:30 AM
lewo committed rDLDBASEd8ad6f3c2e41: functional: create a branch named evaluation pointing to the evaluation commit (authored by lewo).
functional: create a branch named evaluation pointing to the evaluation commit
Fri, Mar 20, 9:30 AM
lewo closed D2807: functional.loader: add a pointer to the eval revision.
Fri, Mar 20, 9:30 AM

Thu, Mar 19

lewo planned changes to D2854: [wip] package.loader: introduce load_target and resolve_target_from.

@ardumont I don't understand why the storage doesn't contains 2 contents (a tarball + a file). The test test_loader_one_visit is failing because there is only 1 content in the storage.

Thu, Mar 19, 11:24 AM
lewo updated the diff for D2854: [wip] package.loader: introduce load_target and resolve_target_from.
  • WIP
Thu, Mar 19, 11:21 AM
lewo updated the task description for T1991: Implement a Guix/Nix loader.
Thu, Mar 19, 11:09 AM · Core Loader, Lister
lewo updated the summary of D2854: [wip] package.loader: introduce load_target and resolve_target_from.
Thu, Mar 19, 10:52 AM
lewo created D2854: [wip] package.loader: introduce load_target and resolve_target_from.
Thu, Mar 19, 10:51 AM
lewo updated the diff for D2793: Use /usr/bin/env bash instead of /bin/bash.

Rebased on master

Thu, Mar 19, 9:53 AM

Wed, Mar 18

lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • functional: create a branch named evaluation pointing to the evaluation commit
Wed, Mar 18, 3:07 PM
lewo added inline comments to D2807: functional.loader: add a pointer to the eval revision.
Wed, Mar 18, 3:02 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: add extra_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Wed, Mar 18, 3:01 PM
lewo committed rDLDBASE03d7dbf69279: Add the functional loader (authored by lewo).
Add the functional loader
Wed, Mar 18, 11:11 AM
lewo committed rDLDBASE09373d23b2fe: package.loader: ignore non tarball source (authored by lewo).
package.loader: ignore non tarball source
Wed, Mar 18, 11:11 AM
lewo closed D2792: Functional Package Loader.
Wed, Mar 18, 11:11 AM

Tue, Mar 17

lewo added a comment to D2792: Functional Package Loader.

@olasd Thanks for your comments. I addressed all of them.

Tue, Mar 17, 2:55 PM
lewo updated the diff for D2792: Functional Package Loader.
  • Add the functional loader
Tue, Mar 17, 2:54 PM
lewo added a comment to D2792: Functional Package Loader.

I'm not so sure about refactoring the base package loader to have two url and origin arguments that are the same most of the time but not all the time; In concrete terms, this means that we should refactor all loaders to use self.origin in the places where they currently use self.url.

For instance, we have the same issue with the pypi loader, where we generate an api url (which we're downloading) from the url of the origin (which is just a user-facing link).

All in all, I think we need to think about doing a refactoring to do this consistently, but I don't think this diff is the right place to do this refactoring; For now, we can just have a hardcoded map from origin url to index url.

Tue, Mar 17, 2:44 PM

Mon, Mar 16

lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: add extra_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mon, Mar 16, 7:10 PM
lewo added a comment to D2792: Functional Package Loader.

@ardumont I squashed almost all commits and added a task test.

Mon, Mar 16, 7:07 PM
lewo updated the diff for D2792: Functional Package Loader.
  • Add the functional loader
Mon, Mar 16, 6:41 PM
lewo added a comment to D2792: Functional Package Loader.

I think I need to implement a test for the task also. WDYT?

Mon, Mar 16, 5:34 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: add extra_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mon, Mar 16, 5:25 PM
lewo updated the diff for D2792: Functional Package Loader.
  • package.loader: ignore non tarball source
  • package.loader: add origin argument
  • Add the functional loader
  • cli: add the functional loader in the cli tests
  • functional: add test for non json sources files
  • functional: improve test_loader_two_visits
  • functional: add test_loader_incremental
  • functional: move retrieve_sources out of the FunctionalLoader class
  • functional: test the origin_visit
  • functional: add test_uncompress_failure
  • functional: minor fixes in tests
Mon, Mar 16, 5:13 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: add extra_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mon, Mar 16, 5:03 PM

Fri, Mar 13

lewo added inline comments to D2792: Functional Package Loader.
Fri, Mar 13, 11:58 PM
lewo updated the diff for D2792: Functional Package Loader.
  • package.loader: add origin argument
  • Add the functional loader
  • cli: add the functional loader in the cli tests
  • functional: add test for non json sources files
  • functional: improve test_loader_two_visits
  • functional: add test_loader_incremental
  • functional: move retrieve_sources out of the FunctionalLoader class
  • functional: test the origin_visit
  • functional: add test_uncompress_failure
  • functional: minor fixes in tests
Fri, Mar 13, 11:58 PM
lewo added a comment to D2792: Functional Package Loader.

So here, i'm missing:

  • loading scenario which test the incremental nature of the visit (that'd test resolve_revision_from)
Fri, Mar 13, 5:16 PM
lewo updated the diff for D2792: Functional Package Loader.
  • functional: improve test_loader_two_visits
  • functional: add test_loader_incremental
  • functional: move retrieve_sources out of the FunctionalLoader class
  • functional: test the origin_visit
  • functional: add test_uncompress_failure
Fri, Mar 13, 5:14 PM
lewo added a comment to D2025: [wip] swh.lister.functionalPackages: add lister getting sources from a JSON file.

@civodul @zimoun I'm wondering if you generate a sources.json file for any commit of your guix repository or only for those that have been evaluated and pushed to your binary cache by your CI?

Fri, Mar 13, 10:36 AM · Lister

Thu, Mar 12

lewo created P614 nixpkgs sources.json overview.
Thu, Mar 12, 3:59 PM
lewo added a comment to D2792: Functional Package Loader.

I actually don't know how should I manage errors. It seems exception are generally just emitted, without a dedicated log message.
How do you catch errors on production?

Thu, Mar 12, 3:12 PM
lewo updated the diff for D2792: Functional Package Loader.
  • functional: add test for non json sources files
Thu, Mar 12, 3:06 PM
lewo planned changes to D2807: functional.loader: add a pointer to the eval revision.
Thu, Mar 12, 9:38 AM

Wed, Mar 11

lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.

Try to base on functional-loader branch

Wed, Mar 11, 3:46 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • functional: create a branch named evaluation pointing to the evaluation commit
Wed, Mar 11, 3:32 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • functional: create a branch named evaluation pointing to the evaluation commit
Wed, Mar 11, 3:31 PM
lewo updated the diff for D2807: functional.loader: add a pointer to the eval revision.
  • package.loader: ignore non tarball source
  • package.loader: add origin argument
  • Add the functional loader
  • cli: add the functional loader in the cli tests
  • package.loader: add hook_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Wed, Mar 11, 3:19 PM
lewo retitled D2792: Functional Package Loader from wip: Functional Package Loader to Functional Package Loader.
Wed, Mar 11, 3:00 PM
lewo added a comment to D2792: Functional Package Loader.

@ardumont I squashed commits and do some cleaning and remove the WIP status.

Wed, Mar 11, 3:00 PM
lewo updated the diff for D2792: Functional Package Loader.
  • package.loader: add origin argument
  • Add the functional loader
  • cli: add the functional loader in the cli tests
Wed, Mar 11, 2:59 PM
lewo updated the summary of D2792: Functional Package Loader.
Wed, Mar 11, 12:19 PM
lewo updated the diff for D2792: Functional Package Loader.
  • cli: add the functional loader in the cli tests
Wed, Mar 11, 11:56 AM
lewo updated the diff for D2792: Functional Package Loader.
  • cli: add the functional loader in the cli tests
Wed, Mar 11, 11:34 AM
lewo updated the diff for D2792: Functional Package Loader.
  • functional: order entry points
  • cli: add the functional loader in the cli tests
Wed, Mar 11, 11:28 AM

Mar 10 2020

lewo added inline comments to D2792: Functional Package Loader.
Mar 10 2020, 6:52 PM
lewo updated the diff for D2792: Functional Package Loader.

I created a new diff containing the evaluation branch: see D2807 instead.

Mar 10 2020, 6:51 PM
lewo updated the task description for T1991: Implement a Guix/Nix loader.
Mar 10 2020, 6:49 PM · Core Loader, Lister
lewo created D2807: functional.loader: add a pointer to the eval revision.
Mar 10 2020, 6:48 PM
lewo updated the task description for T1991: Implement a Guix/Nix loader.
Mar 10 2020, 6:42 PM · Core Loader, Lister
lewo planned changes to D2792: Functional Package Loader.
Mar 10 2020, 6:31 PM
lewo updated the diff for D2792: Functional Package Loader.
  • package.loader: add hook_branches method
  • functional: create a branch named evaluation pointing to the evaluation commit
Mar 10 2020, 6:27 PM
lewo updated the diff for D2792: Functional Package Loader.
  • functional: use the visit fixture in the test
  • functional: add comments, licenses...
  • functional: add provider and when in metadata.extrinsic
  • functional: type _retrieve_sources
Mar 10 2020, 11:46 AM

Mar 9 2020

lewo updated the summary of D2792: Functional Package Loader.
Mar 9 2020, 5:45 PM
lewo created D2793: Use /usr/bin/env bash instead of /bin/bash.
Mar 9 2020, 5:39 PM