nixguix: Override known_artifacts to filter out evaluation branch
ClosedPublic
Actions

Authored by ardumont on May 25 2020, 6:44 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T2411: Deploy nixguix loader

Commits

rDLDBASE5ba92ac21957: nixguix: Override known_artifacts to filter out evaluation branch

Summary

This branch does not have the right metadata format.

This actually is the reason the current nixguix loader refuses to load from a
recent snapshot.

This has been patched in production and this is now loading.

Related to T2411

Test Plan

tox
new run triggered on patch production

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.May 25 2020, 6:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 25 2020, 6:44 PM

Build is green

Patch application report for D3178 (id=11296)

Rebasing onto 08bb24f1f0...

Current branch diff-target is up to date.

Changes applied before test

commit ba8c9c9f6440b574327757b457e3f4fa0dea6dd5
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 25 18:41:39 2020 +0200

    nixguix: Override known_artifacts to filter out evaluation branch
    
    This branch does not have the right metadata format. This actually is the
    culprit which makes the current nixguix loader fail to load new visit.
    
    This possibly replaces altogether D2949.
    
    Related to D2949
    Related to T2411

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/41/ for more details.

Harbormaster completed remote builds in B12488: Diff 11296.May 25 2020, 6:46 PM

ardumont mentioned this in D2949: nixguix: catch and log artifact resolution failures.May 25 2020, 6:52 PM

I'm wondering if we should not catch the exception on a missing metadatas instead. It is much more simple and I think we could have more branches like the evaluation one in the future. If we add git sources, the git loader will be in charge of loading the source and the nixguix loader will still add a pending branch to the snapshot.

But, i'm fine with this change. When we add git sources, we could still modify the current implementation!

ardumont mentioned this in T2371: nixguix: fails to use previous visit snapshot.May 26 2020, 9:48 AM

Rework commit message

ardumont edited the summary of this revision. (Show Details)May 26 2020, 9:56 AM

Build is green

Patch application report for D3178 (id=11297)

Rebasing onto 08bb24f1f0...

Current branch diff-target is up to date.

Changes applied before test

commit 5ba92ac21957c2bc10a5b416cae9e29c929d815a
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon May 25 18:41:39 2020 +0200

    nixguix: Override known_artifacts to filter out evaluation branch
    
    As that branch is a special case of targetting nixpkgs, this does not have the
    same and expected metadata the other revisions do. Thus crashing the loader
    when this one tries to resolve from a snapshot the already seen artifacts (by
    looking into the metadata).
    
    This commits fixes that behavior by excluding the "evaluation" branch from the
    list of revisions to resolve.
    
    Related to T2411

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/42/ for more details.

Harbormaster completed remote builds in B12489: Diff 11297.May 26 2020, 9:57 AM

Accepted by @lewo (though not with the forge button :D)

This revision was not accepted when it landed; it landed in state Needs Review.May 26 2020, 10:00 AM

Closed by commit rDLDBASE5ba92ac21957: nixguix: Override known_artifacts to filter out evaluation branch (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLDBASE5ba92ac21957: nixguix: Override known_artifacts to filter out evaluation branch.