Differential D8996

jobs/tools: Add swh-jenkins-dockerfiles job for gitlab repository
ClosedPublic
Actions

Authored by anlambert on Jan 4 2023, 5:23 PM.

Details

Reviewers

ardumont

Group Reviewers

System administrators

Commits

rCJSWH6c3d1269d8f6: jobs/tools: Add swh-jenkins-dockerfiles job for gitlab repository

Summary

This job rebuild the docker images used by Jenkins to run jobs.
It will be triggered on push events for the swh-jenkins-dockerfiles
repository hosted on SWH GitLab.

Diff Detail

Repository

rCJSWH Jenkins jobs

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 4 2023, 5:23 PM

Herald added a reviewer: System administrators. · View Herald TranscriptJan 4 2023, 5:23 PM

anlambert requested review of this revision.Jan 4 2023, 5:23 PM

Harbormaster completed remote builds in B33418: Diff 32445.Jan 4 2023, 5:23 PM

anlambert added a child revision: D8997: jobs: Remove unused scm configuration for pipeline jobs.Jan 4 2023, 5:29 PM

Fix variable substitution in yaml configuration

Harbormaster completed remote builds in B33420: Diff 32447.Jan 4 2023, 6:15 PM

lotm (looks ok to me ;)

some questions inline.

jobs/tools/dockerfiles.yaml
27	shouldn't the workspace be cleaned up?
28	is it required at all (since it's empty and phab specifics, maybe just drop it) or is it somehow to empty that key's associated value (coming from &swh_jenkins_dockerfiles)?

This revision is now accepted and ready to land.Jan 5 2023, 2:33 PM

anlambert added inline comments.Jan 5 2023, 2:53 PM

jobs/tools/dockerfiles.yaml
27	Phabricator job do not cleanup so I kept the same behavior, not sure if it is required.
28	Setting auth-token to empty deactivates the Jenkins endpoints to start jobs through HTTP requests (which is what Phabricator uses). Gitlab plugin for Jenkins setups its own endpoints for starting jobs through webhooks. This setting will go away when Phabricator related jobs will be removed from the Jenkins configuration (once we fully migrated to GitLab).