Differential D8975

Add missing _seconds_total unit to swh_outbound_api_sleep metric
ClosedPublic
Actions

Authored by vlorentz on Dec 21 2022, 3:56 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCORE8c455e6324a2: Add missing _seconds_total unit to swh_outbound_api_sleep metric

Diff Detail

Repository

rDCORE Foundations and core functionalities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 21 2022, 3:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 21 2022, 3:56 PM

Build is green

Patch application report for D8975 (id=32347)

Rebasing onto 311113c6b7...

Current branch diff-target is up to date.

Changes applied before test

commit 1fd7a80ec609396c7bbff475f222a5622def6fff
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 21 15:56:16 2022 +0100

    Add missing _seconds unit to swh_outbound_api_sleep metric

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/495/ for more details.

Harbormaster completed remote builds in B33334: Diff 32347.Dec 21 2022, 3:58 PM

vlorentz requested review of this revision.Dec 21 2022, 3:58 PM

vlorentz added a child revision: D8976: Document new metrics on outgoing API requests.Dec 21 2022, 3:58 PM

vlorentz added a parent revision: D8959: github: Export statsd metrics about API requests and token usage.Dec 21 2022, 3:59 PM

vlorentz retitled this revision from Add missing _seconds unit to swh_outbound_api_sleep metric to Add missing _seconds_total unit to swh_outbound_api_sleep metric.

even better unit

Build is green

Patch application report for D8975 (id=32350)

Rebasing onto 311113c6b7...

Current branch diff-target is up to date.

Changes applied before test

commit 8c455e6324a287bb58c4e9cbbd757368e2029aca
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Dec 21 15:56:16 2022 +0100

    Add missing _seconds_total unit to swh_outbound_api_sleep metric

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/496/ for more details.

Harbormaster completed remote builds in B33337: Diff 32350.Dec 21 2022, 4:02 PM

ardumont accepted this revision.Jan 2 2023, 2:59 PM

This revision is now accepted and ready to land.Jan 2 2023, 2:59 PM

Closed by commit rDCORE8c455e6324a2: Add missing _seconds_total unit to swh_outbound_api_sleep metric (authored by vlorentz). · Explain WhyJan 4 2023, 11:24 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCORE8c455e6324a2: Add missing _seconds_total unit to swh_outbound_api_sleep metric.