Page MenuHomeSoftware Heritage

origin_contributors: Rename 'person' to 'contributor' in outputs
ClosedPublic

Authored by vlorentz on Dec 19 2022, 6:10 PM.

Details

Summary

It's slightly more accurate

(on request from @zack)

Depends on D8971

Diff Detail

Repository
rDGRPH Compressed graph representation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8972 (id=32316)

Could not rebase; Attempt merge onto eccd978d45...

Merge made by the 'recursive' strategy.
 .../java/org/softwareheritage/graph/SwhGraph.java  |  5 +++
 .../softwareheritage/graph/SwhGraphProperties.java |  7 ++-
 .../graph/utils/ListOriginContributors.java        | 27 +++++++++---
 swh/graph/luigi/origin_contributors.py             | 42 +++++++++++-------
 swh/graph/tests/test_origin_contributors.py        | 50 +++++++++++++++-------
 5 files changed, 94 insertions(+), 37 deletions(-)
Changes applied before test
commit 6bea49d58f54988c28e37df1690664b4afc6a237
Merge: eccd978 2a58508
Author: Jenkins user <jenkins@localhost>
Date:   Mon Dec 19 17:10:58 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 2a5850865fe418fc8049334a9bdb9882e0cb2e41
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 18:10:17 2022 +0100

    origin_contributors: Rename 'person' to 'contributor' in outputs
    
    It's slightly more accurate

commit c5211ea253b72c88d293daccf503ce2125e10db9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 17:54:52 2022 +0100

    origin_contributors: Write table mapping origin ID to origin URL (base64-encoded)

commit 73c36d4a5abb335acacfdba1d5b3ebca3a4e6b49
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 17:45:09 2022 +0100

    origin_contributors: Use origin IDs instead of SWHIDs
    
    Origin pseudo-SWHIDs are kind of useless on their own, as there is no public API
    to resolve them yet; so we might as well produce integers instead.
    
    A future commit will add a mapping table to URLs, which are actually
    useful.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/343/ for more details.

This revision is now accepted and ready to land.Jan 2 2023, 2:14 PM

Build has FAILED

Patch application report for D8972 (id=32396)

Could not rebase; Attempt merge onto eccd978d45...

Updating eccd978..43567e6
Fast-forward
 .../java/org/softwareheritage/graph/SwhGraph.java  |  5 +++
 .../softwareheritage/graph/SwhGraphProperties.java |  7 ++-
 .../graph/utils/ListOriginContributors.java        | 27 +++++++++---
 swh/graph/luigi/origin_contributors.py             | 42 +++++++++++-------
 swh/graph/tests/test_origin_contributors.py        | 50 +++++++++++++++-------
 5 files changed, 94 insertions(+), 37 deletions(-)
Changes applied before test
commit 43567e66a132ece824fb47f47995ab91ccf1932d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 18:10:17 2022 +0100

    origin_contributors: Rename 'person' to 'contributor' in outputs
    
    It's slightly more accurate

commit b7a991441696fdec8a59e7edc4d9f1e7c886dba4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 17:54:52 2022 +0100

    origin_contributors: Write table mapping origin ID to origin URL (base64-encoded)

commit 09365b488aa1381923708f1232d7b1ccf43e9555
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 17:45:09 2022 +0100

    origin_contributors: Use origin IDs instead of SWHIDs
    
    Origin pseudo-SWHIDs are kind of useless on their own, as there is no public API
    to resolve them yet; so we might as well produce integers instead.
    
    A future commit will add a mapping table to URLs, which are actually
    useful.

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/346/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/346/console

This revision was landed with ongoing or failed builds.Jan 3 2023, 11:39 AM
This revision was automatically updated to reflect the committed changes.