Remove unused dependency on swh.core.api.asynchronous
ClosedPublic
Actions

Authored by vlorentz on Jan 3 2023, 11:14 AM.

Details

Reviewers

douardda
ardumont

Group Reviewers

Reviewers

Commits

rDGRPHf87e0a3c3c3b: Remove unused dependency on swh.core.api.asynchronous

Summary

RPCServerApp inherits from aiohttp.web.Application, and GraphServerApp
does not use any of the features added by RPCServerApp

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 3 2023, 11:14 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 3 2023, 11:14 AM

Awesome!

requirements.txt already has aiohttp, hasn't it?

swh/graph/http_rpc_server.py
1	first copyright change of the year, i think ;)

Build is green

Patch application report for D8992 (id=32397)

Could not rebase; Attempt merge onto eccd978d45...

Updating eccd978..f87e0a3
Fast-forward
 .../java/org/softwareheritage/graph/SwhGraph.java  |  5 +++
 .../softwareheritage/graph/SwhGraphProperties.java |  7 ++-
 .../graph/utils/ListOriginContributors.java        | 27 +++++++++---
 swh/graph/http_rpc_server.py                       |  5 +--
 swh/graph/luigi/origin_contributors.py             | 42 +++++++++++-------
 swh/graph/tests/test_origin_contributors.py        | 50 +++++++++++++++-------
 6 files changed, 96 insertions(+), 40 deletions(-)

Changes applied before test

commit f87e0a3c3c3b43a5ad9f9c6c14b4124ae295963c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 3 11:14:25 2023 +0100

    Remove unused dependency on swh.core.api.asynchronous
    
    RPCServerApp inherits from aiohttp.web.Application, and GraphServerApp
    does not use any of the features added by RPCServerApp

commit 43567e66a132ece824fb47f47995ab91ccf1932d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 18:10:17 2022 +0100

    origin_contributors: Rename 'person' to 'contributor' in outputs
    
    It's slightly more accurate

commit b7a991441696fdec8a59e7edc4d9f1e7c886dba4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 17:54:52 2022 +0100

    origin_contributors: Write table mapping origin ID to origin URL (base64-encoded)

commit 09365b488aa1381923708f1232d7b1ccf43e9555
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Dec 19 17:45:09 2022 +0100

    origin_contributors: Use origin IDs instead of SWHIDs
    
    Origin pseudo-SWHIDs are kind of useless on their own, as there is no public API
    to resolve them yet; so we might as well produce integers instead.
    
    A future commit will add a mapping table to URLs, which are actually
    useful.

See https://jenkins.softwareheritage.org/job/DGRPH/job/tests-on-diff/347/ for more details.

Harbormaster completed remote builds in B33383: Diff 32397.Jan 3 2023, 11:20 AM

vlorentz requested review of this revision.Jan 3 2023, 11:20 AM

I trust the tests to validate the "GraphServerApp does not use any of the features added by RPCServerApp" assertion :-)

This revision is now accepted and ready to land.Jan 3 2023, 11:30 AM

ardumont accepted this revision.Jan 3 2023, 11:31 AM

ardumont added inline comments.

swh/graph/http_rpc_server.py
7	py4j is no longer used i think (but that's for another diff)

In D8992#233725, @douardda wrote:

I trust the tests to validate the "GraphServerApp does not use any of the features added by RPCServerApp" assertion :-)

yes

Closed by commit rDGRPHf87e0a3c3c3b: Remove unused dependency on swh.core.api.asynchronous (authored by vlorentz). · Explain WhyJan 3 2023, 11:39 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDGRPHf87e0a3c3c3b: Remove unused dependency on swh.core.api.asynchronous.