Page MenuHomeSoftware Heritage
Feed Advanced Search

Yesterday

ardumont updated the test plan for D3504: 158: Make schema and migration converge so the migration works.
Sat, Jul 11, 8:54 AM
ardumont added inline comments to D3504: 158: Make schema and migration converge so the migration works.
Sat, Jul 11, 8:54 AM
ardumont created D3504: 158: Make schema and migration converge so the migration works.
Sat, Jul 11, 8:53 AM

Fri, Jul 10

ardumont updated the summary of D3503: check_snapshot: Check existence down to the contents.
Fri, Jul 10, 7:01 PM
ardumont updated the summary of D3502: check_snapshot: Check existence down to the first level directories.
Fri, Jul 10, 7:01 PM
ardumont added a task to D3502: check_snapshot: Check existence down to the first level directories: T2483: tests: Make check-snapshot utility test function recursively check targetted object exists.
Fri, Jul 10, 7:01 PM
ardumont added a task to D3503: check_snapshot: Check existence down to the contents: T2483: tests: Make check-snapshot utility test function recursively check targetted object exists.
Fri, Jul 10, 7:01 PM
ardumont added revisions to T2483: tests: Make check-snapshot utility test function recursively check targetted object exists: D3502: check_snapshot: Check existence down to the first level directories, D3503: check_snapshot: Check existence down to the contents.
Fri, Jul 10, 7:01 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont removed a task from D3502: check_snapshot: Check existence down to the first level directories: T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin.
Fri, Jul 10, 7:01 PM
ardumont removed a task from D3503: check_snapshot: Check existence down to the contents: T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin.
Fri, Jul 10, 7:01 PM
ardumont removed revisions from T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin: D3503: check_snapshot: Check existence down to the contents, D3502: check_snapshot: Check existence down to the first level directories.
Fri, Jul 10, 7:01 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont updated the diff for D3503: check_snapshot: Check existence down to the contents.

Rebase

Fri, Jul 10, 6:21 PM
ardumont updated the diff for D3502: check_snapshot: Check existence down to the first level directories.

Clarify commnents and drops unneeded checks

Fri, Jul 10, 6:20 PM
ardumont retitled D3502: check_snapshot: Check existence down to the first level directories from check_snapshot: Check existence up to the first level directories to check_snapshot: Check existence down to the first level directories.
Fri, Jul 10, 6:14 PM
ardumont created D3503: check_snapshot: Check existence down to the contents.
Fri, Jul 10, 6:14 PM
ardumont added a revision to T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin: D3503: check_snapshot: Check existence down to the contents.
Fri, Jul 10, 6:14 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont updated the diff for D3502: check_snapshot: Check existence down to the first level directories.

Drop wrong and unused variable instruction

Fri, Jul 10, 5:49 PM
ardumont updated the diff for D3502: check_snapshot: Check existence down to the first level directories.

Update tests docstring about unsupported test case

Fri, Jul 10, 5:42 PM
ardumont created D3502: check_snapshot: Check existence down to the first level directories.
Fri, Jul 10, 5:40 PM
ardumont added a revision to T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin: D3502: check_snapshot: Check existence down to the first level directories.
Fri, Jul 10, 5:40 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont added a comment to D3501: Use bytes as snapshot id and get rid of dict manipulation in check_snapshot().

fwiw, i was heading towards making the transition you started *after* having deployed

the current implementation of "check-snapshot" (without that diff so with the internal
manipulation) And then commit the current diff ;)

Fri, Jul 10, 5:18 PM
ardumont accepted D3456: Make metadata-related endpoints consistent with other endpoints by using Iterables of swh-model objects instead of a dict..

Looks good.

Fri, Jul 10, 5:03 PM
ardumont added a comment to D3501: Use bytes as snapshot id and get rid of dict manipulation in check_snapshot().

This would break tests in other swh-loader-xx unless D3499 D3498 and D3496
are landed. <- this is possibly a lie...

Fri, Jul 10, 5:01 PM
ardumont committed rDLDBASE9f04d72516fc: Expose a pytest_plugin module so other loaders can reuse for tests (authored by ardumont).
Expose a pytest_plugin module so other loaders can reuse for tests
Fri, Jul 10, 4:58 PM
ardumont closed D3495: Expose a pytest_plugin module so other loaders can reuse for tests.
Fri, Jul 10, 4:58 PM
ardumont updated the summary of D3495: Expose a pytest_plugin module so other loaders can reuse for tests.
Fri, Jul 10, 4:57 PM
ardumont closed D3493: pytest: Remove no longer needed pytest setup.
Fri, Jul 10, 4:56 PM
ardumont committed rDLDBASE1f876c8eba8b: pytest: Remove no longer needed pytest setup (authored by ardumont).
pytest: Remove no longer needed pytest setup
Fri, Jul 10, 4:56 PM
ardumont committed rDLDBASEae7e38882313: Explicit types in __init__ files (authored by ardumont).
Explicit types in __init__ files
Fri, Jul 10, 4:56 PM
ardumont closed D3497: Explicit types in __init__ files.
Fri, Jul 10, 4:56 PM
ardumont updated the diff for D3495: Expose a pytest_plugin module so other loaders can reuse for tests.

Rebase

Fri, Jul 10, 4:55 PM
ardumont updated the diff for D3493: pytest: Remove no longer needed pytest setup.

Rebase

Fri, Jul 10, 4:53 PM
ardumont updated the diff for D3497: Explicit types in __init__ files.

Rebase on latest master

Fri, Jul 10, 4:50 PM
ardumont accepted D3494: Fix branches types in tests.

;)

Fri, Jul 10, 4:28 PM
ardumont updated the diff for D3497: Explicit types in __init__ files.

Rebase

Fri, Jul 10, 4:16 PM
ardumont updated the diff for D3495: Expose a pytest_plugin module so other loaders can reuse for tests.

Rebase

Fri, Jul 10, 4:16 PM
ardumont updated the diff for D3493: pytest: Remove no longer needed pytest setup.

Rebase on latest master

Fri, Jul 10, 4:15 PM
ardumont committed rDLDBASEfe28c44349dd: Make check_snapshot ensure snapshot object references exist (authored by ardumont).
Make check_snapshot ensure snapshot object references exist
Fri, Jul 10, 4:14 PM
ardumont closed D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Fri, Jul 10, 4:14 PM
ardumont added inline comments to D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Fri, Jul 10, 4:03 PM
ardumont added a comment to D3496: Fix branches types in tests.

you are ahead of time, new check_snapshot did not yet get released for that.

Fri, Jul 10, 3:59 PM
ardumont updated the summary of D3495: Expose a pytest_plugin module so other loaders can reuse for tests.
Fri, Jul 10, 3:55 PM
ardumont created D3497: Explicit types in __init__ files.
Fri, Jul 10, 3:52 PM
ardumont reopened T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin, a subtask of T2481: Migrate dvcs loader tests code to pytest, as Open.
Fri, Jul 10, 3:44 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont reopened T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin as "Open".

Reopening as i'm still refactoring/cleaning up more modules.

Fri, Jul 10, 3:44 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont added a revision to T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin: D3495: Expose a pytest_plugin module so other loaders can reuse for tests.
Fri, Jul 10, 3:42 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont created D3495: Expose a pytest_plugin module so other loaders can reuse for tests.
Fri, Jul 10, 3:42 PM
ardumont accepted D3494: Fix branches types in tests.

id should be bytes as well
but that can be an extra diff (as you wish).

Fri, Jul 10, 3:36 PM
ardumont created D3493: pytest: Remove no longer needed pytest setup.
Fri, Jul 10, 3:31 PM
ardumont updated the diff for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.

Rework commit message (again)

Fri, Jul 10, 3:24 PM
ardumont updated the diff for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.

Rework commit message

Fri, Jul 10, 3:19 PM
ardumont updated the diff for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.

Drop unneeded instructions

Fri, Jul 10, 3:13 PM
ardumont added inline comments to D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Fri, Jul 10, 3:12 PM
ardumont updated the diff for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.

adapt according to review: make model objects ;)

Fri, Jul 10, 3:11 PM
ardumont added inline comments to D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Fri, Jul 10, 3:01 PM
ardumont updated the diff for D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
  • Rebase on latest master
  • Adapt according to review
Fri, Jul 10, 2:51 PM
ardumont updated the summary of D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Fri, Jul 10, 1:09 PM
ardumont committed rDSCHf842383ad680: d/rules: Avoid double pytest plugin loading clash (authored by ardumont).
d/rules: Avoid double pytest plugin loading clash
Fri, Jul 10, 1:05 PM
ardumont committed rDSCH254e24a68780: Do no expose pytest-plugin through setuptools, let modules require it when… (authored by ardumont).
Do no expose pytest-plugin through setuptools, let modules require it when…
Fri, Jul 10, 1:00 PM
ardumont closed D3492: setup: Do no expose the pytest-plugin, let modules require it.
Fri, Jul 10, 1:00 PM
ardumont added a comment to D3478: loader.core: Make check_snapshot ensure snapshot object references exist.

Thanks for the review, will adapt once i rebase on D3473 ;)

Fri, Jul 10, 12:54 PM
ardumont added inline comments to D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Fri, Jul 10, 12:53 PM
ardumont committed rDLDBASE72590f998088: check_snapshot: Allow to check using both Snapshot and dict (authored by ardumont).
check_snapshot: Allow to check using both Snapshot and dict
Fri, Jul 10, 12:50 PM
ardumont closed D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Fri, Jul 10, 12:50 PM
ardumont added a comment to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.

As agreed on irc, i'll keep the snapshot dict conversion for now.
When done with the initial goal D3478, i'll migrate the tests
so they stop using dict and start using Snasphot objects instead.

Fri, Jul 10, 12:47 PM
ardumont updated the diff for D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.

Squash commits

Fri, Jul 10, 12:44 PM
ardumont updated the diff for D3492: setup: Do no expose the pytest-plugin, let modules require it.

Rework commit message (I copy/pasted from storage commit and kept reference to
storage ¯\_(ツ)_/¯, now it's fixed)

Fri, Jul 10, 12:28 PM
ardumont updated the summary of D3492: setup: Do no expose the pytest-plugin, let modules require it.
Fri, Jul 10, 12:26 PM
ardumont updated the diff for D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.

Rework according to remarks

Fri, Jul 10, 12:21 PM
ardumont updated the summary of D3492: setup: Do no expose the pytest-plugin, let modules require it.
Fri, Jul 10, 12:12 PM
ardumont added a revision to T2484: Move sharable fixtures out of conftest into a dedicated pytest plugin: D3492: setup: Do no expose the pytest-plugin, let modules require it.
Fri, Jul 10, 12:11 PM · SVN Loader, Mercurial loader, Git loader, Core Loader
ardumont created D3492: setup: Do no expose the pytest-plugin, let modules require it.
Fri, Jul 10, 12:11 PM
ardumont added inline comments to D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Fri, Jul 10, 12:04 PM
ardumont accepted D3491: Use the new object_metadata_add endpoint instead of origin_metadata_add..

Looks good.

Fri, Jul 10, 12:02 PM
ardumont added inline comments to D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Fri, Jul 10, 12:00 PM
ardumont added inline comments to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Fri, Jul 10, 11:55 AM
ardumont added inline comments to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Fri, Jul 10, 11:26 AM
ardumont added inline comments to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Fri, Jul 10, 11:13 AM
ardumont updated the summary of D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Fri, Jul 10, 11:10 AM
ardumont added inline comments to D3456: Make metadata-related endpoints consistent with other endpoints by using Iterables of swh-model objects instead of a dict..
Fri, Jul 10, 10:59 AM
ardumont added a comment to D3456: Make metadata-related endpoints consistent with other endpoints by using Iterables of swh-model objects instead of a dict..

Made a first pass.

Fri, Jul 10, 10:51 AM
ardumont added inline comments to D3456: Make metadata-related endpoints consistent with other endpoints by using Iterables of swh-model objects instead of a dict..
Fri, Jul 10, 10:47 AM
ardumont added inline comments to D3456: Make metadata-related endpoints consistent with other endpoints by using Iterables of swh-model objects instead of a dict..
Fri, Jul 10, 10:47 AM
ardumont added inline comments to D3456: Make metadata-related endpoints consistent with other endpoints by using Iterables of swh-model objects instead of a dict..
Fri, Jul 10, 10:39 AM
ardumont added inline comments to D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Fri, Jul 10, 10:25 AM
ardumont added inline comments to D3456: Make metadata-related endpoints consistent with other endpoints by using Iterables of swh-model objects instead of a dict..
Fri, Jul 10, 10:19 AM
ardumont committed rDSTObe19086fd34b: d/changelog: Bump new release (authored by ardumont).
d/changelog: Bump new release
Fri, Jul 10, 9:24 AM
ardumont committed rDSTOe61adec8ec09: d/rules: Avoid double pytest plugin loading clash (authored by ardumont).
d/rules: Avoid double pytest plugin loading clash
Fri, Jul 10, 9:24 AM
ardumont accepted D3490: Drop useless use of pifpaf.
Fri, Jul 10, 9:04 AM
ardumont committed rDSTO23318c21d101: setup: Do no expose the pytest-plugin any longer (authored by ardumont).
setup: Do no expose the pytest-plugin any longer
Fri, Jul 10, 8:29 AM
ardumont closed D3475: setup: Do no expose the pytest-plugin any longer.
Fri, Jul 10, 8:29 AM
ardumont committed rDCORE028ef739da91: test_serializers: Refactor using pytest (authored by ardumont).
test_serializers: Refactor using pytest
Fri, Jul 10, 8:21 AM
ardumont closed D3461: test_serializers: Refactor using pytest.
Fri, Jul 10, 8:21 AM
ardumont updated the diff for D3475: setup: Do no expose the pytest-plugin any longer.

Rebase on latest master

Fri, Jul 10, 8:19 AM

Thu, Jul 9

ardumont updated the summary of D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Thu, Jul 9, 7:02 PM
ardumont retitled D3473: loader.core: check_snapshot: Allow to check using both Snapshot and dict objects from check_snapshot: Allow to check using both Snapshot and dict objects to loader.core: check_snapshot: Allow to check using both Snapshot and dict objects.
Thu, Jul 9, 7:01 PM
ardumont accepted D3488: Clean up the swh.scheduler pytest plugin imports.

oh, indeed.

Thu, Jul 9, 6:52 PM
ardumont updated the diff for D3475: setup: Do no expose the pytest-plugin any longer.
  • Move the pytest_plugins variable definition to the root conftest.py
  • Rework commit message to align with the diff description
Thu, Jul 9, 6:51 PM
ardumont updated the summary of D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Thu, Jul 9, 6:43 PM
ardumont updated the summary of D3478: loader.core: Make check_snapshot ensure snapshot object references exist.
Thu, Jul 9, 6:38 PM